)]}'
{"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"363277f2d27f67bb91bd8f1725f3cba19f94cfc6","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        if project is not None:"},{"line_number":501,"context_line":"            query \u003d query.filter(models.Resource.project_id \u003d\u003d project)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        for resource, sample in query.all():"},{"line_number":504,"context_line":"            yield api_models.Meter("},{"line_number":505,"context_line":"                name\u003dsample.counter_name,"},{"line_number":506,"context_line":"                type\u003dsample.counter_type,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9XkI%3D","line":503,"updated":"2014-02-07 12:06:08.000000000","message":"Will we remove Meter from api_model?","commit_id":"08542a08dc2caca57c523ef272b00f60c55b136f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"70cc728c5fdf82883c01f0999bf72ed4f4d7ea4f","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        if project is not None:"},{"line_number":501,"context_line":"            query \u003d query.filter(models.Resource.project_id \u003d\u003d project)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        for resource, sample in query.all():"},{"line_number":504,"context_line":"            yield api_models.Meter("},{"line_number":505,"context_line":"                name\u003dsample.counter_name,"},{"line_number":506,"context_line":"                type\u003dsample.counter_type,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9W3s%3D","line":503,"in_reply_to":"AAAAUH%2F9Xd8%3D","updated":"2014-02-07 13:54:28.000000000","message":"so we aren\u0027t really removing meter. if you look at next dependent patch, we\u0027re really just correcting the naming. ie. we have a meter table to define the meter attributes ie. name, unit, type, and then a sample table to define the raw data.","commit_id":"08542a08dc2caca57c523ef272b00f60c55b136f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"92419311537c06af8ac567a47aa16755662a45ea","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        if project is not None:"},{"line_number":501,"context_line":"            query \u003d query.filter(models.Resource.project_id \u003d\u003d project)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        for resource, sample in query.all():"},{"line_number":504,"context_line":"            yield api_models.Meter("},{"line_number":505,"context_line":"                name\u003dsample.counter_name,"},{"line_number":506,"context_line":"                type\u003dsample.counter_type,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9Xd8%3D","line":503,"in_reply_to":"AAAAUH%2F9XkI%3D","updated":"2014-02-07 12:22:11.000000000","message":"Ah, I think I understand now. We cannot remove Meter from api_model because it is common for all backends. Do we have a bp about removing meter from other backends?","commit_id":"08542a08dc2caca57c523ef272b00f60c55b136f"}],"ceilometer/storage/sqlalchemy/migrate_repo/versions/010_add_index_to_meter.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a28aea71c8be24ccd77cc9d97d8f11640671b7fa","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def upgrade(migrate_engine):"},{"line_number":20,"context_line":"    meta \u003d sa.MetaData(bind\u003dmigrate_engine)"},{"line_number":21,"context_line":"    meter \u003d sa.Table(\u0027meter\u0027, meta, autoload\u003dTrue)"},{"line_number":22,"context_line":"    index \u003d sa.Index(\u0027idx_meter_rid_cname\u0027, meter.c.resource_id,"},{"line_number":23,"context_line":"                     meter.c.counter_name)"},{"line_number":24,"context_line":"    index.create(bind\u003dmigrate_engine)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUX%2F%2BgLI%3D","line":21,"updated":"2014-02-20 20:27:59.000000000","message":"I\u0027m confused about the validity of these changes to this pre-existing migration script.\n\nWouldn\u0027t this result in a different schema for a DB that was created from scratch as compared to one upgraded to Icehouse from a pre-existing Havana installation?","commit_id":"d97b4b649c861593df0d0b63bd4a8a656c3eed14"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"da2efd2dd0b6f12b0bfa75fb3ab39aa759bb178b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def upgrade(migrate_engine):"},{"line_number":20,"context_line":"    meta \u003d sa.MetaData(bind\u003dmigrate_engine)"},{"line_number":21,"context_line":"    meter \u003d sa.Table(\u0027meter\u0027, meta, autoload\u003dTrue)"},{"line_number":22,"context_line":"    index \u003d sa.Index(\u0027idx_meter_rid_cname\u0027, meter.c.resource_id,"},{"line_number":23,"context_line":"                     meter.c.counter_name)"},{"line_number":24,"context_line":"    index.create(bind\u003dmigrate_engine)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUX%2F%2Bfq0%3D","line":21,"in_reply_to":"AAAAUX%2F%2BgLI%3D","updated":"2014-02-20 21:27:49.000000000","message":"this should be equivalent. instead of grabbing the column from the model, it\u0027s now directly grabbing the column from the table...\n\nit\u0027s wrong for us to use the model here in (any) migrations because the model only reflects the current representation of schema (as of last script)... where as each of these earlier scripts work on a specific point in time of the schema.","commit_id":"d97b4b649c861593df0d0b63bd4a8a656c3eed14"}],"ceilometer/storage/sqlalchemy/models.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"363277f2d27f67bb91bd8f1725f3cba19f94cfc6","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Base \u003d declarative_base(cls\u003dCeilometerBase)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"sourceassoc \u003d Table(\u0027sourceassoc\u0027, Base.metadata,"},{"line_number":119,"context_line":"                    Column(\u0027meter_id\u0027, Integer,"},{"line_number":120,"context_line":"                           ForeignKey(\"sample.id\")),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9Xmg%3D","line":117,"updated":"2014-02-07 12:06:08.000000000","message":"The question about all \u0027sourceassoc\u0027 table. Why \u0027meter_id\u0027 is kept here?","commit_id":"08542a08dc2caca57c523ef272b00f60c55b136f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"70cc728c5fdf82883c01f0999bf72ed4f4d7ea4f","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Base \u003d declarative_base(cls\u003dCeilometerBase)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"sourceassoc \u003d Table(\u0027sourceassoc\u0027, Base.metadata,"},{"line_number":119,"context_line":"                    Column(\u0027meter_id\u0027, Integer,"},{"line_number":120,"context_line":"                           ForeignKey(\"sample.id\")),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9W3o%3D","line":117,"in_reply_to":"AAAAUH%2F9Xmg%3D","updated":"2014-02-07 13:54:28.000000000","message":"i was lazy... and sort of hoping this table would go away. :)\n\ni will fix it.","commit_id":"08542a08dc2caca57c523ef272b00f60c55b136f"}]}