)]}'
{"ceilometer/network/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7a1315349895150e8df5ca978c5d7692d902b46d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            unit\u003dunit_value,"},{"line_number":88,"context_line":"            volume\u003d1,"},{"line_number":89,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":90,"context_line":"            project_id\u003dmessage[\u0027_context_tenant_id\u0027],"},{"line_number":91,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027id\u0027],"},{"line_number":92,"context_line":"            message\u003dmessage)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9W14%3D","line":90,"updated":"2014-02-07 13:59:31.000000000","message":"might be safer to check payload first and then use _context_tenant_id as backup... or is payload.tenant_id completely unreliable and it will always be same as _context_tenant_id","commit_id":"0365edfa5fcdae079a7569df96d625b05f468337"},{"author":{"_account_id":7627,"name":"Harri Hämäläinen","email":"hhamalai@iki.fi","username":"hhamalai"},"change_message_id":"09e8accd946c050484f3758ea5cdda4f72f0f31e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            unit\u003dunit_value,"},{"line_number":88,"context_line":"            volume\u003d1,"},{"line_number":89,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":90,"context_line":"            project_id\u003dmessage[\u0027_context_tenant_id\u0027],"},{"line_number":91,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027id\u0027],"},{"line_number":92,"context_line":"            message\u003dmessage)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F3Kc%3D","line":90,"in_reply_to":"AAAAUH%2F9W14%3D","updated":"2014-02-10 10:38:13.000000000","message":"Thanks for the comment. I think this change is reasonable as user_id is already retrieved similarly. Checking the existence of tenant_id in the payload subdocument and using the message\u0027s _context_tenant_id as a backup makes the semantics more prone to obscure errors when the structure of network notifications changes next time.","commit_id":"0365edfa5fcdae079a7569df96d625b05f468337"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2e432df4233209c15f12ad1ce69d64e76809d9a3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            unit\u003dunit_value,"},{"line_number":88,"context_line":"            volume\u003d1,"},{"line_number":89,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":90,"context_line":"            project_id\u003dmessage[\u0027_context_tenant_id\u0027],"},{"line_number":91,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027id\u0027],"},{"line_number":92,"context_line":"            message\u003dmessage)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F1G0%3D","line":90,"in_reply_to":"AAAAUX%2F%2F3Kc%3D","updated":"2014-02-10 14:58:25.000000000","message":"good counterpoint.","commit_id":"0365edfa5fcdae079a7569df96d625b05f468337"}]}
