)]}'
{"ceilometer/tests/db.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"053d1931c47304bbb40a9df2fa4b52b736b9e47f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, conf):"},{"line_number":41,"context_line":"        \"\"\"Use engine with pooling disabled to prevent connections leak"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        print(\"OPEN a new DB connection!!!\")"},{"line_number":44,"context_line":"        self._engine \u003d sqlalchemy.create_engine("},{"line_number":45,"context_line":"            conf.database.connection,"},{"line_number":46,"context_line":"            poolclass\u003dsqlalchemy.pool.NullPool)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2Bnq4%3D","line":43,"updated":"2014-02-20 06:45:37.000000000","message":"can we replace print with LOG.debug or something like instead?","commit_id":"51cecd477fb86021d2255936c3747ce393527c20"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"a8a1af065cdafba99dfbbfced97a3467cb1d67d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, conf):"},{"line_number":41,"context_line":"        \"\"\"Use engine with pooling disabled to prevent connections leak"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        print(\"OPEN a new DB connection!!!\")"},{"line_number":44,"context_line":"        self._engine \u003d sqlalchemy.create_engine("},{"line_number":45,"context_line":"            conf.database.connection,"},{"line_number":46,"context_line":"            poolclass\u003dsqlalchemy.pool.NullPool)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BmH4%3D","line":43,"in_reply_to":"AAAAUX%2F%2Bnq4%3D","updated":"2014-02-20 09:50:38.000000000","message":"Sorry. I will remove this line. It\u0027s was only used for debug.\nI don\u0027t think It\u0027s really useful in logs.","commit_id":"51cecd477fb86021d2255936c3747ce393527c20"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"053d1931c47304bbb40a9df2fa4b52b736b9e47f","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.is_sqla_database \u003d None"},{"line_number":75,"context_line":"        for sql_base in [\u0027mysql\u0027, \u0027postgresql\u0027]:"},{"line_number":76,"context_line":"            if sql_base in self.CONF.database.connection:"},{"line_number":77,"context_line":"                self.is_sqla_database \u003d sql_base"},{"line_number":78,"context_line":"                break"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BnpE%3D","line":76,"updated":"2014-02-20 06:45:37.000000000","message":"Though unlikely in real test environment, this check would result unexpected result if the connection is \"mongo://xxxmysql\".\n\nMaybe to use urlparse or simply \n\nif self.CONF.database.connection.startswith(sql_base)?","commit_id":"51cecd477fb86021d2255936c3747ce393527c20"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"a8a1af065cdafba99dfbbfced97a3467cb1d67d5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.is_sqla_database \u003d None"},{"line_number":75,"context_line":"        for sql_base in [\u0027mysql\u0027, \u0027postgresql\u0027]:"},{"line_number":76,"context_line":"            if sql_base in self.CONF.database.connection:"},{"line_number":77,"context_line":"                self.is_sqla_database \u003d sql_base"},{"line_number":78,"context_line":"                break"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2BmHs%3D","line":76,"in_reply_to":"AAAAUX%2F%2BnpE%3D","updated":"2014-02-20 09:50:38.000000000","message":"Thanks. will do","commit_id":"51cecd477fb86021d2255936c3747ce393527c20"}]}