)]}'
{"ceilometer/compute/pollsters/memory.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f2946c6533154fb599b994b1998a7e68a280739d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"},{"line_number":48,"context_line":"            LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Br%2FI%3D","line":48,"updated":"2014-02-19 19:59:20.000000000","message":"duplicate logs, exception and error both log as log level ERROR... which should just use one. (i notice the other pollsters do this... that is incorrect i believe)\n\nhttp://docs.python.org/2/library/logging.html#logging.exception","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"dded730d63da3266f8f65e44b9e344b6601cc3ac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"},{"line_number":48,"context_line":"            LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BmCg%3D","line":48,"in_reply_to":"AAAAUX%2F%2Br%2FI%3D","updated":"2014-02-20 10:01:49.000000000","message":"Removed LOG.exception(err)","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":6230,"name":"Rob Raymond","email":"rob.raymond@hp.com","username":"rob-raymond"},"change_message_id":"dd90599a1cedb4c0ef3a44db3b78790d342a6611","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        except virt_inspector.InstanceNotFoundException as err:"},{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.error(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BceY%3D","line":44,"updated":"2014-02-21 04:41:42.000000000","message":"The comment seems to indicate that this exception can be expected to happen when instance is deleted. Therefore, should be logged as a warning or info level rather than error.","commit_id":"688addbafdb1325c10dc3345f2a1686f7529cdb6"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"fa0b395e180c2d542f1e0c2e1493e39f31d8218f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            )"},{"line_number":42,"context_line":"        except virt_inspector.InstanceNotFoundException as err:"},{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.error(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Ba4I%3D","line":44,"in_reply_to":"AAAAUX%2F%2BceY%3D","updated":"2014-02-21 09:07:59.000000000","message":"CpuPollster has this log at debug level; hence, changed it to debug.","commit_id":"688addbafdb1325c10dc3345f2a1686f7529cdb6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"},{"line_number":32,"context_line":"            LOG.info(_(\"MEMORY USAGE: %(instance)s %(usage)f\") % ("},{"line_number":33,"context_line":"                     {\u0027instance\u0027: instance.__dict__,"},{"line_number":34,"context_line":"                      \u0027usage\u0027: memory_info.usage}))"},{"line_number":35,"context_line":"            yield util.make_sample_from_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9NU%3D","line":32,"updated":"2014-02-23 15:17:53.000000000","message":"please use a , instead of % here\nThat is:\nLOG.info(_(\"MEMORY USAGE: %(instance)s %(usage)f\"),\n                 {{\u0027instance\u0027: ...","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"},{"line_number":32,"context_line":"            LOG.info(_(\"MEMORY USAGE: %(instance)s %(usage)f\") % ("},{"line_number":33,"context_line":"                     {\u0027instance\u0027: instance.__dict__,"},{"line_number":34,"context_line":"                      \u0027usage\u0027: memory_info.usage}))"},{"line_number":35,"context_line":"            yield util.make_sample_from_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4eo%3D","line":32,"in_reply_to":"AAAAU3%2F%2F9NU%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9NQ%3D","line":46,"updated":"2014-02-23 15:17:53.000000000","message":"ditto","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027) % ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4ek%3D","line":46,"in_reply_to":"AAAAU3%2F%2F9NQ%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"3391fed532f6be981d69936d5b8b9c53064bf307","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F%2Frs%3D","line":28,"updated":"2014-03-02 20:16:43.000000000","message":"Rebase according to https://review.openstack.org/#/c/75006/11 will be needed here too.","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"7feb3e2d448021704d138f9826a6f38aa3ef806c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FyFw%3D","line":28,"in_reply_to":"AAAAVn%2F%2F%2Frs%3D","updated":"2014-03-04 05:48:00.000000000","message":"Done","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"126a505ca2c9d82d4ecad46bcfc3cad1cc568873","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"},{"line_number":32,"context_line":"            LOG.info(_(\"MEMORY USAGE: %(instance)s %(usage)f\"), ("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F%2F2k%3D","line":29,"updated":"2014-03-02 18:59:20.000000000","message":"s/checking/Checking/","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"7feb3e2d448021704d138f9826a6f38aa3ef806c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":29,"context_line":"        LOG.info(_(\u0027checking instance %s\u0027), instance.id)"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            memory_info \u003d manager.inspector.inspect_memory(instance)"},{"line_number":32,"context_line":"            LOG.info(_(\"MEMORY USAGE: %(instance)s %(usage)f\"), ("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FyFs%3D","line":29,"in_reply_to":"AAAAVn%2F%2F%2F2k%3D","updated":"2014-03-04 05:48:00.000000000","message":"Done","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"126a505ca2c9d82d4ecad46bcfc3cad1cc568873","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F%2F2g%3D","line":46,"updated":"2014-03-02 18:59:20.000000000","message":"s/could/Could/","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"7feb3e2d448021704d138f9826a6f38aa3ef806c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":44,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":45,"context_line":"        except Exception as err:"},{"line_number":46,"context_line":"            LOG.error(_(\u0027could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":47,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FyFk%3D","line":46,"in_reply_to":"AAAAVn%2F%2F%2F2g%3D","updated":"2014-03-04 05:48:00.000000000","message":"Done","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"01a296124cb32377d2ff5087a0fb2e63adefae60","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fw34%3D","line":26,"updated":"2014-03-04 08:19:01.000000000","message":"I see the memory is already reported through notification listener https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/notifications/instance.py#L63\n\nWhat\u0027s the difference of this new memory pollster?","commit_id":"bbe4757c9710ad8be197e76e1565907675950b1a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"2cb99e5db5a2fbd0a2ca1f44d3e33b43db968c15","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fwjg%3D","line":26,"in_reply_to":"AAAAVn%2F%2Fw04%3D","updated":"2014-03-04 08:53:18.000000000","message":"if so, than we should NOT use the same sample name \u0027memory\u0027,  otherwise it\u0027s confusing.","commit_id":"bbe4757c9710ad8be197e76e1565907675950b1a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2b5d312fcea363738451c0d170d02273557da25c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2Fw04%3D","line":26,"in_reply_to":"AAAAVn%2F%2Fw34%3D","updated":"2014-03-04 08:29:04.000000000","message":"In the notifications only the amount of allocated memory is included, I assume it is the actual memory usage info, that we do not have for libvirt VMs now, as libvirt does not provide memory utilization information at all.","commit_id":"bbe4757c9710ad8be197e76e1565907675950b1a"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"243914357d337999622a6ddd90eda1516c4b1e75","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FuEI%3D","line":26,"in_reply_to":"AAAAVn%2F%2FwN8%3D","updated":"2014-03-04 14:11:27.000000000","message":"Incorporated the review comment and added a new memory counter memory.usage.","commit_id":"bbe4757c9710ad8be197e76e1565907675950b1a"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"8a591efd87bc611313d966f3fa1a64815018005c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MemoryPollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2FwN8%3D","line":26,"in_reply_to":"AAAAVn%2F%2Fwjg%3D","updated":"2014-03-04 09:31:12.000000000","message":"We incorrectly assumed the memory information available from libvert to be memory usage. Here, we intended to provide memory usage.\n\nFor this review, we can rename the collected memory counter to \u0027memory.usage\u0027 in setup.cfg and rename the pollster to MemoryUsagePollster take up the documentation changes as a bug to be fixed. Any other changes needed to introduce the new metric in ceilometer?","commit_id":"bbe4757c9710ad8be197e76e1565907675950b1a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"afbc037283ce5b4de2f534f456e9604532799fec","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":44,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":45,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":46,"context_line":"            except Exception as err:"},{"line_number":47,"context_line":"                LOG.error(_(\u0027Could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":48,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2FWrA%3D","line":46,"updated":"2014-03-06 17:10:04.000000000","message":"let\u0027s add another scenario. except notimplemtentederror and either pass or log debug message... this shouldn\u0027t be so aggressive to throw a error especially if we know it\u0027s known it\u0027s not implemented","commit_id":"349164bd456206f4a7a27981a6d027d2453aea91"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"a8e5cc42f708ae507a1bc918373ba1f0f549cd8a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":44,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":45,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":46,"context_line":"            except Exception as err:"},{"line_number":47,"context_line":"                LOG.error(_(\u0027Could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":48,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2FQ6I%3D","line":46,"in_reply_to":"AAAAVn%2F%2FTtI%3D","updated":"2014-03-07 07:15:03.000000000","message":"Done","commit_id":"349164bd456206f4a7a27981a6d027d2453aea91"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f7be6dd0ee350a42f617776227df34f326e5c627","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":44,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":45,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":46,"context_line":"            except Exception as err:"},{"line_number":47,"context_line":"                LOG.error(_(\u0027Could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":48,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2FTtI%3D","line":46,"in_reply_to":"AAAAVn%2F%2FWrA%3D","updated":"2014-03-06 22:35:13.000000000","message":"now that i think about it, let\u0027s make it LOG.debug as above.","commit_id":"349164bd456206f4a7a27981a6d027d2453aea91"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"8e4b89319814e362409e92f4e8a38021aa4da1dd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryUsagePollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"},{"line_number":30,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":31,"context_line":"            try:"},{"line_number":32,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage(instance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2FIFA%3D","line":29,"updated":"2014-03-08 19:14:31.000000000","message":"For the last week I faced with logs too many times trying to find out what\u0027s going on. We write it for ourselves and let\u0027s keep it useful :) Obviously we will see that log came from memory.py pollster and it will bring us to decision that \u0027Checking instance\u0027 means checking memory of instance. But it may be written in message because it will make logs more readable. And the second point: debug level. In \u0027info\u0027 we write that instance is being    checked. But the fact that instance is deleted or inspector is not implemented will be sen only in debug lvl. So looking on \u0027info\u0027 lvl we may think that we should see \u0027memory\u0027 stats for the instance. I think that \u0027checking instance\u0027 and \u0027Exceptions of obtaining metrics\u0027 should be on the same lvl. It may be \u0027debug\u0027 or \u0027info\u0027. Maybe it will be better to move all exception info on \u0027warn\u0027 lvl but I don\u0027t insist.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f657c480311013f9242b89452d17559de75b2a5f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryUsagePollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"},{"line_number":30,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":31,"context_line":"            try:"},{"line_number":32,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage(instance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2FCfs%3D","line":29,"in_reply_to":"AAAAVn%2F%2FCsI%3D","updated":"2014-03-10 14:20:06.000000000","message":"ah i see, my understanding is that each level is a superset of previous level so if you enable INFO level, you will get ERROR, WARN level logs as well, if you enable DEBUG, you will get INFO, ERROR, WARN level logs...\n\nfor me, i\u0027d actually keep the first LOG as INFO level as it\u0027s just a status log (i might actually remove it completely)... the second LOG i\u0027d switch to DEBUG since its quite detailed for general logging... and the instancenotfoundexception, i\u0027d probably put as WARN... that\u0027s how i\u0027d rank them personally but i guess that\u0027s a matter preference.\n\nbut like you said, it\u0027d be good to revisit what level we LOG at so we log things at correct/expected levels not just in pollsters but everywhere.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"66ac2f67bb40c80769444d1610985ce63ac17b7b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryUsagePollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"},{"line_number":30,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":31,"context_line":"            try:"},{"line_number":32,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage(instance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2FCsI%3D","line":29,"in_reply_to":"AAAAVn%2F%2FDE8%3D","updated":"2014-03-10 13:52:06.000000000","message":"Gordon, my message was mostly about level for both \"checking instance\" and \"exception while checking instance\". IMHO it should be on one level to keep the logs consistent. DEBUG or INFO is not so important.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0f25f1b9461373e4b4f645ba4ffe758a68772619","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryUsagePollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"},{"line_number":30,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":31,"context_line":"            try:"},{"line_number":32,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage(instance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2FDE8%3D","line":29,"in_reply_to":"AAAAVn%2F%2FErY%3D","updated":"2014-03-10 12:44:46.000000000","message":"this would be a good topic for discussion... i actually don\u0027t mind this being INFO level... for me INFO is for short, generic logs that capture an action/event happened (like this)... i\u0027d expect DEBUG to capture a bit more info (which could help to debug).","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"4ccc503d9068c96aa99443c9b0b47cad4a6344ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class MemoryUsagePollster(plugin.ComputePollster):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":29,"context_line":"        for instance in resources:"},{"line_number":30,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":31,"context_line":"            try:"},{"line_number":32,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage(instance)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVn%2F%2FErY%3D","line":29,"in_reply_to":"AAAAVn%2F%2FIFA%3D","updated":"2014-03-10 07:47:38.000000000","message":"Corrected the log message and changed it to debug. The exception information might not be needed at the WARN level as for all exceptions. InstanceNotFoundException is a transient case where the instance was discovered while getting all instances, but got deleted just before querying samples for it. Similarly, NotImplementedError need not be a warning to the customer, only developers need be aware of it and can easily find out by checking the implementation.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f8cc617ea1c9351feb3c486bd8f5b39bcbe0560e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                LOG.debug(_(\u0027Obtaining Memory Usage is not implemented for %s\u0027"},{"line_number":49,"context_line":"                            ), manager.inspector.__class__.__name__)"},{"line_number":50,"context_line":"            except Exception as err:"},{"line_number":51,"context_line":"                LOG.error(_(\u0027Could not get Memory Usage for %(id)s: %(e)s\u0027), ("},{"line_number":52,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2B6sU%3D","line":51,"updated":"2014-03-11 10:10:05.000000000","message":"LOG.exception would be better I guess","commit_id":"82999b3886aabbdf140fc60ec5dec1f3ecfb93f2"}],"ceilometer/compute/virt/hyperv/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f2946c6533154fb599b994b1998a7e68a280739d","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            yield (disk, stats)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def inspect_memory(self, instance):"},{"line_number":88,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BsDU%3D","line":87,"updated":"2014-02-19 19:59:20.000000000","message":"this isn\u0027t necessary... base class would raise error","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"dded730d63da3266f8f65e44b9e344b6601cc3ac","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"            yield (disk, stats)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def inspect_memory(self, instance):"},{"line_number":88,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BmCU%3D","line":87,"in_reply_to":"AAAAUX%2F%2BsDU%3D","updated":"2014-02-20 10:01:49.000000000","message":"Done","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"}],"ceilometer/compute/virt/inspector.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f8cc617ea1c9351feb3c486bd8f5b39bcbe0560e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        raise NotImplementedError()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def inspect_memory_usage(self, instance):"},{"line_number":153,"context_line":"        \"\"\"Inspect the memory usage statistics for an instance."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        :param instance: the target instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2B6sA%3D","line":152,"updated":"2014-03-11 10:10:05.000000000","message":"@staticmethod","commit_id":"82999b3886aabbdf140fc60ec5dec1f3ecfb93f2"}],"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f2946c6533154fb599b994b1998a7e68a280739d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                                             errors\u003dblock_stats[4])"},{"line_number":169,"context_line":"            yield (disk, stats)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def inspect_memory(self, instance):"},{"line_number":172,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BsEc%3D","line":171,"updated":"2014-02-19 19:59:20.000000000","message":"this isn\u0027t necessary... base class would raise error","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"dded730d63da3266f8f65e44b9e344b6601cc3ac","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                                             errors\u003dblock_stats[4])"},{"line_number":169,"context_line":"            yield (disk, stats)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def inspect_memory(self, instance):"},{"line_number":172,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BmCM%3D","line":171,"in_reply_to":"AAAAUX%2F%2BsEc%3D","updated":"2014-02-20 10:01:49.000000000","message":"Done","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f2946c6533154fb599b994b1998a7e68a280739d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Br%2FY%3D","line":26,"updated":"2014-02-19 19:59:20.000000000","message":"never used","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"dded730d63da3266f8f65e44b9e344b6601cc3ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BmCE%3D","line":26,"in_reply_to":"AAAAUX%2F%2Br%2FY%3D","updated":"2014-02-20 10:01:49.000000000","message":"Removed.","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f2946c6533154fb599b994b1998a7e68a280739d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def __init__(self):"},{"line_number":46,"context_line":"        super(VsphereInspector, self).__init__()"},{"line_number":47,"context_line":"        hostIp \u003d cfg.CONF.vmware_host_ip"},{"line_number":48,"context_line":"        wsdl_loc \u003d \"https://\" + hostIp + \"/sdk/vimService.wsdl\""},{"line_number":49,"context_line":"        api_session \u003d api.VMwareAPISession("},{"line_number":50,"context_line":"            hostIp,"},{"line_number":51,"context_line":"            cfg.CONF.vmware_host_username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Br50%3D","line":48,"updated":"2014-02-19 19:59:20.000000000","message":"this hardcorded string is  strange. is this the only way to do this?","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"dded730d63da3266f8f65e44b9e344b6601cc3ac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def __init__(self):"},{"line_number":46,"context_line":"        super(VsphereInspector, self).__init__()"},{"line_number":47,"context_line":"        hostIp \u003d cfg.CONF.vmware_host_ip"},{"line_number":48,"context_line":"        wsdl_loc \u003d \"https://\" + hostIp + \"/sdk/vimService.wsdl\""},{"line_number":49,"context_line":"        api_session \u003d api.VMwareAPISession("},{"line_number":50,"context_line":"            hostIp,"},{"line_number":51,"context_line":"            cfg.CONF.vmware_host_username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BmB4%3D","line":48,"in_reply_to":"AAAAUX%2F%2Br50%3D","updated":"2014-02-20 10:01:49.000000000","message":"Used an existing common method available in vmware.vim","commit_id":"80ca37c6366d3caef6f41068e141eb22e38c110f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"OPTS \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":29,"context_line":"               help\u003d\u0027IP address of the VMware Vsphere host\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9NM%3D","line":27,"updated":"2014-02-23 15:17:53.000000000","message":"Can you do these in a vmware section? Not sure what the policy is in ceilometer.\nHaving it in a vmware section makes it a lot easier to maintain in the long run.","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"OPTS \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":29,"context_line":"               help\u003d\u0027IP address of the VMware Vsphere host\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4eQ%3D","line":27,"in_reply_to":"AAAAU3%2F%2F9NM%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def get_api_session():"},{"line_number":42,"context_line":"    hostIp \u003d cfg.CONF.vmware_host_ip"},{"line_number":43,"context_line":"    #\"https://\" + hostIp + \"/sdk/vimService.wsdl\""},{"line_number":44,"context_line":"    wsdl_loc \u003d vim.Vim._get_wsdl_loc(\"https\", hostIp)"},{"line_number":45,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":46,"context_line":"        hostIp,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9NA%3D","line":43,"updated":"2014-02-23 15:17:53.000000000","message":"please delete this comment","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def get_api_session():"},{"line_number":42,"context_line":"    hostIp \u003d cfg.CONF.vmware_host_ip"},{"line_number":43,"context_line":"    #\"https://\" + hostIp + \"/sdk/vimService.wsdl\""},{"line_number":44,"context_line":"    wsdl_loc \u003d vim.Vim._get_wsdl_loc(\"https\", hostIp)"},{"line_number":45,"context_line":"    api_session \u003d api.VMwareAPISession("},{"line_number":46,"context_line":"        hostIp,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4eI%3D","line":43,"in_reply_to":"AAAAU3%2F%2F9NA%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        hostIp,"},{"line_number":47,"context_line":"        cfg.CONF.vmware_host_username,"},{"line_number":48,"context_line":"        cfg.CONF.vmware_host_password,"},{"line_number":49,"context_line":"        0,"},{"line_number":50,"context_line":"        None,"},{"line_number":51,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":52,"context_line":"    return api_session"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9M8%3D","line":49,"updated":"2014-02-23 15:17:53.000000000","message":"i think that you should set api_retry_count - in nova this is 10\nyou should also set the task_poll_interval - this is 0.5","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        hostIp,"},{"line_number":47,"context_line":"        cfg.CONF.vmware_host_username,"},{"line_number":48,"context_line":"        cfg.CONF.vmware_host_password,"},{"line_number":49,"context_line":"        0,"},{"line_number":50,"context_line":"        None,"},{"line_number":51,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":52,"context_line":"    return api_session"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4eE%3D","line":49,"in_reply_to":"AAAAU3%2F%2F9M8%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            mem_counter_id,"},{"line_number":84,"context_line":"            True)"},{"line_number":85,"context_line":"        #Stat provided from VMware Vsphere is in Bytes, converting it to MB."},{"line_number":86,"context_line":"        memory \u003d memory / (1024.0 * 1024.0)"},{"line_number":87,"context_line":"        return virt_inspector.MemoryStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9M4%3D","line":86,"updated":"2014-02-23 15:17:53.000000000","message":"in the oslo project there is https://github.com/openstack/oslo-incubator/blob/master/openstack/common/units.py#L22\nhopefully this file in in ceilometer. if so then please use Mi","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            mem_counter_id,"},{"line_number":84,"context_line":"            True)"},{"line_number":85,"context_line":"        #Stat provided from VMware Vsphere is in Bytes, converting it to MB."},{"line_number":86,"context_line":"        memory \u003d memory / (1024.0 * 1024.0)"},{"line_number":87,"context_line":"        return virt_inspector.MemoryStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4dc%3D","line":86,"in_reply_to":"AAAAU3%2F%2F9M4%3D","updated":"2014-02-24 10:26:22.000000000","message":"This file does not seem to be present in ceilometer. Changed the constant to \u00271024.0 ** 2\u0027 for now.","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b7a8451123bbe8b86c516aaf5860b5589f575c67","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        hostIp,"},{"line_number":49,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":50,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":51,"context_line":"        10,"},{"line_number":52,"context_line":"        0.5,"},{"line_number":53,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":54,"context_line":"    return api_session"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2F3kg%3D","line":51,"updated":"2014-02-24 12:00:15.000000000","message":"it may be worthwhile adding these parameters - line 50 and 51 as configuration variables.","commit_id":"c987fa3153d4e637058e5635f15ee8cd9ef64cc0"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"5dfb33ddf8161337d2cf9aec55bdab377f29d8eb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        hostIp,"},{"line_number":49,"context_line":"        cfg.CONF.vmware.host_username,"},{"line_number":50,"context_line":"        cfg.CONF.vmware.host_password,"},{"line_number":51,"context_line":"        10,"},{"line_number":52,"context_line":"        0.5,"},{"line_number":53,"context_line":"        wsdl_loc\u003dwsdl_loc)"},{"line_number":54,"context_line":"    return api_session"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2F3YM%3D","line":51,"in_reply_to":"AAAAU3%2F%2F3kg%3D","updated":"2014-02-25 04:02:39.000000000","message":"Done","commit_id":"c987fa3153d4e637058e5635f15ee8cd9ef64cc0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"97bbdd026a203fc28483b91c41b17b75f109f7ad","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            mem_counter_id,"},{"line_number":93,"context_line":"            True)"},{"line_number":94,"context_line":"        #Stat provided from VMware Vsphere is in Bytes, converting it to MB."},{"line_number":95,"context_line":"        memory \u003d memory / (1024.0 ** 2)"},{"line_number":96,"context_line":"        return virt_inspector.MemoryStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVX%2F%2F4eo%3D","line":95,"updated":"2014-02-27 16:05:44.000000000","message":"use /ceilometer/openstack/common/units.py to for 1024","commit_id":"cbf749a0a946d79ea5c47e62cf68b958240da674"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"3f4e7f1f3a1f13189d3ef7e97d809c6d10a50ac3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            mem_counter_id,"},{"line_number":93,"context_line":"            True)"},{"line_number":94,"context_line":"        #Stat provided from VMware Vsphere is in Bytes, converting it to MB."},{"line_number":95,"context_line":"        memory \u003d memory / (1024.0 ** 2)"},{"line_number":96,"context_line":"        return virt_inspector.MemoryStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVX%2F%2Fx04%3D","line":95,"in_reply_to":"AAAAVX%2F%2F4eo%3D","updated":"2014-02-28 10:42:30.000000000","message":"Done","commit_id":"cbf749a0a946d79ea5c47e62cf68b958240da674"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f8cc617ea1c9351feb3c486bd8f5b39bcbe0560e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._ops \u003d vsphere_operations.VsphereOperations("},{"line_number":73,"context_line":"            get_api_session(), 1000)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def inspect_instances(self):"},{"line_number":76,"context_line":"        raise NotImplementedError()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def inspect_cpus(self, instance_name):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAVn%2F%2B6sI%3D","line":75,"updated":"2014-03-11 10:10:05.000000000","message":"All of those should be @staticmethod\n\nAlso I guess having this NotImplemented by default in the Inspector class would be better but well.","commit_id":"82999b3886aabbdf140fc60ec5dec1f3ecfb93f2"}],"ceilometer/tests/compute/pollsters/test_memory.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"126a505ca2c9d82d4ecad46bcfc3cad1cc568873","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            self.assertEqual(len(samples), 1)"},{"line_number":49,"context_line":"            self.assertEqual(set([s.name for s in samples]),"},{"line_number":50,"context_line":"                             set([\u0027memory\u0027]))"},{"line_number":51,"context_line":"            self.assertEqual(samples[0].volume, expected_memory_mb)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        _verify_memory_metering(1.0)"},{"line_number":54,"context_line":"        _verify_memory_metering(2.0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F%2F1A%3D","line":51,"updated":"2014-03-02 18:59:20.000000000","message":"According to bug #1277104, the order here should be (expected_memory_mb, samples[0].volume)","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"7feb3e2d448021704d138f9826a6f38aa3ef806c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            self.assertEqual(len(samples), 1)"},{"line_number":49,"context_line":"            self.assertEqual(set([s.name for s in samples]),"},{"line_number":50,"context_line":"                             set([\u0027memory\u0027]))"},{"line_number":51,"context_line":"            self.assertEqual(samples[0].volume, expected_memory_mb)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        _verify_memory_metering(1.0)"},{"line_number":54,"context_line":"        _verify_memory_metering(2.0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FyFQ%3D","line":51,"in_reply_to":"AAAAVn%2F%2F%2F1A%3D","updated":"2014-03-04 05:48:00.000000000","message":"Done","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"}],"ceilometer/tests/compute/virt/vmware/test_inspector.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"640e8d3401bb23b5a89809b01961bf2adf3355aa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ceilometer.compute.virt.vmware import api"},{"line_number":21,"context_line":"from ceilometer.compute.virt.vmware import inspector as vsphere_inspector"},{"line_number":22,"context_line":"from ceilometer.openstack.common import test"},{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestVsphereInspection(test.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F9M0%3D","line":23,"updated":"2014-02-23 15:17:53.000000000","message":"mock is a third party import so it should be in its own section above","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"62f3bf5b7e496314d770bab3d0a009a0220ee1c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ceilometer.compute.virt.vmware import api"},{"line_number":21,"context_line":"from ceilometer.compute.virt.vmware import inspector as vsphere_inspector"},{"line_number":22,"context_line":"from ceilometer.openstack.common import test"},{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestVsphereInspection(test.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAU3%2F%2F4es%3D","line":23,"in_reply_to":"AAAAU3%2F%2F9M0%3D","updated":"2014-02-24 10:26:22.000000000","message":"Done","commit_id":"8d3944c66ca2b6d3ed15bba290c97bdd6b382c4e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"126a505ca2c9d82d4ecad46bcfc3cad1cc568873","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self._inspector._ops.query_vm_current_stat_value.return_value \u003d \\"},{"line_number":59,"context_line":"            fake_memory_value"},{"line_number":60,"context_line":"        memory_stats \u003d self._inspector.inspect_memory(fake_instance)"},{"line_number":61,"context_line":"        self.assertEqual(memory_stats, fake_stat)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2F%2F10%3D","line":61,"updated":"2014-03-02 18:59:20.000000000","message":"According to bug #1277104, the order here should be (fake_stat, memory_stats).","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"7feb3e2d448021704d138f9826a6f38aa3ef806c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self._inspector._ops.query_vm_current_stat_value.return_value \u003d \\"},{"line_number":59,"context_line":"            fake_memory_value"},{"line_number":60,"context_line":"        memory_stats \u003d self._inspector.inspect_memory(fake_instance)"},{"line_number":61,"context_line":"        self.assertEqual(memory_stats, fake_stat)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FyFI%3D","line":61,"in_reply_to":"AAAAVn%2F%2F%2F10%3D","updated":"2014-03-04 05:48:00.000000000","message":"Done","commit_id":"2d54ab258fff02ba1a1b7803c668d6d2b38a58be"}],"doc/source/measurements.rst":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"8e4b89319814e362409e92f4e8a38021aa4da1dd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                           Type        Unit       Resource  Origin        Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAVn%2F%2FIE0%3D","line":72,"updated":"2014-03-08 19:14:31.000000000","message":"Maybe we may add somewhere in docs that this metric is implemented only for vmWare?","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"02d4bb4fe00301aa6929a47d4c4f96584d59f0b9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                           Type        Unit       Resource  Origin        Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAVn%2F%2FCSE%3D","line":72,"in_reply_to":"AAAAVn%2F%2FCrE%3D","updated":"2014-03-10 14:39:23.000000000","message":"It was mentioned in the comments for patch set 11, that it would be good to have doc for the hypervisor capabilities as different counters are supported in case of the different vendors. I agree that it is ok to have it in a separate patch.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"b6f1325e07ca5919e65009ac6180dcda8f212a90","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                           Type        Unit       Resource  Origin        Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAVn%2F%2FCrE%3D","line":72,"in_reply_to":"AAAAVn%2F%2FEo8%3D","updated":"2014-03-10 13:54:37.000000000","message":"Yep, I agree. I didn\u0027t see docs update in your next patches so will wait for docs patch as a separate one :)","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"4ccc503d9068c96aa99443c9b0b47cad4a6344ca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                           Type        Unit       Resource  Origin        Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAVn%2F%2FEo8%3D","line":72,"in_reply_to":"AAAAVn%2F%2FIE0%3D","updated":"2014-03-10 07:47:38.000000000","message":"We can take this up as a separate documentation task providing information about  hypervisors and corresponding meters they support.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"26942e39310d076933af3046a37e2e59cabf35eb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"},{"line_number":76,"context_line":"cpu_util                       Gauge       %          inst ID   pollster      Average CPU utilisation"},{"line_number":77,"context_line":"vcpus                          Gauge       vcpu       inst ID   notification  Number of VCPUs"}],"source_content_type":"text/x-rst","patch_set":14,"id":"AAAAVn%2F%2B9Ko%3D","line":74,"updated":"2014-03-11 02:46:23.000000000","message":"Should we add a note here to indicate that this is only supported in vmsphere?","commit_id":"82999b3886aabbdf140fc60ec5dec1f3ecfb93f2"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"60d047751a5f0b3b464038c62069eae2c2968867","unresolved":false,"context_lines":[{"line_number":71,"context_line":"instance                       Gauge       instance   inst ID   both          Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                Gauge       instance   inst ID   both          Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                         Gauge       MB         inst ID   notification  Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                   Gauge       MB         inst ID   pollster      Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                            Cumulative  ns         inst ID   pollster      CPU time used"},{"line_number":76,"context_line":"cpu_util                       Gauge       %          inst ID   pollster      Average CPU utilisation"},{"line_number":77,"context_line":"vcpus                          Gauge       vcpu       inst ID   notification  Number of VCPUs"}],"source_content_type":"text/x-rst","patch_set":14,"id":"AAAAVn%2F%2B7hE%3D","line":74,"in_reply_to":"AAAAVn%2F%2B9Ko%3D","updated":"2014-03-11 07:59:40.000000000","message":"Yes, have discussed this in patchset 13 with Nadya and Ildiko. Will take up a separate documentation task to provide information about which meter is supported by which hypervisor.","commit_id":"82999b3886aabbdf140fc60ec5dec1f3ecfb93f2"}],"etc/ceilometer/ceilometer.conf.sample":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"8e4b89319814e362409e92f4e8a38021aa4da1dd","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"#api_retry_count\u003d10"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"# Sleep time in seconds for polling an ongoing async task"},{"line_number":1005,"context_line":"# (floating point value)"},{"line_number":1006,"context_line":"#task_poll_interval\u003d0.5"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAAVn%2F%2FIIs%3D","line":1005,"updated":"2014-03-08 19:14:31.000000000","message":"Am I right that this poll_interval has nothing common with interval from pipeline.conf? This interval is used inside oslo.vmware for async retrieving information?","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"e40fc2404a5a4d842586528e34432d255b095404","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"#api_retry_count\u003d10"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"# Sleep time in seconds for polling an ongoing async task"},{"line_number":1005,"context_line":"# (floating point value)"},{"line_number":1006,"context_line":"#task_poll_interval\u003d0.5"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAAVn%2F%2FHLw%3D","line":1005,"in_reply_to":"AAAAVn%2F%2FIIs%3D","updated":"2014-03-09 11:30:30.000000000","message":"Yes, you are right.\nIt is the sleep time in seconds for polling an                                 on-going async task as part of the API call.","commit_id":"52e2352f9b3909175a12d150525d0ae02806d6d2"}]}