)]}'
{"ceilometer/gnocchi_client.py":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"66524466cbf2da628c4c16effbb0263a74fae253","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            gnocchi.resource_type.get(name\u003dname)"},{"line_number":267,"context_line":"        except (gnocchi_exc.ResourceTypeNotFound, gnocchi_exc.NotFound):"},{"line_number":268,"context_line":"            rt \u003d {\u0027name\u0027: name, \u0027attributes\u0027: attributes}"},{"line_number":269,"context_line":"            gnocchi.resource_type.create(resource_type\u003drt)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    for ops in resources_update_operations:"},{"line_number":272,"context_line":"        if ops[\u0027type\u0027] \u003d\u003d \u0027update_attribute_type\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_263c032e","line":269,"range":{"start_line":268,"start_character":12,"end_line":269,"end_character":58},"updated":"2020-08-20 17:40:29.000000000","message":"Can you add a log here when this except code is executed? Then, we know if somehow some other error is captured here and triggers a resource type creation.","commit_id":"be8edb074970117265cc44effb11996b30c9f20a"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f6ad439f35f224bfb290e05d36b28b07c62bbef7","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            gnocchi.resource_type.get(name\u003dname)"},{"line_number":267,"context_line":"        except (gnocchi_exc.ResourceTypeNotFound, gnocchi_exc.NotFound):"},{"line_number":268,"context_line":"            rt \u003d {\u0027name\u0027: name, \u0027attributes\u0027: attributes}"},{"line_number":269,"context_line":"            gnocchi.resource_type.create(resource_type\u003drt)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    for ops in resources_update_operations:"},{"line_number":272,"context_line":"        if ops[\u0027type\u0027] \u003d\u003d \u0027update_attribute_type\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_df37c6af","line":269,"range":{"start_line":268,"start_character":12,"end_line":269,"end_character":58},"in_reply_to":"9f560f44_263c032e","updated":"2020-08-20 20:03:56.000000000","message":"this is a cherry-pick. We should have that log message added first in master, and then backported.","commit_id":"be8edb074970117265cc44effb11996b30c9f20a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"67d30be3972c90e554ebe31ddb607155cc8d56f8","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            gnocchi.resource_type.get(name\u003dname)"},{"line_number":267,"context_line":"        except (gnocchi_exc.ResourceTypeNotFound, gnocchi_exc.NotFound):"},{"line_number":268,"context_line":"            rt \u003d {\u0027name\u0027: name, \u0027attributes\u0027: attributes}"},{"line_number":269,"context_line":"            gnocchi.resource_type.create(resource_type\u003drt)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    for ops in resources_update_operations:"},{"line_number":272,"context_line":"        if ops[\u0027type\u0027] \u003d\u003d \u0027update_attribute_type\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bf0ad2ce","line":269,"range":{"start_line":268,"start_character":12,"end_line":269,"end_character":58},"in_reply_to":"9f560f44_df37c6af","updated":"2020-08-20 20:07:31.000000000","message":"I see. I was too slow to review the patch for master. However, we must try to make the system more operator friendly. Otherwise, troubleshooting becomes a mess, requiring people to change code in run-time to understand what is going on with the processing.\n\nHaving said that, if this is just a cherry-pick. I think that it is fine the way it is now.","commit_id":"be8edb074970117265cc44effb11996b30c9f20a"}]}