)]}'
{"ceilometer/compute/notifications/instance.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e1e0bb3d185e49cede6356214421a3414f2bde11","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            name\u003d\u0027flavor\u0027,"},{"line_number":171,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":172,"context_line":"            unit\u003d\u0027flavor.id\u0027,"},{"line_number":173,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027instance_flavor_id\u0027],"},{"line_number":174,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":175,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":176,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027instance_id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2F%2FJY%3D","line":173,"updated":"2014-04-09 02:21:46.000000000","message":"I think message[\u0027payload\u0027][\u0027instance_flavor_id\u0027] is also a unicode string, which doesn\u0027t fit the float type definition of volume in sqlalchemy.","commit_id":"97b9c0550064461db23e90a6a32411631eaff3be"}],"ceilometer/compute/pollsters/flavor.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3eb8301855e6d87af9641b8b9872461749c18272","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FlavorPollster(plugin.ComputePollster):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        yield util.make_sample_from_instance("},{"line_number":29,"context_line":"            instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FgQI%3D","line":26,"updated":"2014-03-05 18:13:14.000000000","message":"As Ildiko noticed it needs to be rebased (because of: https://review.openstack.org/#/c/75006/11), here is a sample: https://review.openstack.org/#/c/75006/11/ceilometer/compute/pollsters/instance.py","commit_id":"0402c677991e7178239100ec3698ce05f1208504"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"f5b749425650d121502b40c09f412df8ee46edf1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":32,"context_line":"                unit\u003d\u0027flavor.id\u0027,"},{"line_number":33,"context_line":"                volume\u003dinstance.flavor[\u0027id\u0027],"},{"line_number":34,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2B7zQ%3D","line":34,"updated":"2014-03-11 07:25:13.000000000","message":"why add a new module here? we already have InstanceFlavorPollster in instance\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/compute/pollsters/instance.py#L40","commit_id":"2f058c883471191438f1a565327ba3256f610519"}],"ceilometer/compute/pollsters/instance.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"432078b3e9f99f597a0182f5813a3d972dde3183","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class InstanceFlavorIDPollster(plugin.ComputePollster):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":59,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2F%2Bn8%3D","line":56,"updated":"2014-03-12 15:31:13.000000000","message":"Why did you prefer to make this method non-static?","commit_id":"13ca72687cea7140c397bfd63c65af79d597379d"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"ae1f6d1a1cd10a4d3e3b5b1f8fc88680cc009f5e","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class InstanceFlavorIDPollster(plugin.ComputePollster):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @staticmethod"},{"line_number":59,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":60,"context_line":"        for instance in resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2Fmos%3D","line":57,"updated":"2014-03-15 08:15:29.000000000","message":"you may remove \u0027self\u0027 because it\u0027s not needed in static methods","commit_id":"0e6511d2a25431043aaa8881b50d2d69a8bf5170"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e1e0bb3d185e49cede6356214421a3414f2bde11","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                name\u003d\u0027flavor\u0027,"},{"line_number":64,"context_line":"                type\u003dsample.TYPE_GAUGE,"},{"line_number":65,"context_line":"                unit\u003d\u0027flavor.id\u0027,"},{"line_number":66,"context_line":"                volume\u003dinstance.flavor[\u0027id\u0027],"},{"line_number":67,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2F%2FLI%3D","line":66,"updated":"2014-04-09 02:21:46.000000000","message":"I think instance.flavor[\u0027id\u0027] is of type unicode, which doesn\u0027t fit the sqlalchemy model\u0027s definition of volume type - float","commit_id":"97b9c0550064461db23e90a6a32411631eaff3be"}],"ceilometer/tests/compute/notifications/test_instance.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"432078b3e9f99f597a0182f5813a3d972dde3183","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def test_instance_create_flavor_id(self):"},{"line_number":603,"context_line":"        ic \u003d instance.InstanceFlavorID()"},{"line_number":604,"context_line":"        counters \u003d list(ic.process_notification(INSTANCE_CREATE_END))"},{"line_number":605,"context_line":"        self.assertEqual(len(counters), 1)"},{"line_number":606,"context_line":"        c \u003d counters[0]"},{"line_number":607,"context_line":"        self.assertEqual(c.volume, 2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2F%2Bs0%3D","line":604,"updated":"2014-03-12 15:31:13.000000000","message":"Please change an order to (expected, actual)","commit_id":"13ca72687cea7140c397bfd63c65af79d597379d"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"432078b3e9f99f597a0182f5813a3d972dde3183","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def test_instance_finish_resize_flavor_id(self):"},{"line_number":676,"context_line":"        ic \u003d instance.InstanceFlavorID()"},{"line_number":677,"context_line":"        counters \u003d list(ic.process_notification(INSTANCE_FINISH_RESIZE_END))"},{"line_number":678,"context_line":"        self.assertEqual(len(counters), 1)"},{"line_number":679,"context_line":"        c \u003d counters[0]"},{"line_number":680,"context_line":"        self.assertEqual(c.volume, 5)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2F%2Bsg%3D","line":677,"updated":"2014-03-12 15:31:13.000000000","message":"ditto","commit_id":"13ca72687cea7140c397bfd63c65af79d597379d"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"432078b3e9f99f597a0182f5813a3d972dde3183","unresolved":false,"context_lines":[{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_instance_resize_finish_flavor_id(self):"},{"line_number":718,"context_line":"        ic \u003d instance.InstanceFlavorID()"},{"line_number":719,"context_line":"        counters \u003d list(ic.process_notification(INSTANCE_RESIZE_REVERT_END))"},{"line_number":720,"context_line":"        self.assertEqual(len(counters), 1)"},{"line_number":721,"context_line":"        c \u003d counters[0]"},{"line_number":722,"context_line":"        self.assertEqual(c.volume, 2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2F%2BsU%3D","line":719,"updated":"2014-03-12 15:31:13.000000000","message":"ditto","commit_id":"13ca72687cea7140c397bfd63c65af79d597379d"}],"ceilometer/tests/compute/pollsters/test_flavor.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3eb8301855e6d87af9641b8b9872461749c18272","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_samples_flavor_id(self):"},{"line_number":33,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":34,"context_line":"        pollster \u003d flavor.FlavorPollster()"},{"line_number":35,"context_line":"        samples \u003d list(pollster.get_samples(mgr, {}, self.instance))"},{"line_number":36,"context_line":"        self.assertEqual(len(samples), 1)"},{"line_number":37,"context_line":"        self.assertEqual(samples[0].name, \u0027flavor\u0027)"},{"line_number":38,"context_line":"        self.assertEqual(samples[0].volume, 2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FgPg%3D","line":35,"updated":"2014-03-05 18:13:14.000000000","message":"As Ildiko notices it needs to be rebased (because of https://review.openstack.org/#/c/75006/11), here is a sample: https://review.openstack.org/#/c/75006/11/ceilometer/tests/compute/pollsters/test_instance.py","commit_id":"0402c677991e7178239100ec3698ce05f1208504"}],"ceilometer/tests/compute/pollsters/test_instance.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"432078b3e9f99f597a0182f5813a3d972dde3183","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def test_get_samples_flavor_id(self):"},{"line_number":56,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":57,"context_line":"        pollster \u003d pollsters_instance.InstanceFlavorIDPollster()"},{"line_number":58,"context_line":"        samples \u003d list(pollster.get_samples(mgr, {}, [self.instance]))"},{"line_number":59,"context_line":"        self.assertEqual(len(samples), 1)"},{"line_number":60,"context_line":"        self.assertEqual(samples[0].name, \u0027flavor\u0027)"},{"line_number":61,"context_line":"        self.assertEqual(samples[0].volume, 2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2F%2BtE%3D","line":58,"updated":"2014-03-12 15:31:13.000000000","message":"Please change an order to (expected, actual). The separate patch will do it for all other tests.","commit_id":"13ca72687cea7140c397bfd63c65af79d597379d"}]}