)]}'
{"ceilometer/compute/pollsters/cpu.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89991e9ec63e52234e03012da2d18becc40452ab","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        except Exception as err:"},{"line_number":77,"context_line":"            LOG.error(_(\u0027could not get CPU Util for %(id)s: %(e)s\u0027), ("},{"line_number":78,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"},{"line_number":79,"context_line":"            LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F4dE%3D","line":79,"updated":"2014-02-27 16:08:03.000000000","message":"drop log exception","commit_id":"8752493081848e3a2febd89c13f88c7ba7add598"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"4fead6dfa5db8e50d8aa82cbbb8bc934deeee391","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        except Exception as err:"},{"line_number":77,"context_line":"            LOG.error(_(\u0027could not get CPU Util for %(id)s: %(e)s\u0027), ("},{"line_number":78,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"},{"line_number":79,"context_line":"            LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FxzA%3D","line":79,"in_reply_to":"AAAAVX%2F%2F4dE%3D","updated":"2014-02-28 10:45:49.000000000","message":"Done","commit_id":"8752493081848e3a2febd89c13f88c7ba7add598"},{"author":{"_account_id":8155,"name":"Rajdeep","email":"dua_rajdeep@yahoo.com","username":"rajdeepd"},"change_message_id":"acff74cc389ab4b22ada3fa8e17530e60cd588c5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            )"},{"line_number":73,"context_line":"        except virt_inspector.InstanceNotFoundException as err:"},{"line_number":74,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":75,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":76,"context_line":"        except Exception as err:"},{"line_number":77,"context_line":"            LOG.error(_(\u0027could not get CPU Util for %(id)s: %(e)s\u0027), ("},{"line_number":78,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F8rs%3D","line":75,"updated":"2014-03-03 09:17:55.000000000","message":"shouldn\u0027t this be Log.error?","commit_id":"54e9053a75c53817f9b7238e26a1bea328038478"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"f581d77d4ab6686d68804be9a03f8da0089471a8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            )"},{"line_number":73,"context_line":"        except virt_inspector.InstanceNotFoundException as err:"},{"line_number":74,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":75,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":76,"context_line":"        except Exception as err:"},{"line_number":77,"context_line":"            LOG.error(_(\u0027could not get CPU Util for %(id)s: %(e)s\u0027), ("},{"line_number":78,"context_line":"                      {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuF8%3D","line":75,"in_reply_to":"AAAAVn%2F%2F8rs%3D","updated":"2014-03-04 14:09:15.000000000","message":"No, for a deleted instance, the exception needs to be ignored and is logged only for debugging purposes. This is true for existing pollsters as well.","commit_id":"54e9053a75c53817f9b7238e26a1bea328038478"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"805d65c14fa714b3f5967fd3a73d8f7c2e888ee3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":52,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":53,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":54,"context_line":"            except Exception as err:"},{"line_number":55,"context_line":"                LOG.error(_(\u0027could not get CPU time for %(id)s: %(e)s\u0027) % ("},{"line_number":56,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"},{"line_number":57,"context_line":"                LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FWqI%3D","line":54,"updated":"2014-03-06 17:11:43.000000000","message":"catch notimplemented as well","commit_id":"b8bcce505d47854c4060267d4800c51f30b1fcab"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"805d65c14fa714b3f5967fd3a73d8f7c2e888ee3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":78,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":79,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":80,"context_line":"            except Exception as err:"},{"line_number":81,"context_line":"                LOG.error(_(\u0027Could not get CPU Util for %(id)s: %(e)s\u0027), ("},{"line_number":82,"context_line":"                          {\u0027id\u0027: instance.id, \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FWqY%3D","line":80,"updated":"2014-03-06 17:11:43.000000000","message":"catch notimplemented as well","commit_id":"b8bcce505d47854c4060267d4800c51f30b1fcab"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"d80da6f3316c0d7c0ba144384444a24da4d49fc7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"class CPUUtilPollster(plugin.ComputePollster):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":67,"context_line":"        for instance in resources:"},{"line_number":68,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                cpu_info \u003d manager.inspector.inspect_cpu_util(instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FIDM%3D","line":67,"updated":"2014-03-08 19:30:46.000000000","message":"The same thoughts about logging. Will wait for your comments in memory patch","commit_id":"50cfe73e9cb24f0bd4569eb80f049ea10bfa2d4b"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"39ebd8cb31b56f8ac8d51e1d0bab8f1d1c6a8d1f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"class CPUUtilPollster(plugin.ComputePollster):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":67,"context_line":"        for instance in resources:"},{"line_number":68,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                cpu_info \u003d manager.inspector.inspect_cpu_util(instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FEJQ%3D","line":67,"in_reply_to":"AAAAVn%2F%2FIDM%3D","updated":"2014-03-10 09:23:35.000000000","message":"Done","commit_id":"50cfe73e9cb24f0bd4569eb80f049ea10bfa2d4b"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"d80da6f3316c0d7c0ba144384444a24da4d49fc7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        for instance in resources:"},{"line_number":68,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                cpu_info \u003d manager.inspector.inspect_cpu_util(instance)"},{"line_number":71,"context_line":"                LOG.info(_(\"CPU UTIL: %(instance)s %(util)d\"), ("},{"line_number":72,"context_line":"                         {\u0027instance\u0027: instance.__dict__,"},{"line_number":73,"context_line":"                          \u0027util\u0027: cpu_info.util}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FIC0%3D","line":70,"updated":"2014-03-08 19:30:46.000000000","message":"This should go to debug level I guess. We should not write all pollster\u0027s output to info","commit_id":"50cfe73e9cb24f0bd4569eb80f049ea10bfa2d4b"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"39ebd8cb31b56f8ac8d51e1d0bab8f1d1c6a8d1f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        for instance in resources:"},{"line_number":68,"context_line":"            LOG.info(_(\u0027Checking instance %s\u0027), instance.id)"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                cpu_info \u003d manager.inspector.inspect_cpu_util(instance)"},{"line_number":71,"context_line":"                LOG.info(_(\"CPU UTIL: %(instance)s %(util)d\"), ("},{"line_number":72,"context_line":"                         {\u0027instance\u0027: instance.__dict__,"},{"line_number":73,"context_line":"                          \u0027util\u0027: cpu_info.util}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FEJM%3D","line":70,"in_reply_to":"AAAAVn%2F%2FIC0%3D","updated":"2014-03-10 09:23:35.000000000","message":"Done","commit_id":"50cfe73e9cb24f0bd4569eb80f049ea10bfa2d4b"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":8155,"name":"Rajdeep","email":"dua_rajdeep@yahoo.com","username":"rajdeepd"},"change_message_id":"acff74cc389ab4b22ada3fa8e17530e60cd588c5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def inspect_cpus(self, instance_name):"},{"line_number":77,"context_line":"        raise NotImplementedError()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def inspect_cpu_util(self, instance):"},{"line_number":80,"context_line":"        vm_moid \u003d self._ops.get_vm_moid(instance.id)"},{"line_number":81,"context_line":"        if vm_moid is None:"},{"line_number":82,"context_line":"            raise virt_inspector.InstanceNotFoundException("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F8Zs%3D","line":79,"updated":"2014-03-03 09:17:55.000000000","message":"We could use the previous method and pass instance_id or instance_name","commit_id":"54e9053a75c53817f9b7238e26a1bea328038478"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"f581d77d4ab6686d68804be9a03f8da0089471a8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def inspect_cpus(self, instance_name):"},{"line_number":77,"context_line":"        raise NotImplementedError()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def inspect_cpu_util(self, instance):"},{"line_number":80,"context_line":"        vm_moid \u003d self._ops.get_vm_moid(instance.id)"},{"line_number":81,"context_line":"        if vm_moid is None:"},{"line_number":82,"context_line":"            raise virt_inspector.InstanceNotFoundException("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuFQ%3D","line":79,"in_reply_to":"AAAAVn%2F%2F8Zs%3D","updated":"2014-03-04 14:09:15.000000000","message":"No, inspect_cpus() is an existing method in all the inspectors providing CPUStats, which returns the number of CPUs and cumulative CPU time. inspect_cpus_utils() is a new method to return the percentage of CPU utilization. Both the methods are for completely different and independent CPU counters.","commit_id":"54e9053a75c53817f9b7238e26a1bea328038478"}]}