)]}'
{"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1c1c447b1e2cba45b2d2390776dbb72aed5b4592","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            )"},{"line_number":178,"context_line":"        return i_cache[instance.id]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":181,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def get_samples(self, manager, cache, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2F1rQ%3D","line":180,"updated":"2014-02-27 22:52:23.000000000","message":"add @abc.abstractmethod decorator","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"ba758057b8c48f011206fd6a52d063754207a1b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            )"},{"line_number":178,"context_line":"        return i_cache[instance.id]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":181,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def get_samples(self, manager, cache, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2FxhM%3D","line":180,"in_reply_to":"AAAAVX%2F%2F1rQ%3D","updated":"2014-02-28 13:07:37.000000000","message":"Done","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1c1c447b1e2cba45b2d2390776dbb72aed5b4592","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":194,"context_line":"        except Exception as err:"},{"line_number":195,"context_line":"            instance_name \u003d util.instance_name(instance)"},{"line_number":196,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":197,"context_line":"                        {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":198,"context_line":"            LOG.exception(err)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2F1rs%3D","line":196,"updated":"2014-02-27 22:52:23.000000000","message":"make this an LOG.error and drop LOG.exception","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"ba758057b8c48f011206fd6a52d063754207a1b6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":194,"context_line":"        except Exception as err:"},{"line_number":195,"context_line":"            instance_name \u003d util.instance_name(instance)"},{"line_number":196,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":197,"context_line":"                        {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":198,"context_line":"            LOG.exception(err)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2FxhI%3D","line":196,"in_reply_to":"AAAAVX%2F%2F1rs%3D","updated":"2014-02-28 13:07:37.000000000","message":"Done","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e3293d352e0afa3be45ca35c511738e968a56327","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":182,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            disk_rates_info \u003d self._populate_cache("},{"line_number":187,"context_line":"                manager.inspector,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F55Q%3D","line":184,"updated":"2014-03-03 15:25:40.000000000","message":"Needs rebase, here is a sample: https://review.openstack.org/#/c/75006/11/ceilometer/compute/pollsters/disk.py","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"c4c87daff546c2e64077ae49f316f41d24909d54","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":182,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def get_samples(self, manager, cache, instance):"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            disk_rates_info \u003d self._populate_cache("},{"line_number":187,"context_line":"                manager.inspector,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2Ftb4%3D","line":184,"in_reply_to":"AAAAVn%2F%2F55Q%3D","updated":"2014-03-04 15:34:48.000000000","message":"Done","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"66ea082a421080fb27fc68455bf8a5df01c05849","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                yield self._get_sample(instance, c_data)"},{"line_number":95,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":96,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":97,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":98,"context_line":"            except Exception as err:"},{"line_number":99,"context_line":"                LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":100,"context_line":"                            {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FWmM%3D","line":97,"updated":"2014-03-06 17:15:18.000000000","message":"catch notimplemented as well and log debug or just pass it.","commit_id":"2fe6dae46a0dce904793e1272c4151649bd96724"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"c86d05ba97e23fc70d4d35d406e3ace5dca6b6e4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                yield self._get_sample(instance, c_data)"},{"line_number":95,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":96,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":97,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":98,"context_line":"            except Exception as err:"},{"line_number":99,"context_line":"                LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":100,"context_line":"                            {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FOmI%3D","line":97,"in_reply_to":"AAAAVn%2F%2FWmM%3D","updated":"2014-03-07 13:30:26.000000000","message":"Done","commit_id":"2fe6dae46a0dce904793e1272c4151649bd96724"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"66ea082a421080fb27fc68455bf8a5df01c05849","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":195,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":196,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":197,"context_line":"            except Exception as err:"},{"line_number":198,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":199,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":200,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FWnM%3D","line":197,"updated":"2014-03-06 17:15:18.000000000","message":"catch notimplemented as well","commit_id":"2fe6dae46a0dce904793e1272c4151649bd96724"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"c86d05ba97e23fc70d4d35d406e3ace5dca6b6e4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":195,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":196,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":197,"context_line":"            except Exception as err:"},{"line_number":198,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":199,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":200,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2FOmE%3D","line":197,"in_reply_to":"AAAAVn%2F%2FWnM%3D","updated":"2014-03-07 13:30:26.000000000","message":"Done","commit_id":"2fe6dae46a0dce904793e1272c4151649bd96724"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"041cdfc260174fd25160aac1a89bc77d694a03ab","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        query_disk_stats(VC_DISK_READ_RATE_CNTR)"},{"line_number":168,"context_line":"        query_disk_stats(VC_DISK_READ_REQUESTS_RATE_CNTR)"},{"line_number":169,"context_line":"        query_disk_stats(VC_DISK_WRITE_RATE_CNTR)"},{"line_number":170,"context_line":"        query_disk_stats(VC_DISK_WRITE_REQUESTS_RATE_CNTR)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        for disk_id in disk_ids:"},{"line_number":173,"context_line":"            if not disk_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2Fr7c%3D","line":170,"updated":"2014-03-04 17:23:24.000000000","message":"loop instead of nested class","commit_id":"c9b26c66b22bc1beaf8b6f64d75347f91aa3f236"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"be0d9dec802d1e37dceaea8392e95b98b3a273f2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        query_disk_stats(VC_DISK_READ_RATE_CNTR)"},{"line_number":168,"context_line":"        query_disk_stats(VC_DISK_READ_REQUESTS_RATE_CNTR)"},{"line_number":169,"context_line":"        query_disk_stats(VC_DISK_WRITE_RATE_CNTR)"},{"line_number":170,"context_line":"        query_disk_stats(VC_DISK_WRITE_REQUESTS_RATE_CNTR)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        for disk_id in disk_ids:"},{"line_number":173,"context_line":"            if not disk_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FrRg%3D","line":170,"in_reply_to":"AAAAVn%2F%2Fr7c%3D","updated":"2014-03-04 18:17:29.000000000","message":"Done","commit_id":"c9b26c66b22bc1beaf8b6f64d75347f91aa3f236"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"041cdfc260174fd25160aac1a89bc77d694a03ab","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        query_disk_stats(VC_DISK_WRITE_REQUESTS_RATE_CNTR)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        for disk_id in disk_ids:"},{"line_number":173,"context_line":"            if not disk_id:"},{"line_number":174,"context_line":"                continue"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"            def stat_val(counter_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2Fr5U%3D","line":173,"updated":"2014-03-04 17:23:24.000000000","message":"this is an odd clause, there\u0027s a case where it returns None key?","commit_id":"c9b26c66b22bc1beaf8b6f64d75347f91aa3f236"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"be0d9dec802d1e37dceaea8392e95b98b3a273f2","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        query_disk_stats(VC_DISK_WRITE_REQUESTS_RATE_CNTR)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        for disk_id in disk_ids:"},{"line_number":173,"context_line":"            if not disk_id:"},{"line_number":174,"context_line":"                continue"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"            def stat_val(counter_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FrRc%3D","line":173,"in_reply_to":"AAAAVn%2F%2Fr5U%3D","updated":"2014-03-04 18:17:29.000000000","message":"Done","commit_id":"c9b26c66b22bc1beaf8b6f64d75347f91aa3f236"}],"ceilometer/tests/compute/pollsters/test_diskio.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1c1c447b1e2cba45b2d2390776dbb72aed5b4592","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":98,"context_line":"        cache \u003d {}"},{"line_number":99,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":100,"context_line":"        assert samples"},{"line_number":101,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_RATE, cache)"},{"line_number":102,"context_line":"        self.assertIn(self.instance.id, cache[pollster.CACHE_KEY_DISK_RATE])"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2F1qY%3D","line":100,"updated":"2014-02-27 22:52:23.000000000","message":"self.assertIsNotNone(samples)","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"ba758057b8c48f011206fd6a52d063754207a1b6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":98,"context_line":"        cache \u003d {}"},{"line_number":99,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":100,"context_line":"        assert samples"},{"line_number":101,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_RATE, cache)"},{"line_number":102,"context_line":"        self.assertIn(self.instance.id, cache[pollster.CACHE_KEY_DISK_RATE])"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVX%2F%2Fw4g%3D","line":100,"in_reply_to":"AAAAVX%2F%2F1qY%3D","updated":"2014-02-28 13:07:37.000000000","message":"Done","commit_id":"f0cde2e2a29ad35b7e642f58fbdf671030aac72d"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e3293d352e0afa3be45ca35c511738e968a56327","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":99,"context_line":"        cache \u003d {}"},{"line_number":100,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":101,"context_line":"        assert samples"},{"line_number":102,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_RATE, cache)"},{"line_number":103,"context_line":"        self.assertIn(self.instance.id, cache[pollster.CACHE_KEY_DISK_RATE])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F53E%3D","line":100,"updated":"2014-03-03 15:25:40.000000000","message":"Needs rebase like in the example here: https://review.openstack.org/#/c/75006/11/ceilometer/tests/compute/pollsters/test_diskio.py","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"c4c87daff546c2e64077ae49f316f41d24909d54","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":99,"context_line":"        cache \u003d {}"},{"line_number":100,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":101,"context_line":"        assert samples"},{"line_number":102,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_RATE, cache)"},{"line_number":103,"context_line":"        self.assertIn(self.instance.id, cache[pollster.CACHE_KEY_DISK_RATE])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FtY4%3D","line":100,"in_reply_to":"AAAAVn%2F%2F53E%3D","updated":"2014-03-04 15:34:48.000000000","message":"Done","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e3293d352e0afa3be45ca35c511738e968a56327","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                         set([sample_name]))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        match \u003d [s for s in samples if s.name \u003d\u003d sample_name]"},{"line_number":109,"context_line":"        self.assertEqual(len(match), 1, \u0027missing counter %s\u0027 % sample_name)"},{"line_number":110,"context_line":"        self.assertEqual(match[0].volume, expected_volume)"},{"line_number":111,"context_line":"        self.assertEqual(match[0].type, \u0027gauge\u0027)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F51s%3D","line":109,"updated":"2014-03-03 15:25:40.000000000","message":"According to bug: https://bugs.launchpad.net/ceilometer/+bug/1277104, the order of expected and actual should be changed in the assertEqual functions here.","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"c4c87daff546c2e64077ae49f316f41d24909d54","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                         set([sample_name]))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        match \u003d [s for s in samples if s.name \u003d\u003d sample_name]"},{"line_number":109,"context_line":"        self.assertEqual(len(match), 1, \u0027missing counter %s\u0027 % sample_name)"},{"line_number":110,"context_line":"        self.assertEqual(match[0].volume, expected_volume)"},{"line_number":111,"context_line":"        self.assertEqual(match[0].type, \u0027gauge\u0027)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FtXM%3D","line":109,"in_reply_to":"AAAAVn%2F%2F51s%3D","updated":"2014-03-04 15:34:48.000000000","message":"Done","commit_id":"7cd8b739430b3d6a9995c97281a8eea3eb127f0c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9b009ea08ab5343baf97f36b9b0eb111e4a8c497","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":98,"context_line":"        cache \u003d {}"},{"line_number":99,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, [self.instance]))"},{"line_number":100,"context_line":"        assert samples"},{"line_number":101,"context_line":"        self.assertIsNotNone(samples)"},{"line_number":102,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_RATE, cache)"},{"line_number":103,"context_line":"        self.assertIn(self.instance.id, cache[pollster.CACHE_KEY_DISK_RATE])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2B6mQ%3D","line":100,"updated":"2014-03-11 10:27:55.000000000","message":"Nop.","commit_id":"d80b5b385dd7b725e615ab56b307522aa0bdb911"}]}