)]}'
{"ceilometer/compute/pollsters/net.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"51d23c6595c24374cebc67d4ab5460c880448f43","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":207,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":208,"context_line":"        except Exception as err:"},{"line_number":209,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":210,"context_line":"                        {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F5kw%3D","line":209,"updated":"2014-03-03 15:03:26.000000000","message":"please use a , instead of the %","commit_id":"6c689291dbf39768bb832c6a039a510af7793b7d"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"b6a9472b0e33a3e53d3fd4d8ffd1725e6a666e30","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            # Instance was deleted while getting samples. Ignore it."},{"line_number":207,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":208,"context_line":"        except Exception as err:"},{"line_number":209,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":210,"context_line":"                        {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuD0%3D","line":209,"in_reply_to":"AAAAVn%2F%2F5kw%3D","updated":"2014-03-04 14:13:40.000000000","message":"Done","commit_id":"6c689291dbf39768bb832c6a039a510af7793b7d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"413a41bb9b40611cad293783138c7a026202ca76","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class _RateBase(plugin.ComputePollster):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    NET_RATE_MESSAGE \u003d \u0027 \u0027.join([\"NETWORK RATE:\", \"%s %s:\","},{"line_number":153,"context_line":"                                 \"read-bytes-rate\u003d%d\","},{"line_number":154,"context_line":"                                 \"write-bytes-rate\u003d%d\"])"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fs5k%3D","line":152,"updated":"2014-03-04 15:56:07.000000000","message":"this whole class looks like an exact copy of above. can we just  inherit _Base, override NET_USAGE_MESSAGE and set a var to point to either \u0027inspect_vnic_rates\u0027 or \u0027inspect_vnics\u0027?","commit_id":"12a3673b00a180324e284a145955173c6f528f87"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"47380a90194deba90f1d3d474a18483dd7e4684f","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class _RateBase(plugin.ComputePollster):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    NET_RATE_MESSAGE \u003d \u0027 \u0027.join([\"NETWORK RATE:\", \"%s %s:\","},{"line_number":153,"context_line":"                                 \"read-bytes-rate\u003d%d\","},{"line_number":154,"context_line":"                                 \"write-bytes-rate\u003d%d\"])"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fmuw%3D","line":152,"in_reply_to":"AAAAVn%2F%2Fs5k%3D","updated":"2014-03-05 04:04:16.000000000","message":"Done","commit_id":"12a3673b00a180324e284a145955173c6f528f87"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d858c7d6358664c24efd8984bd15406a10bedde5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":102,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":103,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":104,"context_line":"            except Exception as err:"},{"line_number":105,"context_line":"                LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":106,"context_line":"                            {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":107,"context_line":"                LOG.exception(err)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FWok%3D","line":104,"updated":"2014-03-06 17:14:03.000000000","message":"catch notimplemented as well","commit_id":"1a17df484d063fde7289b6486e923a6c656c7be2"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d858c7d6358664c24efd8984bd15406a10bedde5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            except Exception as err:"},{"line_number":105,"context_line":"                LOG.warning(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":106,"context_line":"                            {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":107,"context_line":"                LOG.exception(err)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class _RateBase(_Base):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FWns%3D","line":107,"updated":"2014-03-06 17:14:03.000000000","message":"let\u0027s fix this double log while we\u0027re at it. change match other pollsters","commit_id":"1a17df484d063fde7289b6486e923a6c656c7be2"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"44ef87bef39c2d6da8d5aad57281205ab21b47b1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_tx_info(self, info):"},{"line_number":75,"context_line":"        return info.tx_bytes"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _get_vnics_for_instance(self, cache, inspector, instance):"},{"line_number":78,"context_line":"        instance_name \u003d util.instance_name(instance)"},{"line_number":79,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_VNIC, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FIA4%3D","line":76,"updated":"2014-03-08 19:42:47.000000000","message":"Why did you change instance_name to instance? Everywhere you still need instance_name:) In _get_vnic_info you need instance_name too.","commit_id":"171d1aa01327dd6afd55c1588daa86cb479f38bd"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"2add41196ab87a894aeb7ecc6dd83675145de121","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_tx_info(self, info):"},{"line_number":75,"context_line":"        return info.tx_bytes"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _get_vnics_for_instance(self, cache, inspector, instance):"},{"line_number":78,"context_line":"        instance_name \u003d util.instance_name(instance)"},{"line_number":79,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_VNIC, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FEHk%3D","line":76,"in_reply_to":"AAAAVn%2F%2FIA4%3D","updated":"2014-03-11 11:22:54.000000000","message":"_get_vnic_info is overridden in _RateBase(_Base) where instance needs to be passed to the inspector method.","commit_id":"171d1aa01327dd6afd55c1588daa86cb479f38bd"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"44dd7917f261df3e3cd23d558f401b5c0a01c051","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        instance_name \u003d util.instance_name(instance)"},{"line_number":69,"context_line":"        return inspector.inspect_vnics(instance_name)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _get_rx_info(self, info):"},{"line_number":72,"context_line":"        return info.rx_bytes"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_tx_info(self, info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2B5HQ%3D","line":71,"updated":"2014-03-11 14:06:46.000000000","message":"@staticmethod\n\nand not sure it\u0027s worth a method...","commit_id":"e75212bb9f416df64721e30a7e260ba654958c5d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"44dd7917f261df3e3cd23d558f401b5c0a01c051","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _get_rx_info(self, info):"},{"line_number":72,"context_line":"        return info.rx_bytes"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _get_tx_info(self, info):"},{"line_number":75,"context_line":"        return info.tx_bytes"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _get_vnics_for_instance(self, cache, inspector, instance):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2B5HM%3D","line":74,"updated":"2014-03-11 14:06:46.000000000","message":"@staticmethod","commit_id":"e75212bb9f416df64721e30a7e260ba654958c5d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"44dd7917f261df3e3cd23d558f401b5c0a01c051","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def _get_vnic_info(self, inspector, instance):"},{"line_number":125,"context_line":"        return inspector.inspect_vnic_rates(instance)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_rx_info(self, info):"},{"line_number":128,"context_line":"        return info.rx_bytes_rate"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _get_tx_info(self, info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2B5HE%3D","line":127,"updated":"2014-03-11 14:06:46.000000000","message":"@staticmethod","commit_id":"e75212bb9f416df64721e30a7e260ba654958c5d"}],"ceilometer/compute/virt/inspector.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"51d23c6595c24374cebc67d4ab5460c880448f43","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# tx_packets_rate: rate of transmitted packets"},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"InterfaceRateStats \u003d collections.namedtuple(\u0027InterfaceRateStats\u0027,"},{"line_number":94,"context_line":"                                            [\u0027rx_bytes_rate\u0027, \u0027tx_bytes_rate\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Named tuple representing disks."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F5kE%3D","line":94,"updated":"2014-03-03 15:03:26.000000000","message":"why are the packets missing here? looks like it should be deleted from the comment","commit_id":"6c689291dbf39768bb832c6a039a510af7793b7d"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"b6a9472b0e33a3e53d3fd4d8ffd1725e6a666e30","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# tx_packets_rate: rate of transmitted packets"},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"InterfaceRateStats \u003d collections.namedtuple(\u0027InterfaceRateStats\u0027,"},{"line_number":94,"context_line":"                                            [\u0027rx_bytes_rate\u0027, \u0027tx_bytes_rate\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Named tuple representing disks."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuCg%3D","line":94,"in_reply_to":"AAAAVn%2F%2F5kE%3D","updated":"2014-03-04 14:13:40.000000000","message":"Counters providing packet information from Vsphere are summation counters and not average counters, which is expected here. Hence, not providing any implementation for it. Deleted them from the comment.","commit_id":"6c689291dbf39768bb832c6a039a510af7793b7d"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"413a41bb9b40611cad293783138c7a026202ca76","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            vnic_stats[net_counter] \u003d vnic_id_to_stats_map"},{"line_number":112,"context_line":"            vnic_ids.update(vnic_id_to_stats_map.iterkeys())"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        query_net_stats(VC_NETWORK_RX_BYTES_COUNTER)"},{"line_number":115,"context_line":"        query_net_stats(VC_NETWORK_TX_BYTES_COUNTER)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for vnic_id in vnic_ids:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FtAo%3D","line":114,"updated":"2014-03-04 15:56:07.000000000","message":"this probably could be just a for loop rather than a nested class","commit_id":"12a3673b00a180324e284a145955173c6f528f87"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"47380a90194deba90f1d3d474a18483dd7e4684f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            vnic_stats[net_counter] \u003d vnic_id_to_stats_map"},{"line_number":112,"context_line":"            vnic_ids.update(vnic_id_to_stats_map.iterkeys())"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        query_net_stats(VC_NETWORK_RX_BYTES_COUNTER)"},{"line_number":115,"context_line":"        query_net_stats(VC_NETWORK_TX_BYTES_COUNTER)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for vnic_id in vnic_ids:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2Fmu8%3D","line":114,"in_reply_to":"AAAAVn%2F%2FtAo%3D","updated":"2014-03-05 04:04:16.000000000","message":"Done","commit_id":"12a3673b00a180324e284a145955173c6f528f87"}]}