)]}'
{"ceilometer/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e6ccf2459675c220e730c3c7d7985f5ef1cce6cc","unresolved":false,"context_lines":[{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"        resp \u003d self.put_json(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":1153,"context_line":"                             params\u003djson,"},{"line_number":1154,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":1155,"context_line":"        self.assertEqual(resp.status_code, 409)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_alarm(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FYYE%3D","line":1154,"updated":"2014-03-06 14:02:56.000000000","message":"You should include expect_errors\u003dTrue into the params of put_json, and also the expected status. For details, see the function definition here: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/api/__init__.py#L116, and for test examples there are some with post_json: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/api/v2/test_alarm_scenarios.py#L336","commit_id":"1a1e13edea641d59c90fb02e9a467dff63638b54"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9b6f1702a0e6f3250ed043ae864e52049d610940","unresolved":false,"context_lines":[{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"        resp \u003d self.put_json(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":1153,"context_line":"                             params\u003djson,"},{"line_number":1154,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":1155,"context_line":"        self.assertEqual(resp.status_code, 409)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_alarm(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FSXA%3D","line":1154,"in_reply_to":"AAAAVn%2F%2FYYE%3D","updated":"2014-03-07 01:57:00.000000000","message":"Ildiko Vancsa,thanks for your comments:)","commit_id":"1a1e13edea641d59c90fb02e9a467dff63638b54"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6bf2cf422c5eee7cfada9696b1b277839048edb","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"        self.put_json(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":1153,"context_line":"                      expect_errors\u003dTrue, status\u003d409,"},{"line_number":1154,"context_line":"                      params\u003djson,"},{"line_number":1155,"context_line":"                      headers\u003dself.auth_headers)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_alarm(self):"},{"line_number":1158,"context_line":"        data \u003d self.get_json(\u0027/alarms\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FI%2FQ%3D","line":1155,"updated":"2014-03-08 09:12:13.000000000","message":"It would be good to add a check for the returned error message, as it is generated from the alarm name.","commit_id":"961afb760110decc85092249394e9090da1ecf7d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a13cf6a4d0b061ce02720933f4de8a0e8bc6b244","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"        self.put_json(\u0027/alarms/%s\u0027 % alarm_id,"},{"line_number":1153,"context_line":"                      expect_errors\u003dTrue, status\u003d409,"},{"line_number":1154,"context_line":"                      params\u003djson,"},{"line_number":1155,"context_line":"                      headers\u003dself.auth_headers)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    def test_delete_alarm(self):"},{"line_number":1158,"context_line":"        data \u003d self.get_json(\u0027/alarms\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVn%2F%2FFlE%3D","line":1155,"in_reply_to":"AAAAVn%2F%2FI%2FQ%3D","updated":"2014-03-10 01:48:40.000000000","message":"thanks,you are right, I will commit a new patch","commit_id":"961afb760110decc85092249394e9090da1ecf7d"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e01ce11933ba7ffd8305861ae4cf76e1269874ac","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"                             headers\u003dself.auth_headers)"},{"line_number":1156,"context_line":"        self.assertEqual("},{"line_number":1157,"context_line":"            resp.json[\u0027error_message\u0027][\u0027faultstring\u0027],"},{"line_number":1158,"context_line":"            \u0027Alarm with name\u003dname1 exists\u0027)"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    def test_delete_alarm(self):"},{"line_number":1161,"context_line":"        data \u003d self.get_json(\u0027/alarms\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FEVI%3D","line":1158,"updated":"2014-03-10 08:29:34.000000000","message":"According to bug: https://bugs.launchpad.net/heat/+bug/1259292, the order of the assertEqual should be: expected, observed.","commit_id":"8df25cff216d5424d9d3636d1b8952664e5b0cb1"}]}