)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"6d0690ea713c6da67f2d317da5a6ea90095b8a9a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"backing libraries."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://specs.openstack.org/openstack/oslo-"},{"line_number":17,"context_line":"specs/specs/victoria/oslo-vmware-soap-library-switch.html"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I449e045e948ad543c4d046b6449094c7617ce78f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1d4b2f72_984fe6a6","line":17,"updated":"2021-04-30 09:03:10.000000000","message":"As mentioned in the other review, please don\u0027t put a line-break into the URL.","commit_id":"41aa51a9df3e88c656073b87e92fde55475a3590"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f7be7c08436b5009122c884e83fb03bc07e556d4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"backing libraries."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://specs.openstack.org/openstack/oslo-"},{"line_number":17,"context_line":"specs/specs/victoria/oslo-vmware-soap-library-switch.html"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I449e045e948ad543c4d046b6449094c7617ce78f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2aa633af_8766a3b3","line":17,"in_reply_to":"1d4b2f72_984fe6a6","updated":"2021-04-30 15:31:24.000000000","message":"Done","commit_id":"41aa51a9df3e88c656073b87e92fde55475a3590"}],"ceilometer/compute/virt/vmware/vsphere_operations.py":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"6d0690ea713c6da67f2d317da5a6ea90095b8a9a","unresolved":true,"context_lines":[{"line_number":228,"context_line":"                    # Take the average of all samples to improve the accuracy"},{"line_number":229,"context_line":"                    # of the stat value and ignore -1 (bug 1639114)"},{"line_number":230,"context_line":"                    metric_series_val \u003d vim_util.get_moref_value(metric_series)"},{"line_number":231,"context_line":"                    filtered \u003d [i for i in metric_series_val if i !\u003d -1]"},{"line_number":232,"context_line":"                    stat_value \u003d float(sum(filtered)) / len(filtered)"},{"line_number":233,"context_line":"                    device_id \u003d metric_series.id.instance"},{"line_number":234,"context_line":"                    stat_values[device_id] \u003d stat_value"}],"source_content_type":"text/x-python","patch_set":1,"id":"29a43244_7237fb11","line":231,"updated":"2021-04-30 09:03:10.000000000","message":"These changes are incorrect as we don\u0027t handle a ManagedObjectReference here.","commit_id":"41aa51a9df3e88c656073b87e92fde55475a3590"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f7be7c08436b5009122c884e83fb03bc07e556d4","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                    # Take the average of all samples to improve the accuracy"},{"line_number":229,"context_line":"                    # of the stat value and ignore -1 (bug 1639114)"},{"line_number":230,"context_line":"                    metric_series_val \u003d vim_util.get_moref_value(metric_series)"},{"line_number":231,"context_line":"                    filtered \u003d [i for i in metric_series_val if i !\u003d -1]"},{"line_number":232,"context_line":"                    stat_value \u003d float(sum(filtered)) / len(filtered)"},{"line_number":233,"context_line":"                    device_id \u003d metric_series.id.instance"},{"line_number":234,"context_line":"                    stat_values[device_id] \u003d stat_value"}],"source_content_type":"text/x-python","patch_set":1,"id":"8da338a8_eaa6ad99","line":231,"in_reply_to":"29a43244_7237fb11","updated":"2021-04-30 15:31:24.000000000","message":"Done","commit_id":"41aa51a9df3e88c656073b87e92fde55475a3590"}],"ceilometer/tests/unit/compute/virt/vmware/test_vsphere_operations.py":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"c70b3712cb08221f43ad4ffd800545acb0312dd3","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        def construct_mock_vm_object(vm_moid, vm_instance):"},{"line_number":44,"context_line":"            vm_object \u003d mock.MagicMock()"},{"line_number":45,"context_line":"            vm_object.obj.value \u003d vm_moid"},{"line_number":46,"context_line":"            vm_object.obj._type \u003d \"VirtualMachine\""},{"line_number":47,"context_line":"            vm_object.propSet[0].val \u003d vm_instance"},{"line_number":48,"context_line":"            return vm_object"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b0b2fadb_bd95d70d","line":46,"updated":"2021-05-06 08:18:18.000000000","message":"This needs changing, too.","commit_id":"c3aabba05f336fd66b9c32f327d9bd47ec13a04d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"710b1e2002033c4d7db337fef82ea36f047265e7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        def construct_mock_vm_object(vm_moid, vm_instance):"},{"line_number":44,"context_line":"            vm_object \u003d mock.MagicMock()"},{"line_number":45,"context_line":"            vm_object.obj.value \u003d vm_moid"},{"line_number":46,"context_line":"            vm_object.obj._type \u003d \"VirtualMachine\""},{"line_number":47,"context_line":"            vm_object.propSet[0].val \u003d vm_instance"},{"line_number":48,"context_line":"            return vm_object"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fc1cc419_f9d759a3","line":46,"in_reply_to":"b0b2fadb_bd95d70d","updated":"2021-05-06 08:39:10.000000000","message":"vm_object.propSet[0].val\n\nI am not sure about above ? \npropSet is not an field of ManagedObjectReference, virtual_machine.","commit_id":"c3aabba05f336fd66b9c32f327d9bd47ec13a04d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"303e22264bca09949f01e3f83d59cb1561a5102c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        def construct_mock_vm_object(vm_moid, vm_instance):"},{"line_number":44,"context_line":"            vm_object \u003d mock.MagicMock()"},{"line_number":45,"context_line":"            vm_object.obj.value \u003d vm_moid"},{"line_number":46,"context_line":"            vm_object.obj._type \u003d \"VirtualMachine\""},{"line_number":47,"context_line":"            vm_object.propSet[0].val \u003d vm_instance"},{"line_number":48,"context_line":"            return vm_object"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f2cb0daf_55e0059b","line":46,"in_reply_to":"cf91ba3d_42140a15","updated":"2021-05-10 11:24:57.000000000","message":"fixed.","commit_id":"c3aabba05f336fd66b9c32f327d9bd47ec13a04d"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"5c512572d091936290cedfb0bbecddc995daab58","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        def construct_mock_vm_object(vm_moid, vm_instance):"},{"line_number":44,"context_line":"            vm_object \u003d mock.MagicMock()"},{"line_number":45,"context_line":"            vm_object.obj.value \u003d vm_moid"},{"line_number":46,"context_line":"            vm_object.obj._type \u003d \"VirtualMachine\""},{"line_number":47,"context_line":"            vm_object.propSet[0].val \u003d vm_instance"},{"line_number":48,"context_line":"            return vm_object"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cf91ba3d_42140a15","line":46,"in_reply_to":"fc1cc419_f9d759a3","updated":"2021-05-10 09:55:15.000000000","message":"You\u0027re right with that, but we need to change \"vm_object.obj\", as that\u0027s a \"ManagedObjectReference\". \"vm_object\" itself is an \"ObjectContent\"[1] object as returned in \"RetrieveResult\" by \"RetrievePropertiesEx\".\n\n[1] https://vdc-download.vmware.com/vmwb-repository/dcr-public/b50dcbbf-051d-4204-a3e7-e1b618c1e384/538cf2ec-b34f-4bae-a332-3820ef9e7773/vmodl.query.PropertyCollector.ObjectContent.html","commit_id":"c3aabba05f336fd66b9c32f327d9bd47ec13a04d"}]}