)]}'
{"id":"openstack%2Fceilometer~799963","triplet_id":"openstack%2Fceilometer~master~Ibde27d0053ff1446d1511bc1d9b4884b1ed31018","project":"openstack/ceilometer","branch":"master","topic":"cpu-util-libvirt","attention_set":{},"removed_from_attention_set":{"9542":{"account":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"last_update":"2023-04-13 13:42:14.000000000","reason":"Change was abandoned"},"4264":{"account":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"last_update":"2023-04-13 13:42:14.000000000","reason":"Change was abandoned"},"34653":{"account":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"last_update":"2022-10-06 08:28:27.000000000","reason":"\u003cGERRIT_ACCOUNT_34653\u003e replied on the change","reason_account":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"}}},"hashtags":[],"change_id":"Ibde27d0053ff1446d1511bc1d9b4884b1ed31018","subject":"WiP Add cpu_util metric to libvirt","status":"ABANDONED","created":"2021-07-08 06:38:24.000000000","updated":"2023-04-13 13:42:14.000000000","total_comment_count":7,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"2ad84de97820a5070cb15dcff9e4b409f5fffe14","_number":799963,"virtual_id_number":799963,"owner":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-08-15 17:26:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"}],"REVIEWER":[{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-08 07:49:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-15 08:10:53.000000000","updated_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"reviewer":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"state":"CC"},{"updated":"2022-08-24 07:28:53.000000000","updated_by":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"reviewer":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"state":"CC"}],"messages":[{"id":"49aa4cf6289b9390e6d56bc8ecc5d0b131659940","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2021-07-08 06:38:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0deb4e024244a5cd4621436888c1bd661c3e59b7","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2021-07-08 06:39:11.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"652f3ae41c24879879a7f11783157ebe923ecf14","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-08 07:49:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e4990ff29c144d84accfb9620765ef46 : FAILURE in 8m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9fdddfccfd7240e58f15e2e7b9369718 : SUCCESS in 5m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2dae62e502d54231805fe0792d836187 : FAILURE in 7m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/465e26f5f8884ea89ee6c832ded533c2 : FAILURE in 9m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3e2633bec7e34adc979e1a7d8d30c931 : FAILURE in 9m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3fc41164196b4f82ac1cb9796ab420be : SUCCESS in 9m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a268ed1331cb462d899ebb80dd6aaac8 : FAILURE in 9m 03s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/83cddfb118484371b9732469f757a389 : FAILURE in 1h 09m 42s (non-voting)\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/6bc3eef59fff4a26afb6fc69504dd4c2 : FAILURE in 45m 24s (non-voting)\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/1b0c06efec0b455bad6c777d0e87c535 : FAILURE in 47m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e118c393e3275dd8993cff52fe6e27afc1e84b7b","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-07-15 08:10:53.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nthank you, this looks like a small and valuable patch to ease some autoscaling pain.","accounts_in_message":[],"_revision_number":1},{"id":"ef4ca8861569c1a7d97c35fd35d1f47cb84e5f13","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2021-07-20 13:01:30.000000000","message":"Patch Set 1:\n\nAnother feedback here: Unfortunately, this collects non accurate results (grows over time, even with idle machines)","accounts_in_message":[],"_revision_number":1},{"id":"a1e2416abd531905f6b960a4d7a87a5b1a2aaff0","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2021-07-20 13:58:48.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Another feedback here: Unfortunately, this collects non accurate results (grows over time, even with idle machines)\n\nthat\u0027s the point. unfortunately this is the only numerical cpu related metric presented by libvirt :-/ this is basically ns (?) of consumed cpu time\n\nIf however we divide the difference between two consecutive measurements by the time diff between them, then divide by the CPU count - we get more or less the load in %. tbh I looked the logic up in the virt-manager code, where it takes the data to draw the cpu utilization % graph\n\nSo the idea is not to replace the \u0027old\u0027 cpu_util metric, instead this new one should be used exclusively with rate aggregation in Gnocchi, here we are just pre-calciulating as much as we can so that simple rate can be used in gnocchi w/o complicated math above (I bet this could\u0027ve been done directly in gnochi via some combined query as we need number of CPUs as well, but I honestly can\u0027t figure out how to do it, and so expect a lot of users will too).","accounts_in_message":[],"_revision_number":1},{"id":"3c2cdc267eac83534f57fef6b298fe1cb90deeec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2022-08-15 15:55:39.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"a094d15621388ef0162cde545b685741c15bcadf","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2022-08-15 16:51:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f2b9c4aa274b3939194e23afb5d63a80092004e3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-15 17:26:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/256d1149063044c09972106f5b81ce59\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c6c9520396d045269d7d22cf2219edc4 : SUCCESS in 6m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ff15ab5ab4ac4b0ebce1e74b208a7ee4 : SUCCESS in 3m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0fa26b25b93e41cdb39c74b83fd23874 : SUCCESS in 5m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/415993681a2f44588fb858c8d494c152 : SUCCESS in 6m 08s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/f6b0af0b67544569a7829b30d0c7368e : SUCCESS in 7m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d4a81a2b5ac84c3389867fff8006df32 : SUCCESS in 7m 03s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/ba87c157534c435486e7a9ee2e4ab834 : FAILURE in 1h 04m 15s (non-voting)\n- telemetry-dsvm-integration-centos-9s https://zuul.opendev.org/t/openstack/build/5acac8cd928f40ae9d209a4a9cab66b1 : SUCCESS in 54m 33s\n- telemetry-dsvm-integration-centos-9s-fips https://zuul.opendev.org/t/openstack/build/c9e4b9d0635e4ea387e01425dc8f85ac : RETRY_LIMIT in 26m 39s (non-voting)\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/d15eee1592a14a7c8ca2239598b84e01 : SUCCESS in 46m 03s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/fb432f0a9ae34dbdae90766e35fc5d7e : SUCCESS in 55m 39s","accounts_in_message":[],"_revision_number":2},{"id":"dcafdc7d656b4d7950ce74244b8c8a829be9dee9","author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"date":"2022-08-24 07:28:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9ca5480805618d7db1a68a540f93464d5e662b8e","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2022-09-01 08:49:56.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d44229fd9401f2f4f56f6ff0fe8af487b57266c8","author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"date":"2022-09-01 17:01:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"435a836ae3db7d08bfb1e1582ddef8509145d708","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2022-10-06 06:34:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"50143232fb1cd038a9e77d7384832ae765833d68","author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"date":"2022-10-06 08:28:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2ad84de97820a5070cb15dcff9e4b409f5fffe14","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2023-04-13 13:42:14.000000000","message":"Abandoned\n\nsolved by using gnocchi directly.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0b7b7629e72f69d500b17c9305ee7cff6eb9bb71","revisions":{"61a53c0f27458924edbf535e8bc059d9cba74c34":{"kind":"REWORK","_number":1,"created":"2021-07-08 06:38:24.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/63/799963/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/63/799963/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/1"}}},"commit":{"parents":[{"commit":"14922b71d2eebcf939963d010904525b01b2897e","subject":"Merge \"Ceilometer compute `retry_on_disconnect` using `no-wait`\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/14922b71d2eebcf939963d010904525b01b2897e"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2021-07-08 06:19:07.000000000","tz":180},"committer":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2021-07-08 06:33:03.000000000","tz":180},"subject":"WiP Add cpu_util metric to libvirt","message":"WiP Add cpu_util metric to libvirt\n\ncurrent alarming and aggregation based on CPU utilization for libvirt\ninstances is next to impossible.\nThe raw \u0027cpu\u0027 metric is cumulative and is very unintuitive how to transform\nit to simple \u0027cpu load / cpu utilization\u0027 which is easier to take action\non even if it may be not very precise.\n\nThis patch attempts to add this metric, or at least some sort of it,\nfor libvirt instances - as pre-calculated value that still, as \u0027cpu\u0027,\nmust be consumed via \u0027rate:...\u0027 aggregations in Gnocchi.\n\nChange-Id: Ibde27d0053ff1446d1511bc1d9b4884b1ed31018\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/61a53c0f27458924edbf535e8bc059d9cba74c34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/61a53c0f27458924edbf535e8bc059d9cba74c34"}]},"branch":"refs/heads/master"},"0b7b7629e72f69d500b17c9305ee7cff6eb9bb71":{"kind":"REWORK","_number":2,"created":"2022-08-15 15:55:39.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/63/799963/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/63/799963/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/63/799963/2"}}},"commit":{"parents":[{"commit":"14922b71d2eebcf939963d010904525b01b2897e","subject":"Merge \"Ceilometer compute `retry_on_disconnect` using `no-wait`\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/14922b71d2eebcf939963d010904525b01b2897e"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2021-07-08 06:19:07.000000000","tz":180},"committer":{"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","date":"2022-08-15 15:55:39.000000000","tz":0},"subject":"WiP Add cpu_util metric to libvirt","message":"WiP Add cpu_util metric to libvirt\n\ncurrent alarming and aggregation based on CPU utilization for libvirt\ninstances is next to impossible.\nThe raw \u0027cpu\u0027 metric is cumulative and is very unintuitive how to transform\nit to simple \u0027cpu load / cpu utilization\u0027 which is easier to take action\non even if it may be not very precise.\n\nThis patch attempts to add this metric, or at least some sort of it,\nfor libvirt instances - as pre-calculated value that still, as \u0027cpu\u0027,\nmust be consumed via \u0027rate:...\u0027 aggregations in Gnocchi.\n\nChange-Id: Ibde27d0053ff1446d1511bc1d9b4884b1ed31018\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0b7b7629e72f69d500b17c9305ee7cff6eb9bb71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0b7b7629e72f69d500b17c9305ee7cff6eb9bb71"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}