)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b3bc7bbe546ee71c948573ea879b01472848309f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"accuracy of the sample by averaging the samples over the pollster"},{"line_number":14,"context_line":"interval."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id75fe87840b82d7c7d3e4fae9b2fc982e22ea1d7"},{"line_number":17,"context_line":"Implements: blueprint vmware-vcenter-server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAWH%2F%2B8gI%3D","line":16,"updated":"2014-03-21 13:47:37.000000000","message":"add Closes-Bug: 129550","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"8bf9e765f85fc3ba2d15d5f761f9a1265c69e23f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"accuracy of the sample by averaging the samples over the pollster"},{"line_number":14,"context_line":"interval."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id75fe87840b82d7c7d3e4fae9b2fc982e22ea1d7"},{"line_number":17,"context_line":"Implements: blueprint vmware-vcenter-server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAWH%2F%2Bn44%3D","line":16,"in_reply_to":"AAAAWH%2F%2B8gI%3D","updated":"2014-03-25 14:24:39.000000000","message":"Done","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"}],"ceilometer/compute/plugin.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b3bc7bbe546ee71c948573ea879b01472848309f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param resources: The resources to examine (expected to be instances)"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _record_poll_time(self):"},{"line_number":43,"context_line":"        \"\"\"Method records current time as the poll time."},{"line_number":44,"context_line":"        :return time in seconds that has elapsed after the last poll time was"},{"line_number":45,"context_line":"                recorded"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2B8fU%3D","line":42,"updated":"2014-03-21 13:47:37.000000000","message":"i\u0027m ok with this...but have you looked at a way to just pass in polling time? just so we can avoid the overhead of timing.","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"8bf9e765f85fc3ba2d15d5f761f9a1265c69e23f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param resources: The resources to examine (expected to be instances)"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _record_poll_time(self):"},{"line_number":43,"context_line":"        \"\"\"Method records current time as the poll time."},{"line_number":44,"context_line":"        :return time in seconds that has elapsed after the last poll time was"},{"line_number":45,"context_line":"                recorded"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Bn98%3D","line":42,"in_reply_to":"AAAAWH%2F%2B8fU%3D","updated":"2014-03-25 14:24:39.000000000","message":"Sorry, but I did not quite understand - \"overhead of timing\". Are you suggesting that the method should take a time-stamp parameter as input [ _record_poll_time(self, poll_time): ] and the invoking code should pass current time as poll time [ _record_poll_time(timeutils.utcnow()) ]?","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b3bc7bbe546ee71c948573ea879b01472848309f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _record_poll_time(self):"},{"line_number":43,"context_line":"        \"\"\"Method records current time as the poll time."},{"line_number":44,"context_line":"        :return time in seconds that has elapsed after the last poll time was"},{"line_number":45,"context_line":"                recorded"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        current_time \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2B8f8%3D","line":44,"updated":"2014-03-21 13:47:37.000000000","message":":return: time in seconds since the last poll time was recorded\n\nalso add an empty line between function description and return description","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"8bf9e765f85fc3ba2d15d5f761f9a1265c69e23f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _record_poll_time(self):"},{"line_number":43,"context_line":"        \"\"\"Method records current time as the poll time."},{"line_number":44,"context_line":"        :return time in seconds that has elapsed after the last poll time was"},{"line_number":45,"context_line":"                recorded"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        current_time \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BoG0%3D","line":44,"in_reply_to":"AAAAWH%2F%2B8f8%3D","updated":"2014-03-25 14:24:39.000000000","message":"Done","commit_id":"2df42736342d080c55bc51c9d4f92b081c5a61bb"}],"ceilometer/compute/virt/vmware/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f502bd931e6255ffbd6340c7d34bfc4454591939","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # In next release, there is an effort to make the pollsters aware of"},{"line_number":50,"context_line":"    # their own interval, in which case the following parameter should be"},{"line_number":51,"context_line":"    # replaced with those."},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027pipeline_interval\u0027,"},{"line_number":53,"context_line":"               default\u003d600,"},{"line_number":54,"context_line":"               help\u003d\u0027Interval in seconds of pollster pipelines\u0027)"},{"line_number":55,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fo6U%3D","line":52,"updated":"2014-03-14 20:12:25.000000000","message":"i\u0027m not sure this works. you can have multiple pipelines with different poll intervals each for single agent... it would only work on default case.\n\nif this is really needed, can we not have an internal timestamp which we record to see how long ago we previously polled? i assume we have the same obj?","commit_id":"5ee53ea53c9529fc9da0e67f702c246a6ea2a0bf"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"80a41559173a60a8433e30ec77d5ae5dee37af45","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # In next release, there is an effort to make the pollsters aware of"},{"line_number":50,"context_line":"    # their own interval, in which case the following parameter should be"},{"line_number":51,"context_line":"    # replaced with those."},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027pipeline_interval\u0027,"},{"line_number":53,"context_line":"               default\u003d600,"},{"line_number":54,"context_line":"               help\u003d\u0027Interval in seconds of pollster pipelines\u0027)"},{"line_number":55,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FmJk%3D","line":52,"in_reply_to":"AAAAWH%2F%2Fo6U%3D","updated":"2014-03-15 14:45:16.000000000","message":"Done","commit_id":"5ee53ea53c9529fc9da0e67f702c246a6ea2a0bf"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f502bd931e6255ffbd6340c7d34bfc4454591939","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # Stats provided from vSphere are in KB/s, converting it to B/s."},{"line_number":139,"context_line":"        for vnic_id in vnic_ids:"},{"line_number":140,"context_line":"            rx_bytes_rate \u003d (vnic_stats[VC_NETWORK_RX_COUNTER]"},{"line_number":141,"context_line":"                             .get(vnic_id, 0) * units.Ki)"},{"line_number":142,"context_line":"            tx_bytes_rate \u003d (vnic_stats[VC_NETWORK_TX_COUNTER]"},{"line_number":143,"context_line":"                             .get(vnic_id, 0) * units.Ki)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Fo54%3D","line":140,"updated":"2014-03-14 20:12:25.000000000","message":"i like this fix... i noticed this when i was cleaning up code","commit_id":"5ee53ea53c9529fc9da0e67f702c246a6ea2a0bf"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"82fd17eb8f9961b23b862aa1f18fd9030eebeae5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"               help\u003d\u0027Password of VMware Vsphere\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":41,"context_line":"               default\u003d10,"},{"line_number":42,"context_line":"               help\u003d\u0027Number of times a VMware Vsphere API must be retried\u0027),"},{"line_number":43,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FmPk%3D","line":42,"updated":"2014-03-15 13:25:50.000000000","message":"I had this question even before... Isn\u0027t it possible not to aggregate statistics in inspector but vary this config to make it equal to interval from pipeline.yaml?","commit_id":"5782f8143ec084c2529854f84bad9b63eec93977"},{"author":{"_account_id":10356,"name":"Akhil Hingane","email":"akhils@vmware.com","username":"akhilhingane"},"change_message_id":"27da6498d21832aaff5943240519f473d365a7cb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"               help\u003d\u0027Password of VMware Vsphere\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":41,"context_line":"               default\u003d10,"},{"line_number":42,"context_line":"               help\u003d\u0027Number of times a VMware Vsphere API must be retried\u0027),"},{"line_number":43,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":44,"context_line":"                 default\u003d0.5,"},{"line_number":45,"context_line":"                 help\u003d\u0027Sleep time in seconds for polling an ongoing async \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FmIc%3D","line":42,"in_reply_to":"AAAAWH%2F%2FmPk%3D","updated":"2014-03-15 14:44:56.000000000","message":"The \u0027task_poll_interval\u0027 is applicable for aync tasks. And \u0027querying performance statistics\u0027 from vSphere is not an \u0027async\u0027 task. So, varying this config will not make any difference to the way the API behaves.","commit_id":"5782f8143ec084c2529854f84bad9b63eec93977"}]}
