)]}'
{"ceilometer/alarm/evaluator/__init__.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b92df08b5538c3e655c8b484fefdf3b18d2e40fd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if not self.api_client:"},{"line_number":52,"context_line":"            auth_config \u003d cfg.CONF.service_credentials"},{"line_number":53,"context_line":"            creds \u003d dict("},{"line_number":54,"context_line":"                os_auth_url\u003dauth_config.os_auth_url,"},{"line_number":55,"context_line":"                os_region_name\u003dauth_config.os_region_name,"},{"line_number":56,"context_line":"                os_tenant_name\u003dauth_config.os_tenant_name,"},{"line_number":57,"context_line":"                os_password\u003dauth_config.os_password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FpDg%3D","line":54,"updated":"2014-03-14 19:48:12.000000000","message":"i wonder if it\u0027s just easier to just pass in **cfg.CONF.service_credentials... we seem to be essentially doing that now (minus region_name.. which we may end up adding as well)\n\nsame for every other case we keep missing.","commit_id":"70621f43193fd32a8bb699b23d2b6f72d57be381"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4ce1076d225155f12a42fa41c3fed8415ad20f2e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if not self.api_client:"},{"line_number":52,"context_line":"            auth_config \u003d cfg.CONF.service_credentials"},{"line_number":53,"context_line":"            creds \u003d dict("},{"line_number":54,"context_line":"                os_auth_url\u003dauth_config.os_auth_url,"},{"line_number":55,"context_line":"                os_region_name\u003dauth_config.os_region_name,"},{"line_number":56,"context_line":"                os_tenant_name\u003dauth_config.os_tenant_name,"},{"line_number":57,"context_line":"                os_password\u003dauth_config.os_password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FQ60%3D","line":54,"in_reply_to":"AAAAWH%2F%2FWEc%3D","updated":"2014-03-19 01:27:40.000000000","message":"hmm..  i guess something we can revisit at a later point... haven\u0027t really looked at all the other cases.","commit_id":"70621f43193fd32a8bb699b23d2b6f72d57be381"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"55f42513673f11566cc1536f72bf248571ca129b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if not self.api_client:"},{"line_number":52,"context_line":"            auth_config \u003d cfg.CONF.service_credentials"},{"line_number":53,"context_line":"            creds \u003d dict("},{"line_number":54,"context_line":"                os_auth_url\u003dauth_config.os_auth_url,"},{"line_number":55,"context_line":"                os_region_name\u003dauth_config.os_region_name,"},{"line_number":56,"context_line":"                os_tenant_name\u003dauth_config.os_tenant_name,"},{"line_number":57,"context_line":"                os_password\u003dauth_config.os_password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FWEc%3D","line":54,"in_reply_to":"AAAAWH%2F%2FpDg%3D","updated":"2014-03-18 22:47:31.000000000","message":"I\u0027m not sure the intent is quite as clear as passing the kwargs in explicitly. It also depends on a exact match between the registered config options in the service_credentials group and the kwargs expected by the client class.","commit_id":"70621f43193fd32a8bb699b23d2b6f72d57be381"}]}
