)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"06f79f609308ae994c3a71d6718f891440577ef2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Samples from net-pollster use different resource-format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added opportunity to get all pollsters use single resource-format."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie0749a970ebae120570ab5155097276adacf1fe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2Ff7c%3D","line":10,"updated":"2014-03-17 14:42:09.000000000","message":"Please add \"Closes bug bug_id\"","commit_id":"a402c9685ffe6d8c3edcf96d8230f1fbc7f61e72"}],"ceilometer/compute/pollsters/net.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"74d7430a8e61f5eeaaea07d3b0c47329801ba8f2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            volume\u003dvolume,"},{"line_number":52,"context_line":"            user_id\u003dinstance.user_id,"},{"line_number":53,"context_line":"            project_id\u003dinstance.tenant_id,"},{"line_number":54,"context_line":"            resource_id\u003dinstance.id,"},{"line_number":55,"context_line":"            timestamp\u003dtimeutils.isotime(),"},{"line_number":56,"context_line":"            resource_metadata\u003dresource_metadata"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FIU4%3D","line":54,"updated":"2014-03-20 02:35:24.000000000","message":"I don\u0027t think using VM instance.id as resource_id is correct. What if the VM has multiple vnics, then we\u0027ll end up with multiple vnics using the same resource_id.\n\nPlease see the patch which introduced with rid conecept, https://review.openstack.org/#/c/29353","commit_id":"a3c44325e0bdc3caf783e1397f85bb1e361efb04"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"8ab304cb1caedf163d001b4c31501f4558d193a2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            volume\u003dvolume,"},{"line_number":52,"context_line":"            user_id\u003dinstance.user_id,"},{"line_number":53,"context_line":"            project_id\u003dinstance.tenant_id,"},{"line_number":54,"context_line":"            resource_id\u003dinstance.id,"},{"line_number":55,"context_line":"            timestamp\u003dtimeutils.isotime(),"},{"line_number":56,"context_line":"            resource_metadata\u003dresource_metadata"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2FHqQ%3D","line":54,"in_reply_to":"AAAAWH%2F%2FIU4%3D","updated":"2014-03-20 04:55:57.000000000","message":"Lianhao, thanks for explanations! It\u0027s a little bit confusing, but i cannot suggest anything better. As for me interface_id is smth like sub-info of instance. So if we do \"sample-list -q resource_id\u003d123\" and the instance has several vnics then I expect to get a dict with {interface_id : [samples]}. But anyway that\u0027s just my thoughts and looks like I need to think about resource_id conception again","commit_id":"a3c44325e0bdc3caf783e1397f85bb1e361efb04"}],"ceilometer/tests/compute/pollsters/test_net.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"af1f1f96e7c885137166cc3b1d61bad243add6cb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestNetPollster, self).setUp()"},{"line_number":33,"context_line":"        self.vnic0 \u003d virt_inspector.Interface("},{"line_number":34,"context_line":"            name\u003d\u0027vnet0\u0027,"},{"line_number":35,"context_line":"            fref\u003dself.instance.id,"},{"line_number":36,"context_line":"            mac\u003d\u0027fa:16:3e:71:ec:6d\u0027,"},{"line_number":37,"context_line":"            parameters\u003ddict(ip\u003d\u002710.0.0.2\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FgC4%3D","line":34,"updated":"2014-03-17 14:32:32.000000000","message":"I don\u0027t think you need to change frefs here","commit_id":"a402c9685ffe6d8c3edcf96d8230f1fbc7f61e72"},{"author":{"_account_id":10374,"name":"Alexander Bochkarev","email":"abochkarev@mirantis.com","username":"abochkarev"},"change_message_id":"04ba505a1a15cbc45cedcc1bd96f18b2b528ddb7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestNetPollster, self).setUp()"},{"line_number":33,"context_line":"        self.vnic0 \u003d virt_inspector.Interface("},{"line_number":34,"context_line":"            name\u003d\u0027vnet0\u0027,"},{"line_number":35,"context_line":"            fref\u003dself.instance.id,"},{"line_number":36,"context_line":"            mac\u003d\u0027fa:16:3e:71:ec:6d\u0027,"},{"line_number":37,"context_line":"            parameters\u003ddict(ip\u003d\u002710.0.0.2\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FZEw%3D","line":34,"in_reply_to":"AAAAWH%2F%2FgC4%3D","updated":"2014-03-18 07:53:48.000000000","message":"I think we should change frefs here, because it affects on test execution. Now we get all pollsters with resource id \u003d\u003d instance.id. Please see TestNetPollster._check_get_samples - here we get samples with pollster.get_samples, it calls make_vnic_sample method in net.py (I\u0027ve removed from this breaking the compute pollsters up into separate plugins). if I am wrong, please fix me)","commit_id":"a402c9685ffe6d8c3edcf96d8230f1fbc7f61e72"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"89623745777ba9c7a972a05e2a81c7300f7d25bd","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            self.assertEqual(match[0].volume, expected_volume)"},{"line_number":86,"context_line":"            self.assertEqual(match[0].type, \u0027cumulative\u0027)"},{"line_number":87,"context_line":"            self.assertEqual(match[0].resource_id, expected_rid)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        for ip, volume, rid in expected:"},{"line_number":90,"context_line":"            _verify_vnic_metering(ip, volume, rid)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FYHI%3D","line":88,"updated":"2014-03-18 09:24:39.000000000","message":"This staff may be changed to \nfor ip, volume in expected:\n    _verify_vnic_metering(ip, volume, self.instance.id)\n\nAnd all the tests below may be changed to, e.g.:\nself._check_get_samples(\n[(\u002710.0.0.2\u0027, 1L),\n(\u0027192.168.0.3\u0027, 5L),\n(\u0027192.168.0.4\u0027, 9L)]\n The same is for line 224","commit_id":"a402c9685ffe6d8c3edcf96d8230f1fbc7f61e72"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"af1f1f96e7c885137166cc3b1d61bad243add6cb","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_incoming_bytes_rate(self):"},{"line_number":232,"context_line":"        self._check_get_samples("},{"line_number":233,"context_line":"            net.IncomingBytesRatePollster,"},{"line_number":234,"context_line":"            [(\u002710.0.0.2\u0027, 1L, self.vnic0.fref),"},{"line_number":235,"context_line":"             (\u0027192.168.0.3\u0027, 3L, self.vnic1.fref),"},{"line_number":236,"context_line":"             (\u0027192.168.0.4\u0027, 5L, self.instance.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FgBM%3D","line":233,"updated":"2014-03-17 14:32:32.000000000","message":"It should be enough to change only expected rids here","commit_id":"a402c9685ffe6d8c3edcf96d8230f1fbc7f61e72"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"213a3321933cc4ecb48a4729d0c06252c602c0d2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.assertEqual(len(samples), 3)  # one for each nic"},{"line_number":77,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":78,"context_line":"                         set([samples[0].name]))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        def _verify_vnic_metering(ip, expected_volume, instance_id):"},{"line_number":81,"context_line":"            match \u003d [s for s in samples"},{"line_number":82,"context_line":"                     if s.resource_metadata[\u0027parameters\u0027][\u0027ip\u0027] \u003d\u003d ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FWJY%3D","line":79,"updated":"2014-03-18 13:38:51.000000000","message":"You are verifying that resource_id is as expected. So I think that expected_rid was the correct name of variable.","commit_id":"0c05476096ef5e13742b3d90291b6048fbe877f5"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"213a3321933cc4ecb48a4729d0c06252c602c0d2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self.assertEqual(3, len(samples))  # one for each nic"},{"line_number":216,"context_line":"        self.assertEqual(set([samples[0].name]),"},{"line_number":217,"context_line":"                         set([s.name for s in samples]))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        def _verify_vnic_metering(ip, expected_volume, instance_id):"},{"line_number":220,"context_line":"            match \u003d [s for s in samples"},{"line_number":221,"context_line":"                     if s.resource_metadata[\u0027parameters\u0027][\u0027ip\u0027] \u003d\u003d ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FWI4%3D","line":218,"updated":"2014-03-18 13:38:51.000000000","message":"The same here","commit_id":"0c05476096ef5e13742b3d90291b6048fbe877f5"}]}