)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"15976540d59380b28a5e569b08007150554cf2a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-sheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-20 19:28:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Show nvalid data string error info of statistics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When getting statistics of a meter with invalid data string in query,"},{"line_number":10,"context_line":"the ceilometer CLI return \u0027HTTPInternalServerError\u0027, it should return the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F%2FFCs%3D","line":7,"updated":"2014-03-20 12:31:50.000000000","message":"s/nvalid/invalid/","commit_id":"bcf2e017e03bc95ff1c8cc477502ea5f9ed1322f"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"50f2b5626c1719bd6f97b78414e6eb44251de581","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        try:"},{"line_number":896,"context_line":"            f \u003d storage.SampleFilter(**kwargs)"},{"line_number":897,"context_line":"        except ValueError as e:"},{"line_number":898,"context_line":"            raise wsme.exc.InvalidInput(\"\u0027start\u0027 or \u0027end\u0027\", e.message)"},{"line_number":899,"context_line":"        g \u003d _validate_groupby_fields(groupby)"},{"line_number":900,"context_line":"        computed \u003d pecan.request.storage_conn.get_meter_statistics(f,"},{"line_number":901,"context_line":"                                                                   period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FFVw%3D","line":898,"updated":"2014-03-20 11:58:32.000000000","message":"The error should not be catched here because they are many other cases where SampleFilter is used.\n\nI prefer to see the method _validate_query improved, so all the API will got the fix not just the statistics.","commit_id":"bcf2e017e03bc95ff1c8cc477502ea5f9ed1322f"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"15976540d59380b28a5e569b08007150554cf2a9","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        try:"},{"line_number":896,"context_line":"            f \u003d storage.SampleFilter(**kwargs)"},{"line_number":897,"context_line":"        except ValueError as e:"},{"line_number":898,"context_line":"            raise wsme.exc.InvalidInput(\"\u0027start\u0027 or \u0027end\u0027\", e.message)"},{"line_number":899,"context_line":"        g \u003d _validate_groupby_fields(groupby)"},{"line_number":900,"context_line":"        computed \u003d pecan.request.storage_conn.get_meter_statistics(f,"},{"line_number":901,"context_line":"                                                                   period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FFCk%3D","line":898,"in_reply_to":"AAAAWH%2F%2FFVw%3D","updated":"2014-03-20 12:31:50.000000000","message":"Yep, the exception string seems far too restrictive.","commit_id":"bcf2e017e03bc95ff1c8cc477502ea5f9ed1322f"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"efb545c5e2cb1673c4146ef7fd099cbc7b7f1706","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        try:"},{"line_number":896,"context_line":"            f \u003d storage.SampleFilter(**kwargs)"},{"line_number":897,"context_line":"        except ValueError as e:"},{"line_number":898,"context_line":"            raise wsme.exc.InvalidInput(\"\u0027start\u0027 or \u0027end\u0027\", e.message)"},{"line_number":899,"context_line":"        g \u003d _validate_groupby_fields(groupby)"},{"line_number":900,"context_line":"        computed \u003d pecan.request.storage_conn.get_meter_statistics(f,"},{"line_number":901,"context_line":"                                                                   period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FFKo%3D","line":898,"in_reply_to":"AAAAWH%2F%2FFVw%3D","updated":"2014-03-20 12:36:11.000000000","message":"thank you, I will try to do that as you said.","commit_id":"bcf2e017e03bc95ff1c8cc477502ea5f9ed1322f"}]}