)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ee94c4cfb67f751c08c7046206af78510111f416","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8c3d887_714e21b9","updated":"2021-11-22 14:45:42.000000000","message":"Thank you for your patch. Before looking deeper, I have an inline question.","commit_id":"5f70309d19a1109617d2c2b2981ee23ce585a58c"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"dfd2ecb97e42a7f86235ca1c512d11466832244e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74bed0be_a2198a5f","in_reply_to":"b8c3d887_714e21b9","updated":"2021-11-22 14:50:33.000000000","message":"Sure, and thanks for your prompt reply here.","commit_id":"5f70309d19a1109617d2c2b2981ee23ce585a58c"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"72c0d20ceea5e6f769ac80addfb909ab90d07b95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40f5a25e_18afb4a6","updated":"2021-12-09 19:25:31.000000000","message":"Thank you for doing this! I really like the idea and see the benefit. I would like to test this before approving it. Please bear with me, I am a little busy at the moment.","commit_id":"0e22799b8d57ca0b87d4cabf0614d930553a0a41"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"586bb514fde89bb151a8e6318b12415f4271da61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72f7c0f3_4eb5a8cb","updated":"2022-01-26 15:33:22.000000000","message":"Hello guys, \nDo we have an update on this patch?","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bed08cfcde3bfbdaeed290d90df1d10047c48ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0e470489_8c2e5224","updated":"2022-02-02 14:47:49.000000000","message":"In general, looks good. What is the reason to change the signatures of the test functions?","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"2a392483fe8f65290a00642a1d71255535b81af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8166ddfd_d97d51b6","updated":"2022-02-08 14:53:38.000000000","message":"Thank you.","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e832ba3057a49a9799b53dbde7964d92e2cdc753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44d7688d_0182e13a","updated":"2022-02-03 10:51:07.000000000","message":"Thanks for the review Matthias!\n\nI have replied to your questions. If you have any other doubt, let me know.","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e832ba3057a49a9799b53dbde7964d92e2cdc753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"93920a61_0a85a186","in_reply_to":"0e470489_8c2e5224","updated":"2022-02-03 10:51:07.000000000","message":"Because of the changes I did in the code. I added an extra parameter to some functions to enable us to re-use all of those methods for the extra metadata gathering process. Therefore, that forced me to change the way the test methods are calling the methods that are being tested.","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"}],"ceilometer/tests/unit/polling/test_non_openstack_dynamic_pollster.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bed08cfcde3bfbdaeed290d90df1d10047c48ad3","unresolved":true,"context_lines":[{"line_number":47,"context_line":"ALL_POLLSTER_FIELDS \u003d REQUIRED_POLLSTER_FIELDS + OPTIONAL_POLLSTER_FIELDS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def fake_sample_multi_metric(self, **kwargs):"},{"line_number":51,"context_line":"    multi_metric_sample_list \u003d ["},{"line_number":52,"context_line":"        {\"user_id\": \"UID-U007\","},{"line_number":53,"context_line":"         \"project_id\": \"UID-P007\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9301e169_e979ee78","line":50,"updated":"2022-02-02 14:47:49.000000000","message":"Any reason for replacing the named parameters with this here?","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e832ba3057a49a9799b53dbde7964d92e2cdc753","unresolved":true,"context_lines":[{"line_number":47,"context_line":"ALL_POLLSTER_FIELDS \u003d REQUIRED_POLLSTER_FIELDS + OPTIONAL_POLLSTER_FIELDS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def fake_sample_multi_metric(self, **kwargs):"},{"line_number":51,"context_line":"    multi_metric_sample_list \u003d ["},{"line_number":52,"context_line":"        {\"user_id\": \"UID-U007\","},{"line_number":53,"context_line":"         \"project_id\": \"UID-P007\","}],"source_content_type":"text/x-python","patch_set":4,"id":"83b038e7_4bc8222f","line":50,"in_reply_to":"9301e169_e979ee78","updated":"2022-02-03 10:51:07.000000000","message":"Yes, because depending on the test, we might have a different number of parameters due to the addition of the \"definitions\" parameter. Therefore, changing the named parameters to \"**kwargs\" was the easiest and simplest way to handle that.","commit_id":"fbb4b6d264c9d24e3f85f891ef765507be1f899a"}],"requirements.txt":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ee94c4cfb67f751c08c7046206af78510111f416","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools\u003c58"},{"line_number":6,"context_line":"cachetools\u003e\u003d2.1.0 # MIT License"},{"line_number":7,"context_line":"cotyledon\u003e\u003d1.3.0 #Apache-2.0"},{"line_number":8,"context_line":"futurist\u003e\u003d1.8.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"83cc0a22_2a56adbb","line":5,"updated":"2021-11-22 14:45:42.000000000","message":"out of curiosity: what is the reason for putting the pin on setuptools here?","commit_id":"5f70309d19a1109617d2c2b2981ee23ce585a58c"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"dfd2ecb97e42a7f86235ca1c512d11466832244e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"setuptools\u003c58"},{"line_number":6,"context_line":"cachetools\u003e\u003d2.1.0 # MIT License"},{"line_number":7,"context_line":"cotyledon\u003e\u003d1.3.0 #Apache-2.0"},{"line_number":8,"context_line":"futurist\u003e\u003d1.8.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"89d3cc04_bb081258","line":5,"in_reply_to":"83cc0a22_2a56adbb","updated":"2021-11-22 14:50:33.000000000","message":"None. I sent this change by mistake.","commit_id":"5f70309d19a1109617d2c2b2981ee23ce585a58c"}]}