)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"8bc09b81f192dd9824a39886851b435dac079ae3","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                if operator \u003d\u003d \u0027eq\u0027:"},{"line_number":391,"context_line":"                    if key \u003d\u003d \u0027enabled\u0027:"},{"line_number":392,"context_line":"                        i._get_value_as_type(\u0027boolean\u0027)"},{"line_number":393,"context_line":"                    elif key \u003d\u003d _is_field_metadata(i.field):"},{"line_number":394,"context_line":"                        i._get_value_as_type()"},{"line_number":395,"context_line":"                else:"},{"line_number":396,"context_line":"                    raise wsme.exc.InvalidInput(\u0027op\u0027, i.op,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B0oY%3D","line":393,"updated":"2014-03-24 01:35:21.000000000","message":"I don\u0027t think this elif clause will ever be ture. Should this be \u0027elif _is_field_metadata(i.field)\u0027?","commit_id":"e2fa1dd141c06cc907e9ece41c64fb2ce2481899"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"c41946f2c0360321b6a95d06020bb947ea9f7f4e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                if operator \u003d\u003d \u0027eq\u0027:"},{"line_number":391,"context_line":"                    if key \u003d\u003d \u0027enabled\u0027:"},{"line_number":392,"context_line":"                        i._get_value_as_type(\u0027boolean\u0027)"},{"line_number":393,"context_line":"                    elif key \u003d\u003d _is_field_metadata(i.field):"},{"line_number":394,"context_line":"                        i._get_value_as_type()"},{"line_number":395,"context_line":"                else:"},{"line_number":396,"context_line":"                    raise wsme.exc.InvalidInput(\u0027op\u0027, i.op,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bzig%3D","line":393,"in_reply_to":"AAAAWH%2F%2B0oY%3D","updated":"2014-03-24 07:31:29.000000000","message":"Good catch, thanks, it will be corrected in the next patch set.","commit_id":"e2fa1dd141c06cc907e9ece41c64fb2ce2481899"}],"ceilometer/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"155df0a92067d89dd7c19ace9bbfb5c8df734a2a","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            }"},{"line_number":464,"context_line":"        }"},{"line_number":465,"context_line":"        resp \u003d self.post_json(\u0027/alarms\u0027, params\u003djson, expect_errors\u003dTrue,"},{"line_number":466,"context_line":"                              status\u003d400, headers\u003dself.auth_headers)"},{"line_number":467,"context_line":"        expected_error_message \u003d \u0027The data type blob is not supported.\u0027"},{"line_number":468,"context_line":"        resp_string \u003d jsonutils.loads(resp.body)"},{"line_number":469,"context_line":"        fault_string \u003d resp_string[\u0027error_message\u0027][\u0027faultstring\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bqh4%3D","line":466,"updated":"2014-03-25 07:42:20.000000000","message":"Would status\u003d[400] be safer to avoid issues for drivers that don\u0027t implement alarms?\n\n(when \u0026 if AssertionError is no longer swallowed by the test-skipping logic)","commit_id":"50cffbc08f24ff8e3935aabecdf4be0fb366116d"}]}
