)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"3c69c4814fb7d89fe1ba6b3e280b89fb26c205fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7614748_8e32108f","updated":"2022-01-10 13:11:16.000000000","message":"Thank you for doing this! \n\nWhile a test may be preferrable, the last change here (with changing the libvirt xml from version 1.0 to 1.1) did not break any existing tests. Again, I would prefer a test, but not having a test wouldn\u0027t make the code worse. This is already an improvement.","commit_id":"190a7c463962ec3da1898ea8396d6400fc3ee13c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e89f01b5aac8c02d3c0a5189b3970ffad7b2b0d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8d0183a_d2c2dbe5","updated":"2022-01-10 12:33:58.000000000","message":"need to add unit tests","commit_id":"190a7c463962ec3da1898ea8396d6400fc3ee13c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8ce1ad751980467e8900edae1aba5e563bb0df30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc8b1072_2afcdbec","updated":"2022-01-21 14:13:42.000000000","message":"Nice work, this should indeed be backported as quickly as possible.","commit_id":"2fc72043d31af7acd45f918eeb290d9d7564d168"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4618a3945f8b592ffb34d44cb59f8ee4208b03b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd7426ed_96cae616","updated":"2022-02-07 08:38:10.000000000","message":"Thank you, makes sense.","commit_id":"2fc72043d31af7acd45f918eeb290d9d7564d168"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"13068ddf167c94c1fd1acd2b1d8b84d1649f3145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7921c4f_08ba486a","updated":"2022-01-11 08:48:46.000000000","message":"fixed some silly typos 😕\n\nstill need to test that logic locally for the upgrade case, and still would like to take a jab at writing unit tests for the new function (might be tricky to emulate proper libvirt domain object with proper XML though...)","commit_id":"2fc72043d31af7acd45f918eeb290d9d7564d168"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3f72941816f918ae16b722d3e8fd560e1f138144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e03a691c_0f19876d","updated":"2022-01-21 13:56:06.000000000","message":"tested upgrade from victoria to wallaby:\n- deployed victoria\n- created instance\n- verified instance metrics are being collected and are present in Gnocchi\n- upgrade to wallaby (that already has I2aa34cf142c6429a7a0a3b8f232c3ed83f7d9981)\n- ceilo-compute logs in Wallaby have errors re failure to parse metadata (because now it expects version 1.1 but instance has 1.0 in its XML)\n- gnocchi does not have new metrics for that instance that was booted in victoria\n- applied this very patch to wallaby, restarted ceilo-compute\n- metrics start to be collected\n- booted another instance (now within Wallaby)\n- metrics from new instance are also successfully collected\n\nPatch seems to work, I\u0027d suggest merging it right away if absence of unit tests is not a big issue, and cherry-pick it to Xena and Wallaby.","commit_id":"2fc72043d31af7acd45f918eeb290d9d7564d168"}]}