)]}'
{"ceilometer/tests/api/v2/test_statistics_scenarios.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"b4b229ffa4cb34582a6b5e3bfa3c8e01aa2cab73","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"        # add a large number of datapoints that won\u0027t impact on cardinality"},{"line_number":1444,"context_line":"        # if the computation logic is tolerant of different DB behavior on"},{"line_number":1445,"context_line":"        # larger numbers of samples per-period"},{"line_number":1446,"context_line":"        for i in xrange(200):"},{"line_number":1447,"context_line":"            s \u003d sample.Sample("},{"line_number":1448,"context_line":"                \u0027instance\u0027,"},{"line_number":1449,"context_line":"                sample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Blu8%3D","line":1446,"updated":"2014-03-25 17:42:06.000000000","message":"This modification in the test here is not enough to cause a test failure with the original code base, so currently the test run does not prove the improvement of modifying the current M-R solution. Please add a proper test case to this change.","commit_id":"e5f5df09e5cdb2e0f5f94daac8e1c5d3ebd55ce9"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e4a80192fadc59879d1e6427706a797a88e13bd9","unresolved":false,"context_lines":[{"line_number":1443,"context_line":"        # add a large number of datapoints that won\u0027t impact on cardinality"},{"line_number":1444,"context_line":"        # if the computation logic is tolerant of different DB behavior on"},{"line_number":1445,"context_line":"        # larger numbers of samples per-period"},{"line_number":1446,"context_line":"        for i in xrange(200):"},{"line_number":1447,"context_line":"            s \u003d sample.Sample("},{"line_number":1448,"context_line":"                \u0027instance\u0027,"},{"line_number":1449,"context_line":"                sample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BlrY%3D","line":1446,"in_reply_to":"AAAAWH%2F%2Blu8%3D","updated":"2014-03-25 17:46:57.000000000","message":"Well spotted, seems the groupby selection throws off the mongo M-R logic enough to avoid the failure I saw kicking in at circa 100 samples per period on devstack.\n\nI\u0027ll add an actually failing test case in the upcoming patch version.","commit_id":"e5f5df09e5cdb2e0f5f94daac8e1c5d3ebd55ce9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"bcd6571d78cb9bf7e76aa1a7c0d9a1d8bdc0ed28","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                \u0027instance\u0027,"},{"line_number":1477,"context_line":"                sample.TYPE_GAUGE,"},{"line_number":1478,"context_line":"                unit\u003d\u0027instance\u0027,"},{"line_number":1479,"context_line":"                volume\u003di * 1.0,"},{"line_number":1480,"context_line":"                user_id\u003d\u0027user-1\u0027,"},{"line_number":1481,"context_line":"                project_id\u003d\u0027project-1\u0027,"},{"line_number":1482,"context_line":"                resource_id\u003d\u0027resource-1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bhlo%3D","line":1479,"updated":"2014-03-26 07:33:25.000000000","message":"The \u0027volume\u0027 of the \u0027instance\u0027 sample is constant 1. To make the test more readable and getting closer to the real life cases, it would be good to set the volume to 1 or use other counters in this test and in the other occurrences also.","commit_id":"6426ca9b11bd29dcf9ef5926fcc51763b84f913e"}]}