)]}'
{"ceilometer/compute/notifications/instance.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"19c561daaa57f0bded711199876211c8865b4b5c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def process_notification(self, message):"},{"line_number":38,"context_line":"        instance_properties \u003d self.get_instance_properties(message)"},{"line_number":39,"context_line":"        if isinstance(instance_properties.get(\u0027metadata\u0027), dict):"},{"line_number":40,"context_line":"            src_metadata \u003d instance_properties[\u0027metadata\u0027]"},{"line_number":41,"context_line":"            del instance_properties[\u0027metadata\u0027]"},{"line_number":42,"context_line":"            util.add_reserved_user_metadata(src_metadata, instance_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F93WY%3D","line":39,"updated":"2014-04-01 15:08:45.000000000","message":"Is there any chance to get a dict embedded in that list in compute.instance.exists or any other event? As in that case this code snippet in this \u0027if\u0027 would still be needed.","commit_id":"f2596964dedaee9cad33aaddfc427781272c74dc"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"e04e65a95fbac2c5c460845b38b90c908944a885","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def process_notification(self, message):"},{"line_number":38,"context_line":"        instance_properties \u003d self.get_instance_properties(message)"},{"line_number":39,"context_line":"        if isinstance(instance_properties.get(\u0027metadata\u0027), dict):"},{"line_number":40,"context_line":"            src_metadata \u003d instance_properties[\u0027metadata\u0027]"},{"line_number":41,"context_line":"            del instance_properties[\u0027metadata\u0027]"},{"line_number":42,"context_line":"            util.add_reserved_user_metadata(src_metadata, instance_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F911Q%3D","line":39,"in_reply_to":"AAAAWH%2F926E%3D","updated":"2014-04-01 18:37:22.000000000","message":"Ok, anyway, if there will be a case like I mentioned, we will fix it, I also could not find an example now. There are periodic tries to figure out something for metadata handling and validation, we will see which one will be the winner.","commit_id":"f2596964dedaee9cad33aaddfc427781272c74dc"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"72c24519844ff5b090436855026fd7de363492a5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def process_notification(self, message):"},{"line_number":38,"context_line":"        instance_properties \u003d self.get_instance_properties(message)"},{"line_number":39,"context_line":"        if isinstance(instance_properties.get(\u0027metadata\u0027), dict):"},{"line_number":40,"context_line":"            src_metadata \u003d instance_properties[\u0027metadata\u0027]"},{"line_number":41,"context_line":"            del instance_properties[\u0027metadata\u0027]"},{"line_number":42,"context_line":"            util.add_reserved_user_metadata(src_metadata, instance_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F926E%3D","line":39,"in_reply_to":"AAAAWH%2F93WY%3D","updated":"2014-04-01 15:59:11.000000000","message":"Well, I haven\u0027t seen case like yours. Quite frankly, I only saw either dict with data, empty dict or empty list (not even list with anything in it), so for now I had no reason to assume that it could be anything different. Problem is that there is no specific schema of data that could land there (or nothing I know of).","commit_id":"f2596964dedaee9cad33aaddfc427781272c74dc"}],"ceilometer/tests/compute/notifications/test_instance.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"f7a062050677c93afb6208f8c161b0b27ef79f95","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                 u\u0027reservation_id\u0027: u\u00271e3ce043029547f1a61c1996d1a531a3\u0027,"},{"line_number":200,"context_line":"                 u\u0027vcpus\u0027: 1,"},{"line_number":201,"context_line":"                 u\u0027root_gb\u0027: 0,"},{"line_number":202,"context_line":"                 u\u0027metadata\u0027: [],"},{"line_number":203,"context_line":"                 u\u0027ephemeral_gb\u0027: 0,"},{"line_number":204,"context_line":"                 u\u0027host\u0027: u\u0027compute-host-name\u0027,"},{"line_number":205,"context_line":"                 u\u0027availability_zone\u0027: u\u00271e3ce043029547f1a61c1996d1a531a4\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BdPc%3D","line":202,"updated":"2014-03-26 16:48:07.000000000","message":"In the actual notification you\u0027re seeing in the wild, is the list actually empty?","commit_id":"f2596964dedaee9cad33aaddfc427781272c74dc"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"5584ab37ad69c6b0a19df597de59aaa53668e5dd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                 u\u0027reservation_id\u0027: u\u00271e3ce043029547f1a61c1996d1a531a3\u0027,"},{"line_number":200,"context_line":"                 u\u0027vcpus\u0027: 1,"},{"line_number":201,"context_line":"                 u\u0027root_gb\u0027: 0,"},{"line_number":202,"context_line":"                 u\u0027metadata\u0027: [],"},{"line_number":203,"context_line":"                 u\u0027ephemeral_gb\u0027: 0,"},{"line_number":204,"context_line":"                 u\u0027host\u0027: u\u0027compute-host-name\u0027,"},{"line_number":205,"context_line":"                 u\u0027availability_zone\u0027: u\u00271e3ce043029547f1a61c1996d1a531a4\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BdAA%3D","line":202,"in_reply_to":"AAAAWH%2F%2BdPc%3D","updated":"2014-03-27 07:58:43.000000000","message":"One I saw was empty, so that might be only case. If that is so, we could only do if metadata. Anyway, now its more bulletproof.","commit_id":"f2596964dedaee9cad33aaddfc427781272c74dc"}]}