)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7134260270c427f266b41fb584298e40d0e2d56b","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        kwargs[\u0027meter\u0027] \u003d self.meter_name"},{"line_number":900,"context_line":"        f \u003d storage.SampleFilter(**kwargs)"},{"line_number":901,"context_line":"        g \u003d _validate_groupby_fields(groupby)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        conn \u003d pecan.request.storage_conn"},{"line_number":904,"context_line":"        computed \u003d conn.get_meter_statistics(f,"},{"line_number":905,"context_line":"                                             period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BT1Q%3D","line":902,"updated":"2014-03-27 17:43:35.000000000","message":"I have one question related to the not exact duplicates like \u0027cardinality/resource_id\u0027, \u0027cardinality/project_id\u0027 that should these really be filtered out or it is just a quick fix now?\n\nIf every duplicated occurrences, like the ones mentioned above, are filtered out, then it would be good to add an error message about this, because now the user gets back less values than expected without any reason. In case two requested \u0027count\u0027 aggregate it\u0027s not really needed, but cardinality is a complex one, therefore it seems to be a different case. Correct me please, if I\u0027m wrong here.","commit_id":"3a5e81f08af22657a0cccbeaf82dfd9958cbc123"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d3927418cc61c5812aa7de65b3cda7c10aa2bf68","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        kwargs[\u0027meter\u0027] \u003d self.meter_name"},{"line_number":900,"context_line":"        f \u003d storage.SampleFilter(**kwargs)"},{"line_number":901,"context_line":"        g \u003d _validate_groupby_fields(groupby)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        conn \u003d pecan.request.storage_conn"},{"line_number":904,"context_line":"        computed \u003d conn.get_meter_statistics(f,"},{"line_number":905,"context_line":"                                             period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BTyk%3D","line":902,"in_reply_to":"AAAAWH%2F%2BT1Q%3D","updated":"2014-03-27 17:47:50.000000000","message":"No, you\u0027re not wrong!\n\nI mulled over rejecting multiple cardinalities, but thought that incosistent with simply discarding multiple unparameterized aggregates such as count.","commit_id":"3a5e81f08af22657a0cccbeaf82dfd9958cbc123"}],"ceilometer/tests/api/v2/test_statistics_scenarios.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"bb9e6470706241c355ba393ef78ad7f75c56c2fc","unresolved":false,"context_lines":[{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"    def test_repeated_unparameterized_aggregate(self):"},{"line_number":1510,"context_line":"        agg_args \u003d {\u0027aggregate.func\u0027: \u0027count\u0027,"},{"line_number":1511,"context_line":"                    \u0027aggregate.func\u0027: \u0027count\u0027}"},{"line_number":1512,"context_line":"        data \u003d self.get_json(self.PATH, **agg_args)"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"        aggregate \u003d \u0027count\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BTJA%3D","line":1511,"updated":"2014-03-27 19:12:45.000000000","message":"Well that was dumb of me!\n\nObviously agg_args is a dict not a list, so the duplicate is dropped from the get go.","commit_id":"3a5e81f08af22657a0cccbeaf82dfd9958cbc123"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"c923fbcc0e46a7d28213aad11283d581a11e0b79","unresolved":false,"context_lines":[{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"    def test_repeated_unparameterized_aggregate(self):"},{"line_number":1510,"context_line":"        agg_args \u003d {\u0027aggregate.func\u0027: \u0027count\u0027,"},{"line_number":1511,"context_line":"                    \u0027aggregate.func\u0027: \u0027count\u0027}"},{"line_number":1512,"context_line":"        data \u003d self.get_json(self.PATH, **agg_args)"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"        aggregate \u003d \u0027count\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BS%2F8%3D","line":1511,"in_reply_to":"AAAAWH%2F%2BTJA%3D","updated":"2014-03-27 19:51:48.000000000","message":"Wow, I spent at least two mins looking at this block, as I had an odd feeling about this, and then I moved forward and I found the final comment and never came back here. Human brain can be funny in the way, how it can ignore obvious things, looking, but not seeing. :S","commit_id":"3a5e81f08af22657a0cccbeaf82dfd9958cbc123"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"bb9e6470706241c355ba393ef78ad7f75c56c2fc","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"        agg_args \u003d {\u0027aggregate.func\u0027: \u0027cardinality\u0027,"},{"line_number":1527,"context_line":"                    \u0027aggregate.param\u0027: \u0027project_id\u0027,"},{"line_number":1528,"context_line":"                    \u0027aggregate.func\u0027: \u0027cardinality\u0027,"},{"line_number":1529,"context_line":"                    \u0027aggregate.param\u0027: \u0027resource_id\u0027}"},{"line_number":1530,"context_line":"        data \u003d self.get_json(self.PATH, **agg_args)"},{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"        aggregate \u003d \u0027cardinality/resource_id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BTI4%3D","line":1529,"updated":"2014-03-27 19:12:45.000000000","message":"Similarly.","commit_id":"3a5e81f08af22657a0cccbeaf82dfd9958cbc123"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"f4dce76780f5c021c3678c369be62c548405ed79","unresolved":false,"context_lines":[{"line_number":1514,"context_line":"        expected_value \u003d 8.0"},{"line_number":1515,"context_line":"        standard_aggregates \u003d set([\u0027min\u0027, \u0027max\u0027, \u0027sum\u0027, \u0027avg\u0027])"},{"line_number":1516,"context_line":"        r \u003d data[0]"},{"line_number":1517,"context_line":"        self.assertIn(aggregate, r)"},{"line_number":1518,"context_line":"        self.assertIn(\u0027aggregate\u0027, r)"},{"line_number":1519,"context_line":"        self.assertIn(aggregate, r[\u0027aggregate\u0027])"},{"line_number":1520,"context_line":"        self.assertEqual(expected_value, r[\u0027aggregate\u0027][aggregate])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BO58%3D","line":1517,"updated":"2014-03-28 08:12:27.000000000","message":"It would be good to check the value of \u0027count\u0027 here too.","commit_id":"41d52567929d6802e94eb8a80aa540ff9169ea70"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"777719e821de8da4d1cca3ca5afa7c335515f4d6","unresolved":false,"context_lines":[{"line_number":1514,"context_line":"        expected_value \u003d 8.0"},{"line_number":1515,"context_line":"        standard_aggregates \u003d set([\u0027min\u0027, \u0027max\u0027, \u0027sum\u0027, \u0027avg\u0027])"},{"line_number":1516,"context_line":"        r \u003d data[0]"},{"line_number":1517,"context_line":"        self.assertIn(aggregate, r)"},{"line_number":1518,"context_line":"        self.assertIn(\u0027aggregate\u0027, r)"},{"line_number":1519,"context_line":"        self.assertIn(aggregate, r[\u0027aggregate\u0027])"},{"line_number":1520,"context_line":"        self.assertEqual(expected_value, r[\u0027aggregate\u0027][aggregate])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BO5Q%3D","line":1517,"in_reply_to":"AAAAWH%2F%2BO58%3D","updated":"2014-03-28 08:15:07.000000000","message":"Well spotted, I\u0027ll fix in the next patch version to be pushed shortly.","commit_id":"41d52567929d6802e94eb8a80aa540ff9169ea70"}]}