)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"0003b8bb9bddbf2629eb680c6fc8d729b2e75b73","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the floatingip pollster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceilometer cannot poll and publish floatingip samples, this is"},{"line_number":10,"context_line":"because of nova and novaclient can only get loatingips belong the"},{"line_number":11,"context_line":"project of current context."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch function depend on following patchs:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F93vo%3D","line":10,"updated":"2014-04-01 15:52:12.000000000","message":"I think there is typo here. Could you correct it?","commit_id":"c2e438c5568902d5da6ad1cb31d2951f7df5ed38"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b91d8d83e8d2813e65ec4bd47c548716a9154dce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the floatingip pollster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceilometer cannot poll and publish floatingip samples, this is"},{"line_number":10,"context_line":"because of nova and novaclient can only get loatingips belong the"},{"line_number":11,"context_line":"project of current context."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch function depend on following patchs:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9zc4%3D","line":10,"in_reply_to":"AAAAWH%2F93vo%3D","updated":"2014-04-02 01:38:57.000000000","message":"thanks a lot","commit_id":"c2e438c5568902d5da6ad1cb31d2951f7df5ed38"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the floatingip pollster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceilometer cannot poll and publish floatingip samples, this is"},{"line_number":10,"context_line":"because nova and novaclient can only get loatingips belonging to the"},{"line_number":11,"context_line":"project of the current context."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F9tWo%3D","line":9,"updated":"2014-04-02 16:48:08.000000000","message":"Not clear message. So after the changes in nova are merged it will be possible to poll if all_tenants is specified, right? Maybe it\u0027s better:\nNova and Novaclient didn\u0027t provide floating ips that don\u0027t belong to the project of the current context.\nAfter merging the following patches it will be possible if parameter all_tenants is enabled.  \nSomething like this.","commit_id":"91981dcdf65f1fd52e04d6b9d677ad0e67dfb93c"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b91d8d83e8d2813e65ec4bd47c548716a9154dce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the floatingip pollster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceilometer cannot poll and publish floatingip samples, this is"},{"line_number":10,"context_line":"because nova and novaclient can only get loatingips belonging to the"},{"line_number":11,"context_line":"project of the current context."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAW3%2F%2Ffb0%3D","line":9,"in_reply_to":"AAAAWH%2F9tWo%3D","updated":"2014-04-14 08:56:38.000000000","message":"thanks done","commit_id":"91981dcdf65f1fd52e04d6b9d677ad0e67dfb93c"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"because Nova and Novaclient didn\u0027t provide floatingips that don\u0027t belong"},{"line_number":11,"context_line":"to the project of the current context."},{"line_number":12,"context_line":"After merging the following patches it will be possible if parameter"},{"line_number":13,"context_line":"all_tenants is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"I7ab1d5ff463fc29928f6811f846c9e204390a412"},{"line_number":16,"context_line":"I4549341badfdb846c03f2828159c46bc4c4a2c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FexQ%3D","line":13,"updated":"2014-04-21 12:54:06.000000000","message":"Am I right that we should wait for all of the following be merged? Or we are ok with nova-client only? Is it released? I\u0027m concerned about capability","commit_id":"f86deea963ab89187d32b9da931d3b0c38e1a130"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b91d8d83e8d2813e65ec4bd47c548716a9154dce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"because Nova and Novaclient didn\u0027t provide floatingips that don\u0027t belong"},{"line_number":11,"context_line":"to the project of the current context."},{"line_number":12,"context_line":"After merging the following patches it will be possible if parameter"},{"line_number":13,"context_line":"all_tenants is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"I7ab1d5ff463fc29928f6811f846c9e204390a412"},{"line_number":16,"context_line":"I4549341badfdb846c03f2828159c46bc4c4a2c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FYpM%3D","line":13,"in_reply_to":"AAAAXH%2F%2FexQ%3D","updated":"2014-04-22 06:55:17.000000000","message":"yes, agree! we should wait for the merging of following patches.","commit_id":"f86deea963ab89187d32b9da931d3b0c38e1a130"}],"ceilometer/nova_client.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @logged"},{"line_number":118,"context_line":"    def floating_ip_get_all(self):"},{"line_number":119,"context_line":"        \"\"\"Returns all floating ips.\"\"\""},{"line_number":120,"context_line":"        return self.nova_client.floating_ips.list(all_tenants\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9tcg%3D","line":119,"updated":"2014-04-02 16:48:08.000000000","message":"Is it possible to mock nova_client in such a way that it returns different list depending on \u0027all_tenants\u0027 parameter? Using this approach you may create a test that checks your fix.","commit_id":"91981dcdf65f1fd52e04d6b9d677ad0e67dfb93c"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @logged"},{"line_number":118,"context_line":"    def floating_ip_get_all(self):"},{"line_number":119,"context_line":"        \"\"\"Returns all floating ips.\"\"\""},{"line_number":120,"context_line":"        return self.nova_client.floating_ips.list(all_tenants\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F9C4%3D","line":119,"in_reply_to":"AAAAWH%2F9tcg%3D","updated":"2014-04-08 09:22:23.000000000","message":"maybe it doesn\u0027t worth it. Mocking nova as I have suggested we will test that mock works but not the code actually","commit_id":"91981dcdf65f1fd52e04d6b9d677ad0e67dfb93c"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b91d8d83e8d2813e65ec4bd47c548716a9154dce","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @logged"},{"line_number":118,"context_line":"    def floating_ip_get_all(self):"},{"line_number":119,"context_line":"        \"\"\"Returns all floating ips.\"\"\""},{"line_number":120,"context_line":"        return self.nova_client.floating_ips.list(all_tenants\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FfcQ%3D","line":119,"in_reply_to":"AAAAWn%2F%2F9C4%3D","updated":"2014-04-14 08:56:38.000000000","message":"agree!,I think the useful unittests should be in novaclient side.","commit_id":"91981dcdf65f1fd52e04d6b9d677ad0e67dfb93c"}]}