)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac18c6d4214fab72568f67567eb1548db01c230d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yadnesh Kulkarni \u003cykulkarn@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-05 09:27:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance polled metrics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add user/project names to the samples before pushing them to the"},{"line_number":10,"context_line":"messaging queue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e9798702_202f4811","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2022-09-06 08:39:16.000000000","message":"(nit) I\u0027d make the title more specific like;\n\nAdd project name and user name to polled metrics\n\nso that people can understand the aim of this change from title.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"310b08c2547fbe436a2f4e0efbb08e15527fda63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yadnesh Kulkarni \u003cykulkarn@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-05 09:27:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance polled metrics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add user/project names to the samples before pushing them to the"},{"line_number":10,"context_line":"messaging queue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"82b7afdb_f5477d87","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"e9798702_202f4811","updated":"2022-09-13 10:03:17.000000000","message":"Done","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"fafa7ca888fb199537459294decc53da33ee9b39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81d92d42_36cb9805","updated":"2022-08-30 06:07:33.000000000","message":"Thank you for doing this!\n\nI agree here with Takashi: could you please take another look at caching? ","commit_id":"75fa379783c86ee29d0992efeeb1e8bd33cda378"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"916b6e4f1182f9148bb06e8a00f03c2747969650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3c487c4_0692048d","updated":"2022-09-06 08:45:48.000000000","message":"Thank you for doing this. Could you please make it configurable though? Even a global switch would be sufficient. When switched off, you\u0027d still have the behavior as in previous ","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac18c6d4214fab72568f67567eb1548db01c230d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f7e4dc4f_3c3e4d83","updated":"2022-09-06 08:39:16.000000000","message":"The overall change looks good to me know. I\u0027ve left a few more suggestions inline.\n\nAlso, I think this is a new feature worth documenting in a release note.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"310b08c2547fbe436a2f4e0efbb08e15527fda63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"074f2aca_48dcf355","in_reply_to":"f7e4dc4f_3c3e4d83","updated":"2022-09-13 10:03:17.000000000","message":"Done","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"7091818ff8bccac6a0868d1715ac8862bedb5837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0287ec11_45ea9b01","updated":"2022-09-19 13:38:36.000000000","message":"After further discussion with Takashi, I have decided to not change the \"user_name\" atrribute to \"username\". It is possible that someone might mistake the variable name \"username\" from the metrics with \"username\" in oslo.context (service_credentials in ceilometer.conf).","commit_id":"79454d6b22787627ae6239aa7b2707101ba30212"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"a0c1fbd29b89e7db73c817d83c0b8f559c1b0949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7331e7cb_793f8b3f","updated":"2022-09-15 16:46:24.000000000","message":"Thank you! Are you going to address Takashi\u0027s comments? user_name vs. username and an import","commit_id":"79454d6b22787627ae6239aa7b2707101ba30212"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b187f394b5e7c7ddf542837874ba301c70d14bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2038b0a2_8ee300a0","updated":"2022-09-30 06:00:08.000000000","message":"recheck","commit_id":"79454d6b22787627ae6239aa7b2707101ba30212"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"05c74563dc21affefb5692e1fb6f7589f1fb96b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7b08d766_d0cdfc36","in_reply_to":"7331e7cb_793f8b3f","updated":"2022-09-16 05:02:16.000000000","message":"I had replied to them in the previous comments. \n\nIt would be better if we make username variable consistent in a different commit as that is not related to the purpose of this change.\n\nAbout the directly importing oslo_cache, having caching operation functions (in cache_utils.py) seems a better approach to me because it avoids some of the repetitve code (eg checking if cache is enabled, using create_region) when oslo_cache is imported directly.","commit_id":"79454d6b22787627ae6239aa7b2707101ba30212"}],"ceilometer/cache_utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a3905997f4c83a342d947b0209591397f1e5a86","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 Red Hat, Inc"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"75d81c0c_5d5e099d","line":1,"updated":"2022-09-05 11:42:51.000000000","message":"There is a similar implementation in ./ceilometer/publisher/gnocchi.py and we might want to refactor that to use this common implementation (later)","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"ced6d6877af1311e2e967d3a8e029db80fc244e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 Red Hat, Inc"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"68e26294_2905bccf","line":1,"in_reply_to":"75d81c0c_5d5e099d","updated":"2022-09-05 13:32:05.000000000","message":"Ack","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a3905997f4c83a342d947b0209591397f1e5a86","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 Red Hat, Inc"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad51bff0_e7a8250d","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2022-09-05 11:42:51.000000000","message":"(nit) 2022","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"ced6d6877af1311e2e967d3a8e029db80fc244e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 Red Hat, Inc"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"77242e66_d555ba81","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"ad51bff0_e7a8250d","updated":"2022-09-05 13:32:05.000000000","message":"Ack","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a3905997f4c83a342d947b0209591397f1e5a86","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\"\"\"Simple wrapper for oslo_cache.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_cache import core as cache"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class CacheClient(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df627d65_dab9c740","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":27},"updated":"2022-09-05 11:42:51.000000000","message":"you can directly import items via oslo_cache, though I guess the current implementation comes from nova.\n\nhttps://github.com/openstack/oslo.cache/blob/master/oslo_cache/__init__.py#L14","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"ced6d6877af1311e2e967d3a8e029db80fc244e7","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\"\"\"Simple wrapper for oslo_cache.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_cache import core as cache"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class CacheClient(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"61adec58_e56f2a4d","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":27},"in_reply_to":"df627d65_dab9c740","updated":"2022-09-05 13:32:05.000000000","message":"Yes, this seems a better approach to me, rather than importing it in the manager.py file. Also, now we can use the same get_client function for the one in gnocchi.py.","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"}],"ceilometer/polling/manager.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63bf220b7114b5c59b4177e3609d566bb1e3b194","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                        if sample.project_id is not None:"},{"line_number":201,"context_line":"                            try:"},{"line_number":202,"context_line":"                                all_projects \u003d self.ks_client.projects"},{"line_number":203,"context_line":"                                sample.project_name \u003d all_projects.get("},{"line_number":204,"context_line":"                                    sample.project_id"},{"line_number":205,"context_line":"                                ).name"},{"line_number":206,"context_line":"                            except ka_exceptions.NotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0118efd2_0ebb0f60","line":203,"range":{"start_line":203,"start_character":32,"end_line":203,"end_character":70},"updated":"2022-08-29 08:57:12.000000000","message":"this requires Keystone api query for every sample, which is quite costly. We might need to consider adding cache mechanism. I see ceilometer already uses oslo_cache for gnocchi publisher so we can extend that here, I guess.","commit_id":"75fa379783c86ee29d0992efeeb1e8bd33cda378"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac18c6d4214fab72568f67567eb1548db01c230d","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                        # Note(yuywz): Unify the timestamp of polled samples"},{"line_number":222,"context_line":"                        sample.set_timestamp(polling_timestamp)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                        # Try to resolve project UUIDs from cache first,"},{"line_number":225,"context_line":"                        # and then keystone"},{"line_number":226,"context_line":"                        if sample.project_id:"},{"line_number":227,"context_line":"                            sample.project_name \u003d self.resolve_uuid_from_cache("}],"source_content_type":"text/x-python","patch_set":5,"id":"3ed0f37a_60883502","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":29},"updated":"2022-09-06 08:39:16.000000000","message":"I agree this is useful for some cases but I\u0027m not sure whether we want to have this any deployment. (Users can still externally resolve name \u003c-\u003e id). Because this can cause performance degradation in a deployment with many projects or users, I\u0027m wondering whether we can make it optional like adding a new option (eg. identity_names_in_samples)","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"310b08c2547fbe436a2f4e0efbb08e15527fda63","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                        # Note(yuywz): Unify the timestamp of polled samples"},{"line_number":222,"context_line":"                        sample.set_timestamp(polling_timestamp)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                        # Try to resolve project UUIDs from cache first,"},{"line_number":225,"context_line":"                        # and then keystone"},{"line_number":226,"context_line":"                        if sample.project_id:"},{"line_number":227,"context_line":"                            sample.project_name \u003d self.resolve_uuid_from_cache("}],"source_content_type":"text/x-python","patch_set":5,"id":"f70eacac_5f258100","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":29},"in_reply_to":"1104aaaf_7b0ac94a","updated":"2022-09-13 10:03:17.000000000","message":"I\u0027ve introduced a new param in ceilometer.conf \"tenant_name_discovery\" which would be set to false by default. There will also be a parameter \"CeilometerTenantNameDiscovery\" to operate this feature using Tripleo.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"916b6e4f1182f9148bb06e8a00f03c2747969650","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                        # Note(yuywz): Unify the timestamp of polled samples"},{"line_number":222,"context_line":"                        sample.set_timestamp(polling_timestamp)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                        # Try to resolve project UUIDs from cache first,"},{"line_number":225,"context_line":"                        # and then keystone"},{"line_number":226,"context_line":"                        if sample.project_id:"},{"line_number":227,"context_line":"                            sample.project_name \u003d self.resolve_uuid_from_cache("}],"source_content_type":"text/x-python","patch_set":5,"id":"6921d9cd_41af3fc7","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":29},"in_reply_to":"3ed0f37a_60883502","updated":"2022-09-06 08:45:48.000000000","message":"I like the idea of making the lookups configurable. Then operators could turn switch it on/off, depending on the load or on the size of the returned data set.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7b43a5ab5f70aac832b875ac91cf2c1eb8869f89","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                        # Note(yuywz): Unify the timestamp of polled samples"},{"line_number":222,"context_line":"                        sample.set_timestamp(polling_timestamp)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                        # Try to resolve project UUIDs from cache first,"},{"line_number":225,"context_line":"                        # and then keystone"},{"line_number":226,"context_line":"                        if sample.project_id:"},{"line_number":227,"context_line":"                            sample.project_name \u003d self.resolve_uuid_from_cache("}],"source_content_type":"text/x-python","patch_set":5,"id":"1104aaaf_7b0ac94a","line":224,"range":{"start_line":224,"start_character":24,"end_line":224,"end_character":29},"in_reply_to":"6921d9cd_41af3fc7","updated":"2022-09-06 08:48:26.000000000","message":"I think the main concern with this new feature is impact on performance/scalability so I think it\u0027s better we keep the feature off until we understand the overall effect of this change.\nAlso, we are quite close to Zed release and this also makes me prefer the safe approach.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"}],"ceilometer/publisher/utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a3905997f4c83a342d947b0209591397f1e5a86","unresolved":true,"context_lines":[{"line_number":126,"context_line":"           \u0027counter_unit\u0027: sample.unit,"},{"line_number":127,"context_line":"           \u0027counter_volume\u0027: sample.volume,"},{"line_number":128,"context_line":"           \u0027user_id\u0027: sample.user_id,"},{"line_number":129,"context_line":"           \u0027user_name\u0027: sample.user_name,"},{"line_number":130,"context_line":"           \u0027project_id\u0027: sample.project_id,"},{"line_number":131,"context_line":"           \u0027project_name\u0027: sample.project_name,"},{"line_number":132,"context_line":"           \u0027resource_id\u0027: sample.resource_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8459a047_5bb28126","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":21},"updated":"2022-09-05 11:42:51.000000000","message":"should we use username to make the naming consistent with context ?","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"ced6d6877af1311e2e967d3a8e029db80fc244e7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"           \u0027counter_unit\u0027: sample.unit,"},{"line_number":127,"context_line":"           \u0027counter_volume\u0027: sample.volume,"},{"line_number":128,"context_line":"           \u0027user_id\u0027: sample.user_id,"},{"line_number":129,"context_line":"           \u0027user_name\u0027: sample.user_name,"},{"line_number":130,"context_line":"           \u0027project_id\u0027: sample.project_id,"},{"line_number":131,"context_line":"           \u0027project_name\u0027: sample.project_name,"},{"line_number":132,"context_line":"           \u0027resource_id\u0027: sample.resource_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9c8cb2b_5f886bac","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":21},"in_reply_to":"8459a047_5bb28126","updated":"2022-09-05 13:32:05.000000000","message":"Done","commit_id":"5c790cf76f867fac5504c12510da534d32adb216"}],"ceilometer/sample.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac18c6d4214fab72568f67567eb1548db01c230d","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    def __init__(self, name, type, unit, volume, user_id, project_id,"},{"line_number":96,"context_line":"                 resource_id, timestamp\u003dNone, resource_metadata\u003dNone,"},{"line_number":97,"context_line":"                 source\u003dNone, id\u003dNone, monotonic_time\u003dNone,"},{"line_number":98,"context_line":"                 user_name\u003dNone, project_name\u003dNone):"},{"line_number":99,"context_line":"        self.name \u003d name"},{"line_number":100,"context_line":"        self.type \u003d type"},{"line_number":101,"context_line":"        self.unit \u003d unit"}],"source_content_type":"text/x-python","patch_set":5,"id":"1644002d_48cd5a29","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":26},"updated":"2022-09-06 08:39:16.000000000","message":"can we use username consistently ?","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"310b08c2547fbe436a2f4e0efbb08e15527fda63","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    def __init__(self, name, type, unit, volume, user_id, project_id,"},{"line_number":96,"context_line":"                 resource_id, timestamp\u003dNone, resource_metadata\u003dNone,"},{"line_number":97,"context_line":"                 source\u003dNone, id\u003dNone, monotonic_time\u003dNone,"},{"line_number":98,"context_line":"                 user_name\u003dNone, project_name\u003dNone):"},{"line_number":99,"context_line":"        self.name \u003d name"},{"line_number":100,"context_line":"        self.type \u003d type"},{"line_number":101,"context_line":"        self.unit \u003d unit"}],"source_content_type":"text/x-python","patch_set":5,"id":"be342429_1f00fe48","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":26},"in_reply_to":"1644002d_48cd5a29","updated":"2022-09-13 10:03:17.000000000","message":"I was thinking of changing it in a different commit.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d523e513299863f4440c29e342077f15e64fdd48","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    def __init__(self, name, type, unit, volume, user_id, project_id,"},{"line_number":96,"context_line":"                 resource_id, timestamp\u003dNone, resource_metadata\u003dNone,"},{"line_number":97,"context_line":"                 source\u003dNone, id\u003dNone, monotonic_time\u003dNone,"},{"line_number":98,"context_line":"                 user_name\u003dNone, project_name\u003dNone):"},{"line_number":99,"context_line":"        self.name \u003d name"},{"line_number":100,"context_line":"        self.type \u003d type"},{"line_number":101,"context_line":"        self.unit \u003d unit"}],"source_content_type":"text/x-python","patch_set":5,"id":"a65b0e66_b4707dba","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":26},"in_reply_to":"be342429_1f00fe48","updated":"2022-09-16 05:36:44.000000000","message":"if we bilieve username is the preferable option then it\u0027s fine. I rechecked oslo.context and noticed it\u0027s using user_name, not username so usage of user_name is something we already have, though it\u0027s different from majority of interface like config options or CLI options.\n\nPlease note that you SHOULD NOT change the attribute name of the Sample class here because it affects resource definition and can cause user impact.","commit_id":"dfdaf8a41267e2297282bcce505aeac7b9465389"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d523e513299863f4440c29e342077f15e64fdd48","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        return cls(name\u003dname,"},{"line_number":133,"context_line":"                   type\u003dtype,"},{"line_number":134,"context_line":"                   volume\u003dvolume,"},{"line_number":135,"context_line":"                   unit\u003dunit,"},{"line_number":136,"context_line":"                   user_id\u003duser_id,"},{"line_number":137,"context_line":"                   project_id\u003dproject_id,"},{"line_number":138,"context_line":"                   resource_id\u003dresource_id,"},{"line_number":139,"context_line":"                   timestamp\u003dts,"},{"line_number":140,"context_line":"                   resource_metadata\u003dmetadata,"}],"source_content_type":"text/x-python","patch_set":10,"id":"59d1cd31_9de7798e","line":137,"range":{"start_line":135,"start_character":29,"end_line":137,"end_character":41},"updated":"2022-09-16 05:36:44.000000000","message":"this can be done in a separate commit but I\u0027m wondering whether we also want to try looking up name attribute from notifications (AFAIR notification include names so you don\u0027t need to resolve names by Keystone API query)","commit_id":"79454d6b22787627ae6239aa7b2707101ba30212"}]}