)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"57594247bb728bda647b5eaa5251b967770dc1df","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Which is what we were doing when we proposed [1]. The problem is that"},{"line_number":17,"context_line":"the sort is happening before that part of the code is executed, to"},{"line_number":18,"context_line":"decide if the sample should be ignored or not."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.opendev.org/c/openstack/ceilometer/+/746717"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a9e2c8d_51d2594c","line":19,"updated":"2022-09-20 14:18:36.000000000","message":"So, you are saying, the other patch should get reverted?","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b4983e5035ba4ce67c4ec5268a0f645cb8e0ecea","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Which is what we were doing when we proposed [1]. The problem is that"},{"line_number":17,"context_line":"the sort is happening before that part of the code is executed, to"},{"line_number":18,"context_line":"decide if the sample should be ignored or not."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.opendev.org/c/openstack/ceilometer/+/746717"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"035c0994_43727197","line":19,"in_reply_to":"5777f765_8c6ea388","updated":"2022-09-21 11:55:10.000000000","message":"Done","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b4983e5035ba4ce67c4ec5268a0f645cb8e0ecea","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Which is what we were doing when we proposed [1]. The problem is that"},{"line_number":17,"context_line":"the sort is happening before that part of the code is executed, to"},{"line_number":18,"context_line":"decide if the sample should be ignored or not."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.opendev.org/c/openstack/ceilometer/+/746717"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8fba865d_2123348d","line":19,"in_reply_to":"5777f765_8c6ea388","updated":"2022-09-21 11:55:10.000000000","message":"Done","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"9cbfb090a89c1aae0a7ac64fcb089849e517448b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Which is what we were doing when we proposed [1]. The problem is that"},{"line_number":17,"context_line":"the sort is happening before that part of the code is executed, to"},{"line_number":18,"context_line":"decide if the sample should be ignored or not."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://review.opendev.org/c/openstack/ceilometer/+/746717"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5777f765_8c6ea388","line":19,"in_reply_to":"9a9e2c8d_51d2594c","updated":"2022-09-20 14:25:59.000000000","message":"No. The other patch was useful. However, in some minor version of Python3 this new issue appeared. And therefore, I am proposing a solution for that here as well. We need both to address the situation now.","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"5993d2b5d40ba5225870118eb3ec2108da0337a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59fa32d2_a65cbf03","updated":"2022-09-12 17:42:47.000000000","message":"It seems to be an untracked bug from python 2 to python 3 migration, thanks for find and fix it.","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"57594247bb728bda647b5eaa5251b967770dc1df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d8dda82_97dc6311","updated":"2022-09-20 14:18:36.000000000","message":"Thank you. \n\nSince this and the other patch somehow try to work around your described issue, would you be able to provide a test for this?","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b4983e5035ba4ce67c4ec5268a0f645cb8e0ecea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f3e3978_8a2e2547","in_reply_to":"7d8dda82_97dc6311","updated":"2022-09-21 11:55:10.000000000","message":"There are a test already for it. It was done when I created the initial patch. However, because the test only had one sample in the list, the bug was not discovered!\n\nI amended the test now.","commit_id":"7aad4e9da7cb4bfba10cb62e8c77f61f0647b5a6"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"2ad8636611fc97437c74e6213f7ed472a0020a9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"586ef115_d7a2fe94","updated":"2022-09-21 12:12:31.000000000","message":"Hi Rafael, I have only a doubt about the test changes.","commit_id":"b7c2c7ca965659255e9a611666e58b024c27d804"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"a67626155dc41643ebffa4193826325a7deb24ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d453021_cf4a6a04","updated":"2022-10-18 06:12:12.000000000","message":"recheck","commit_id":"b7c2c7ca965659255e9a611666e58b024c27d804"}],"ceilometer/tests/unit/publisher/test_gnocchi.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"2ad8636611fc97437c74e6213f7ed472a0020a9d","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        d \u003d gnocchi.GnocchiPublisher(self.conf.conf, url)"},{"line_number":404,"context_line":"        d._already_checked_archive_policies \u003d True"},{"line_number":405,"context_line":"        d.publish_samples(samples)"},{"line_number":406,"context_line":"        self.assertEqual(0, len(fake_batch.call_args[0][1]))"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"class MockResponse(mock.NonCallableMock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"07285e2d_1d2430b6","line":406,"updated":"2022-09-21 12:12:31.000000000","message":"Shouldn\u0027t this assert be changed? Now you have a valid data with a resource_id different from None. I guess to not change this one, you should set the second Sample resource_id as None.","commit_id":"b7c2c7ca965659255e9a611666e58b024c27d804"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8ec3ed74763db618ad94e4dd6e4ea7b204d61366","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        d \u003d gnocchi.GnocchiPublisher(self.conf.conf, url)"},{"line_number":404,"context_line":"        d._already_checked_archive_policies \u003d True"},{"line_number":405,"context_line":"        d.publish_samples(samples)"},{"line_number":406,"context_line":"        self.assertEqual(0, len(fake_batch.call_args[0][1]))"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"class MockResponse(mock.NonCallableMock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef683a53_8bd54d75","line":406,"in_reply_to":"07285e2d_1d2430b6","updated":"2022-09-21 12:17:40.000000000","message":"No. Because the assert is regarding the push/processing of unknown metrics. Both samples have the same \u0027unknown.meter\u0027 metric name. Therefore, both should be ignored.","commit_id":"b7c2c7ca965659255e9a611666e58b024c27d804"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"0eb938816a1cf545b5b3bb4d472bbd84fa9620e8","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        d \u003d gnocchi.GnocchiPublisher(self.conf.conf, url)"},{"line_number":404,"context_line":"        d._already_checked_archive_policies \u003d True"},{"line_number":405,"context_line":"        d.publish_samples(samples)"},{"line_number":406,"context_line":"        self.assertEqual(0, len(fake_batch.call_args[0][1]))"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"class MockResponse(mock.NonCallableMock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"0587ad8d_e99324a4","line":406,"in_reply_to":"ef683a53_8bd54d75","updated":"2022-09-21 12:22:56.000000000","message":"Hmm, got it, thanks.","commit_id":"b7c2c7ca965659255e9a611666e58b024c27d804"}]}