)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ceb78d1a9f60a5bd3c6400661cedd12b930fade","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove redundant try blocks in a row and"},{"line_number":10,"context_line":"replace it with a single try with multiple"},{"line_number":11,"context_line":"catches. This should make the code easier"},{"line_number":12,"context_line":"to read and more pythonic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idb7047297b9e35f236e02c8d9371aa015eda91c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FeOA%3D","line":12,"updated":"2014-04-14 11:49:56.000000000","message":"optional nit: the recommended commit message style suggests keep length of line under 70(80?) characters, so I think no need to be so short here","commit_id":"65e3cf7128727ca543fef673778e866c42418ecf"}],"ceilometer/nova_client.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e89d56d0c21a040c48cfbfa6e2d745cece0fb698","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def _with_image(self, instance):"},{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            iid \u003d instance.image[\u0027id\u0027]"},{"line_number":88,"context_line":"            image \u003d self.nova_client.images.get(iid)"},{"line_number":89,"context_line":"        except TypeError:"},{"line_number":90,"context_line":"            instance.image \u003d None"},{"line_number":91,"context_line":"            instance.kernel_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F8%2BU%3D","line":88,"updated":"2014-04-08 09:29:34.000000000","message":"self.nova_client.images.get(iid) cannot raise TypeError, and instance.image[\u0027id\u0027] cannot raise novaclient.exceptions.NotFound, I don\u0027t see the improvement here.","commit_id":"65e3cf7128727ca543fef673778e866c42418ecf"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"54fa60569bf7fbf985d902f5d7978b5dbde73859","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def _with_image(self, instance):"},{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            iid \u003d instance.image[\u0027id\u0027]"},{"line_number":88,"context_line":"            image \u003d self.nova_client.images.get(iid)"},{"line_number":89,"context_line":"        except TypeError:"},{"line_number":90,"context_line":"            instance.image \u003d None"},{"line_number":91,"context_line":"            instance.kernel_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F6zQ%3D","line":88,"in_reply_to":"AAAAWn%2F%2F8%2BU%3D","updated":"2014-04-08 14:05:59.000000000","message":"The improvement is we dont really need two try\u0027s here. Its more pythonic to have a single try with multiple excepts. I think this helps with readability and style.","commit_id":"65e3cf7128727ca543fef673778e866c42418ecf"}]}
