)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c03ea390753c0a9a6900cd0de849e788caebf0a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if a driver is not able to return samples for a meter_name"},{"line_number":13,"context_line":"it has to return None."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #85999"},{"line_number":16,"context_line":"Change-Id: Id4b2000adc20078631cb8ce1ed7f84fce1a3165d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWn%2F%2F6Ks%3D","line":15,"updated":"2014-04-08 15:10:23.000000000","message":"can you fix this bug? it doesnt\u0027 seem to be right.","commit_id":"ff9168b9688face2f3334cdcf75a2bc5190a8447"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"b75bd9c0e9549f76a5e08fd3fd7b1b4548d3822e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sylvain Afchain \u003csylvain.afchain@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-25 11:36:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check if samples returned by get_sample_data is not None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check if samples return by the method get_sample_data"},{"line_number":10,"context_line":"of a network statistics driver are not None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_37559ec6","line":7,"updated":"2014-04-30 13:11:30.000000000","message":"Please, change \u0027is\u0027 to \u0027are\u0027.","commit_id":"11b3700ff9c0c7828487671df4436cc8d395486a"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"49731ee0afa55d14c42022d6ff21b3c6b1e1dba2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check if samples returned by get_sample_data are not None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check if samples return by the method get_sample_data"},{"line_number":10,"context_line":"of a network statistics driver are not None."},{"line_number":11,"context_line":"As described in the docstring of the abstract method"},{"line_number":12,"context_line":"if a driver is not able to return samples for a meter_name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad9bd40_c2aace18","line":9,"updated":"2014-05-01 20:21:41.000000000","message":"probably \u0027returned\u0027?","commit_id":"ce77627722758bc3876e71bdb96c52e9bc24d03f"}],"ceilometer/network/statistics/__init__.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"37cf504d420eb64522394ba97c7cc2def9ff6dfd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                              params,"},{"line_number":73,"context_line":"                                              cache)"},{"line_number":74,"context_line":"            if sample_data is None:"},{"line_number":75,"context_line":"                continue"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            for data in sample_data:"},{"line_number":78,"context_line":"                if data is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_704ab081","line":75,"updated":"2014-05-01 16:07:33.000000000","message":"I\u0027m not loving this pattern, would it more pythonic to simply change the for loop thusly:\n\n  for data in sample_data or []:\n      ...","commit_id":"ce77627722758bc3876e71bdb96c52e9bc24d03f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"9d482c2fc7e692b4a064f002305888178e4241dd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            sample_data \u003d ext.get_sample_data(self.meter_name,"},{"line_number":71,"context_line":"                                              parse_url,"},{"line_number":72,"context_line":"                                              params,"},{"line_number":73,"context_line":"                                              cache)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            for data in sample_data or []:"},{"line_number":76,"context_line":"                if data is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_e0e17bff","line":73,"updated":"2014-05-02 15:52:28.000000000","message":"Not necessarily a -1, but I usually prefer the or [] when sample_data is set instead of in the for loop. That way if we need to use sample_data for something else, we dont have to redo the None check.\n\nBasically:\nsample_data \u003d ext.get_sample_data(self.meter_name,\n                                                      parse_url,\n                                                      params,\n                                                      cache) or []","commit_id":"91930ca89c6ae6cb583bd63ebf7f153e0fd9fe54"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ac964acc07b5ef62e6a8a6b6c08ffb61c8ca216b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            sample_data \u003d ext.get_sample_data(self.meter_name,"},{"line_number":71,"context_line":"                                              parse_url,"},{"line_number":72,"context_line":"                                              params,"},{"line_number":73,"context_line":"                                              cache)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            for data in sample_data or []:"},{"line_number":76,"context_line":"                if data is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_0a629a3d","line":73,"in_reply_to":"9ad9bd40_e0e17bff","updated":"2014-05-06 20:22:32.000000000","message":"well, personally I love the \"or []\" in the variable definition too, but that\u0027s not the big deal here.... Anyway, I\u0027d love to see it in the definition (not in the loop header) too","commit_id":"91930ca89c6ae6cb583bd63ebf7f153e0fd9fe54"}],"ceilometer/tests/network/statistics/test_statistics.py":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"b75bd9c0e9549f76a5e08fd3fd7b1b4548d3822e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                return None"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._setup_ext_mgr(http\u003dNoneFakeDriver())"},{"line_number":186,"context_line":"        self._get_samples(\u0027http://foo\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_f7c9765b","line":186,"updated":"2014-04-30 13:11:30.000000000","message":"\u003e\u003eAs described in the docstring of the abstract method\tif a driver is not able to return samples for a meter_name it has to return None.\n\nPossibly, there is correct to check what get_samples returns None?","commit_id":"11b3700ff9c0c7828487671df4436cc8d395486a"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"c08143962c7cec5c3f50aa1bb6825b48de8f7bfa","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                return None"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._setup_ext_mgr(http\u003dNoneFakeDriver())"},{"line_number":186,"context_line":"        self._get_samples(\u0027http://foo\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_ba58b3fb","line":186,"in_reply_to":"9ad9bd40_f7c9765b","updated":"2014-04-30 13:28:11.000000000","message":"get_samples will never return None since it is a generator. I will add something to check that the list returned by _get_samples is empty. The purpose of the test is to check that there is no expection raised when get_sample_data returns None .","commit_id":"11b3700ff9c0c7828487671df4436cc8d395486a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d1c07a00c4791933455dcbfff466d87948024215","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._setup_ext_mgr(http\u003dNoneFakeDriver())"},{"line_number":186,"context_line":"        samples \u003d self._get_samples(\u0027http://foo\u0027)"},{"line_number":187,"context_line":"        self.assertFalse(samples)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_7908cbd9","line":187,"updated":"2014-05-22 12:49:16.000000000","message":"use assertIsNone rather than assertFalse to confirm if samples really is None instead of 0","commit_id":"91930ca89c6ae6cb583bd63ebf7f153e0fd9fe54"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"f5eb0740cc1c7309284e96f9b709518d4e32d010","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._setup_ext_mgr(http\u003dNoneFakeDriver())"},{"line_number":186,"context_line":"        samples \u003d self._get_samples(\u0027http://foo\u0027)"},{"line_number":187,"context_line":"        self.assertFalse(samples)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_d9a2bf99","line":187,"in_reply_to":"7adec928_7908cbd9","updated":"2014-05-22 12:53:53.000000000","message":"the _get_samples function returns a list, so samples can\u0027t be None, and the self.pollster.get_samples is a generator.","commit_id":"91930ca89c6ae6cb583bd63ebf7f153e0fd9fe54"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"892d26394473d5371f48a5b133b5fcd8d6472c3d","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._setup_ext_mgr(http\u003dNoneFakeDriver())"},{"line_number":186,"context_line":"        samples \u003d self._get_samples(\u0027http://foo\u0027)"},{"line_number":187,"context_line":"        self.assertFalse(samples)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_79bfeb60","line":187,"in_reply_to":"7adec928_d9a2bf99","updated":"2014-05-22 13:02:58.000000000","message":"oh... i misunderstood commit message","commit_id":"91930ca89c6ae6cb583bd63ebf7f153e0fd9fe54"}]}