)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"5ee980eb75414214ee245a6fa786b935a6446396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59d55877_bf7857a1","updated":"2022-12-05 07:55:38.000000000","message":"I tried building sg-core with tcp socket plugin commits and added it as a TCP publisher in ceilometer. I can see sg-core receiving periodic messages.","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9feffbec1fa581b5a4d7dc26bfc9ade42e300898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56705a5d_78df9c8b","updated":"2022-12-06 07:37:41.000000000","message":"Minor tweaks, but in general looks good to me. Thank you Jaromir!","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"896877761cc84a4c3a7f22e00402943c2466690f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d634ef67_ced409d9","updated":"2022-12-14 04:34:39.000000000","message":"Could be a race condition\n```\n{2} telemetry_tempest_plugin.scenario.test_gnocchi.GnocchiGabbiTest.test_live [1.308949s] ... FAILED\nAssertionError: From test \"missing auth archive policy rule\" :\n\n\nDec 07 17:11:04.513712 centos-9-stream-inmotion-iad3-0032436275 devstack@gnocchi-api.service[112075]: 2022-12-07 17:11:04,513 [112075] DEBUG    gnocchi.rest.api: Aborting request. Code [400]. Details [Archive policy gabbiliveceph is still in use]\n```","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"a1cebbacd29475e163365ac776e5232b88ae86cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f304609d_e7c8d5ed","updated":"2022-12-14 04:34:51.000000000","message":"recheck","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"cfc7f0ef45e3c2e2ffc101fa17066ddbd628c0ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"956f2944_9027732b","in_reply_to":"76eb3c8b_2253a603","updated":"2023-01-16 22:37:37.000000000","message":"Ack","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"8624463e8e2f0ed9b2dc80559f756651212b4386","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76eb3c8b_2253a603","in_reply_to":"8eca8db2_55b316aa","updated":"2023-01-16 04:14:02.000000000","message":"I think there\u0027s some misunderstanding here. After you uploaded patch set 3, zuul failed with \"missing auth archive policy rule\". I never claimed it failed because of this patch. After which I triggered recheck and all the zuul tests were executed successfully. \n\nAlso, tempest does create the archive policy gabbiliveceph [1]\n\nAs of now this patch has zuul +1 so there\u0027s nothing needed from you. Core reviewers would take a look and suggest further.\n\n[1] https://github.com/openstack/telemetry-tempest-plugin/blob/master/telemetry_tempest_plugin/scenario/telemetry_integration_gabbits/aodh-gnocchi-threshold-alarm.yaml#L20-L40","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"031442d64f9baa405f0ef31dab34f224801a4ee1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8eca8db2_55b316aa","in_reply_to":"d634ef67_ced409d9","updated":"2023-01-13 23:03:14.000000000","message":"Unfortunately the artifacts aren\u0027t available on zuul anymore, but based on what you copied here and based on what I read in the tests. It looks to me like the tests are just trying to make a bunch of requests for the gnocchi rest api. Quite a few of the requests succeed, until this one fails for some reason, but I don\u0027t see a connection to this patch. Also I don\u0027t think these 2 logs are related, the test tries to create an archive policy called \"low\", not \"gabbiliveceph\".\n\nIt seems weird to me, that the CI should fail like this, as far as I know, the only tests for the tcp publisher right now are the unit tests in this patch and they succeeded. The telemetry-dvsm-integration-centos-9s-fips shouldn\u0027t even touch the publisher. So I\u0027m not really sure what to do now.","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f060be9481a743a08ec21885c0f164a881a168c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b168280e_0f9c2e43","updated":"2023-01-16 07:17:19.000000000","message":"Thank you, this looks good to me now.","commit_id":"ed55b5f4a4933e0e5d986b0da23239ebcc7d9f77"}],"ceilometer/publisher/tcp.py":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"5ee980eb75414214ee245a6fa786b935a6446396","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb5f626_a6c20f6a","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":25},"updated":"2022-12-05 07:55:38.000000000","message":"Copyright 2022 Red Hat, Inc","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"fbacd4425b2884aa24867c97b0bcc1dec9781b8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd31d55b_f7047522","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":25},"in_reply_to":"9fb5f626_a6c20f6a","updated":"2022-12-07 16:29:38.000000000","message":"Done","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"5ee980eb75414214ee245a6fa786b935a6446396","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.socket.send(msg_len + encoded_msg)"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                LOG.warning(_(\"Unable to send sample over TCP,\""},{"line_number":81,"context_line":"                              \"trying to reconnect and resend the message\"))"},{"line_number":82,"context_line":"                self.create_and_connect()"},{"line_number":83,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8a5ad3b_1f0df60a","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":27},"updated":"2022-12-05 07:55:38.000000000","message":"It would be better to see these get raised as exceptions and not warnings.","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"fbacd4425b2884aa24867c97b0bcc1dec9781b8e","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.socket.send(msg_len + encoded_msg)"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                LOG.warning(_(\"Unable to send sample over TCP,\""},{"line_number":81,"context_line":"                              \"trying to reconnect and resend the message\"))"},{"line_number":82,"context_line":"                self.create_and_connect()"},{"line_number":83,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5705602_10ca6cce","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":27},"in_reply_to":"d8a5ad3b_1f0df60a","updated":"2022-12-07 16:29:38.000000000","message":"I don\u0027t think the first warning is a big deal. The warning means, that there was some issue before, that\u0027s why the socket disconnected, but the issue might be gone already. If the issue is still present, the second warning would trigger, which means there is a problem and some action might be required. So I left the first warning as a warning and rewrote the second warning to an exception.","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"4688fa0397d0d8cd404240253703708080ae450d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.socket.send(msg_len + encoded_msg)"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                LOG.warning(_(\"Unable to send sample over TCP,\""},{"line_number":81,"context_line":"                              \"trying to reconnect and resend the message\"))"},{"line_number":82,"context_line":"                self.create_and_connect()"},{"line_number":83,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f42cda4_e0ad7f78","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":27},"in_reply_to":"e5705602_10ca6cce","updated":"2022-12-07 16:32:59.000000000","message":"Sounds good!","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"}],"ceilometer/tests/unit/publisher/test_tcp.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9feffbec1fa581b5a4d7dc26bfc9ade42e300898","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013-2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"2303d165_01858e0f","line":2,"updated":"2022-12-06 07:37:41.000000000","message":"Copyright 2022 Red Hat, you can also completely leave out the copyright notice. You should keep the apache license.","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"fbacd4425b2884aa24867c97b0bcc1dec9781b8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013-2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"afc9a3e3_b87e248e","line":2,"in_reply_to":"2303d165_01858e0f","updated":"2022-12-07 16:29:38.000000000","message":"Done","commit_id":"f7962d2c300506b832247b6c16d8ef128dbed6a8"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"69032a01c74de5c0deac093d48290021be03d6b2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013-2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9bb1c11_b135a6f2","line":2,"updated":"2022-12-14 07:30:14.000000000","message":"did you miss this copyright message?","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"45253d29effaa334b2fda008c1f403ecec696ca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013-2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c434171_4903b03e","line":2,"in_reply_to":"3c22d0fe_824309ff","updated":"2023-01-13 23:11:47.000000000","message":"Done","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"031442d64f9baa405f0ef31dab34f224801a4ee1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013-2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c22d0fe_824309ff","line":2,"in_reply_to":"a9bb1c11_b135a6f2","updated":"2023-01-13 23:03:14.000000000","message":"Seems like it, sorry.","commit_id":"a7912cedd5526f5e46c214cb74b335547738ca3a"}]}