)]}'
{"id":"openstack%2Fceilometer~878129","triplet_id":"openstack%2Fceilometer~stable%2Fyoga~Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a","project":"openstack/ceilometer","branch":"stable/yoga","topic":"fix-processing_of_event_metrics_that_do_not_have_Resource-id","attention_set":{},"removed_from_attention_set":{"6737":{"account":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"last_update":"2023-05-10 20:02:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a","subject":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher","status":"MERGED","created":"2023-03-21 16:25:15.000000000","updated":"2023-05-10 20:04:22.000000000","submitted":"2023-05-10 20:02:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"878129-fix-processing_of_event_metrics_that_do_not_have_Resource-id","meta_rev_id":"51ba2e4fbb7e3d78f33304c322967df43ecbf6db","_number":878129,"virtual_id_number":878129,"owner":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},{"value":0,"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-10 20:02:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"all":[{"value":0,"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},{"value":0,"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":2,"date":"2023-05-09 06:33:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":1,"date":"2023-05-10 18:26:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"all":[{"value":0,"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},{"value":0,"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":1,"date":"2023-05-10 19:00:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"}],"REVIEWER":[{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-21 16:25:15.000000000","updated_by":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"CC"},{"updated":"2023-03-21 17:02:20.000000000","updated_by":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"REVIEWER"},{"updated":"2023-03-21 17:20:46.000000000","updated_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"reviewer":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"state":"REVIEWER"},{"updated":"2023-03-21 17:38:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-28 14:20:43.000000000","updated_by":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"CC"},{"updated":"2023-05-10 18:26:22.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"f11d093642d0fbc90d0caab6a5d044316422519f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-03-21 16:25:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41765718918cfbc66b478e0b744e6315231f646b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-03-21 16:25:43.000000000","message":"Topic set to fix-processing_of_event_metrics_that_do_not_have_Resource-id","accounts_in_message":[],"_revision_number":1},{"id":"62c29aca96546556596d512406c2dd3dff13b43b","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-03-21 17:02:20.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"65e667701c11e5a1c4515eaba5d674d77c8b6b2e","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2023-03-21 17:20:46.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c2bf4f21ecf1d1314a32d2dce41ec223a247a86","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-21 17:38:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8f34b18859d140b7ab61d840811ecc32\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/360a196f7bbc4c5c86363d75aba4cd30 : SUCCESS in 5m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ae88e4d5e8764caa9bcbae4f01f82b93 : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6e2dcf54b9034ee393ba6a1008410924 : SUCCESS in 6m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ab263cc63b1f4222895db5365aa6539f : SUCCESS in 7m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c31759e980434f668f47bb6a1bf1f417 : SUCCESS in 6m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/22bd0ed7b036407fac01a627885323e8 : SUCCESS in 6m 55s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/a18e2de719f140acb2e77225c177d22f : FAILURE in 52m 57s (non-voting)\n- telemetry-dsvm-integration-centos-8s https://zuul.opendev.org/t/openstack/build/677b7ab95c01492e80a4e1d990d54c24 : SUCCESS in 1h 02m 33s\n- telemetry-dsvm-integration-centos-8s-fips https://zuul.opendev.org/t/openstack/build/c1e7934f51ad4e4691b11d9b9f23b26c : SUCCESS in 1h 04m 39s\n- telemetry-dsvm-integration-centos-9s https://zuul.opendev.org/t/openstack/build/44c1134bc73a4ca0b5ad7acbda9d5927 : SUCCESS in 1h 05m 10s\n- telemetry-dsvm-integration-centos-9s-fips https://zuul.opendev.org/t/openstack/build/c3e0d554eddb4270861356db9b687b6e : SUCCESS in 56m 34s\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/950a770fc0aa4848840c6cc037cf217f : SUCCESS in 58m 07s\n- telemetry-dsvm-integration-ipv6-only https://zuul.opendev.org/t/openstack/build/00e60dec600f4758a63855dc55e81f00 : SUCCESS in 48m 08s","accounts_in_message":[],"_revision_number":1},{"id":"82a0d310030fbb4efd509bcf70b231614d30be2a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-03-28 14:20:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"16f19cbaf9fa0b37e182753e8477fc31d0e4d53e","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-03-28 14:22:01.000000000","message":"Patch Set 2: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"daddecc210e4de1bcb1d74560df199601e6b176b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-28 14:34:21.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/44dba5f48de442fb87dc1f31c25363f3\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/64ff18bbad5b4d619b3b94a9549d9199 : FAILURE in 6m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32a32a7211d24da684735225cc94c19b : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/25ac76bbf2f143e5bcf8b9f96edcebe0 : FAILURE in 6m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/67b8cd15f9e940d18f67da189ca6957e : FAILURE in 6m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e94be845b2094a5391ee45e4c28aed18 : SUCCESS in 6m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d54db5ceb7ba4326b49f9eceed8b3bf0 : FAILURE in 7m 00s","accounts_in_message":[],"_revision_number":2},{"id":"956bd74bc2d5806b122501f85e2adbad7592ad98","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-05-04 13:14:31.000000000","message":"Patch Set 2: -Workflow\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"405684b1fa321ae5a75324d945061bd9b1c66f94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2023-05-04 13:16:26.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":3},{"id":"5ec22d096e362438dca2f4bb2ae4c80cb73326cb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-04 13:39:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/381b79c94e3b49ad8747641e07bf0d67\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d8b1bb1d026e4681a819cac42a4d6faf : SUCCESS in 7m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6711c63e060148b89522b25e0fe10129 : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ca011694c3134fa3922493fb22306991 : SUCCESS in 5m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d5dd566fc11d47e8803620ff8df09528 : SUCCESS in 6m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0d24332eda8641888e43064f727e7324 : SUCCESS in 6m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d286ddb54af044d9bf468dbbe0f536e3 : SUCCESS in 6m 58s","accounts_in_message":[],"_revision_number":3},{"id":"a1b1c8af6e4da01673706f17d7f986c6a973961b","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2023-05-09 06:33:26.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8a9f67d895b1e47b41c528945984caa0e27cb994","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2023-05-10 18:26:22.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"7885af8c501706f41b92b6719b3b4dc1448db3a4","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2023-05-10 19:00:19.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"890e404c67d893e1ca6eaaea06ba61af34c33684","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 19:00:40.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"8f4f38562bbc40aef08e7a6631f40ca5cd9f3e03","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 20:02:41.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/31071d9405c84b398b9ae1a2a2008e99\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b955d1e7c425449f97a51f62fc43d2ea : SUCCESS in 3m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/63cad5d457ad49bdaef52e1d26cf4eb4 : SUCCESS in 5m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/69509f682b9e4c6e8caeab09c7715244 : SUCCESS in 6m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/94fbef9d31414455b754febc0b6fb19e : SUCCESS in 5m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/891c4cb700d045558a862a023eb38f38 : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":3},{"id":"a035d2c51b383ff62b122b879708ac132c89def8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 20:02:41.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"51ba2e4fbb7e3d78f33304c322967df43ecbf6db","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-10 20:04:22.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7b71668bb6644f95812642fd8731f3da\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7e59f1a8c7d849e5ae4834ceebab341a : SUCCESS in 36s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7d9e167da040d1e30aa2cd25d80aa751635212f2","revisions":{"dd4e862d59e0be9c79eaa5fc4328790173dd2dff":{"kind":"REWORK","_number":1,"created":"2023-03-21 16:25:15.000000000","uploader":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"ref":"refs/changes/29/878129/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/29/878129/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/1"}}},"commit":{"parents":[{"commit":"9f6481163c3d86c6b38578a2fef8c6bdd29ae463","subject":"Merge \"Add centos9s jobs\" into stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9f6481163c3d86c6b38578a2fef8c6bdd29ae463"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2022-09-11 20:02:11.000000000","tz":-180},"committer":{"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","date":"2023-03-21 16:25:08.000000000","tz":0},"subject":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher","message":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher\n\nThis issue is related to [1]. In Python 3 (I did not check exactly in\nwhich version), the following code was throwing an error\n`data.sort(key\u003doperator.attrgetter(\u0027resource_id\u0027))`. Therefore, this\npatch is proposing a solution for such situations to properly handle\nsamples where the `resource_id` is None. Of course, `resource_id`\ncannot be None in Gnocchi. However, that can be properly handled by\nremoving the metric to be pushed from the `gnocchi_resource.yml` file.\nWhich is what we were doing when we proposed [1]. The problem is that\nthe sort is happening before that part of the code is executed, to\ndecide if the sample should be ignored or not.\n\n[1] https://review.opendev.org/c/openstack/ceilometer/+/746717\n\nChange-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a\n(cherry picked from commit b7c2c7ca965659255e9a611666e58b024c27d804)\n(cherry picked from commit 81d48387dd23ad7d2b7f066461aff5b27ebbc155)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/dd4e862d59e0be9c79eaa5fc4328790173dd2dff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/dd4e862d59e0be9c79eaa5fc4328790173dd2dff"}]},"branch":"refs/heads/stable/yoga"},"be730cd36ca6693c74ddca93acaaa3aeeac26986":{"kind":"REWORK","_number":2,"created":"2023-03-28 14:20:43.000000000","uploader":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"ref":"refs/changes/29/878129/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/29/878129/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/2"}}},"commit":{"parents":[{"commit":"9f6481163c3d86c6b38578a2fef8c6bdd29ae463","subject":"Merge \"Add centos9s jobs\" into stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9f6481163c3d86c6b38578a2fef8c6bdd29ae463"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2022-09-11 20:02:11.000000000","tz":-180},"committer":{"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","date":"2023-03-28 14:20:31.000000000","tz":60},"subject":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher","message":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher\n\nThis issue is related to [1]. In Python 3 (I did not check exactly in\nwhich version), the following code was throwing an error\n`data.sort(key\u003doperator.attrgetter(\u0027resource_id\u0027))`. Therefore, this\npatch is proposing a solution for such situations to properly handle\nsamples where the `resource_id` is None. Of course, `resource_id`\ncannot be None in Gnocchi. However, that can be properly handled by\nremoving the metric to be pushed from the `gnocchi_resource.yml` file.\nWhich is what we were doing when we proposed [1]. The problem is that\nthe sort is happening before that part of the code is executed, to\ndecide if the sample should be ignored or not.\n\n[1] https://review.opendev.org/c/openstack/ceilometer/+/746717\n\nChange-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a\n(cherry picked from commit b7c2c7ca965659255e9a611666e58b024c27d804)\n(cherry picked from commit 5968c822bebbaa47ef71d56abb4b7c2bd41fa7b9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/be730cd36ca6693c74ddca93acaaa3aeeac26986"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/be730cd36ca6693c74ddca93acaaa3aeeac26986"}]},"branch":"refs/heads/stable/yoga"},"7d9e167da040d1e30aa2cd25d80aa751635212f2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-05-04 13:16:26.000000000","uploader":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"ref":"refs/changes/29/878129/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/29/878129/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/29/878129/3"}}},"commit":{"parents":[{"commit":"ebeae1540aa512f7dda1f667051b48123a272148","subject":"Merge \"Add vanity names to telemetry polling notifications\" into stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/ebeae1540aa512f7dda1f667051b48123a272148"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2022-09-11 20:02:11.000000000","tz":-180},"committer":{"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","date":"2023-05-04 13:16:10.000000000","tz":60},"subject":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher","message":"Properly handle \u0027resource_id\u0027 as None for Gnocchi publisher\n\nThis issue is related to [1]. In Python 3 (I did not check exactly in\nwhich version), the following code was throwing an error\n`data.sort(key\u003doperator.attrgetter(\u0027resource_id\u0027))`. Therefore, this\npatch is proposing a solution for such situations to properly handle\nsamples where the `resource_id` is None. Of course, `resource_id`\ncannot be None in Gnocchi. However, that can be properly handled by\nremoving the metric to be pushed from the `gnocchi_resource.yml` file.\nWhich is what we were doing when we proposed [1]. The problem is that\nthe sort is happening before that part of the code is executed, to\ndecide if the sample should be ignored or not.\n\n[1] https://review.opendev.org/c/openstack/ceilometer/+/746717\n\nChange-Id: Ie8eb42df3d5b9505160c9e9d6b86bdaa9a02d16a\n(cherry picked from commit b7c2c7ca965659255e9a611666e58b024c27d804)\n(cherry picked from commit 5968c822bebbaa47ef71d56abb4b7c2bd41fa7b9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/7d9e167da040d1e30aa2cd25d80aa751635212f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/7d9e167da040d1e30aa2cd25d80aa751635212f2"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
