)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"faf54379c741d172f8b84cad3c0e6a561ad40ee4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d8bb48b_563eddb7","updated":"2023-04-11 17:00:57.000000000","message":"Currently, the TCP publisher fails to start if ceilometer is started before the receiving endpoint. That means, that no metrics will get sent until the notification agent is restarted. This patch changes the behavior from throwing an exception and failing to outputting a warning message and continuing. The publisher will try to reconnect in the publish_samples function with each new metric, which is the same behavior like losing a connection during normal operation.","commit_id":"a1e3b0c194d1433601d3d31168cc2060e8b818e2"}],"ceilometer/publisher/tcp.py":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"fdc42b2e95cba796bd85fe540d5fb412266eb036","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            self.create_and_connect()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            LOG.warning(_(\"Unable to connect to the \""},{"line_number":58,"context_line":"                          \"remote endpoint\"))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_and_connect(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e429b6b4_042fb2bf","line":57,"updated":"2023-04-12 05:30:15.000000000","message":"Should we log this as error instead of warning ? If the publisher cannot connect to the target address and port, the samples wouldn\u0027t be delivered to the other end. This sort of issue should attract more attention than just a warning. \n\nIt would also be helpful if we changed other warnings in TCP publisher to errors.","commit_id":"a1e3b0c194d1433601d3d31168cc2060e8b818e2"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"5e22dd21a3ab5f71418c2748b336753abc11c2f7","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            self.create_and_connect()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            LOG.warning(_(\"Unable to connect to the \""},{"line_number":58,"context_line":"                          \"remote endpoint\"))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_and_connect(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9e7f27a_8c73f2f6","line":57,"in_reply_to":"b3ff9522_2818d6fb","updated":"2023-04-18 05:33:13.000000000","message":"Thank you, if you could make the messae an error message, this is good to go.","commit_id":"a1e3b0c194d1433601d3d31168cc2060e8b818e2"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"47a17edc2d9d67fab8bdeac2bcee850d8b7d9c44","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            self.create_and_connect()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            LOG.warning(_(\"Unable to connect to the \""},{"line_number":58,"context_line":"                          \"remote endpoint\"))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_and_connect(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3ff9522_2818d6fb","line":57,"in_reply_to":"e429b6b4_042fb2bf","updated":"2023-04-13 06:44:06.000000000","message":"You are right. I made it a warning here, because I wanted to be consistent with the other warnings. Also this warning would get logged in a situation, where the ceilometer is started before the receiving endpoint, which isn\u0027t a big deal.\n\nBut I agree, that this could indicate some bigger issues and having errors here instead of warnings seems a bit more appropriate.","commit_id":"a1e3b0c194d1433601d3d31168cc2060e8b818e2"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff449094cbd4c1606b3ac83069ee0ed73cc607a2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            self.create_and_connect()"},{"line_number":56,"context_line":"        except Exception:"},{"line_number":57,"context_line":"            LOG.warning(_(\"Unable to connect to the \""},{"line_number":58,"context_line":"                          \"remote endpoint\"))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_and_connect(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1db43de6_4fd73dd1","line":57,"in_reply_to":"f9e7f27a_8c73f2f6","updated":"2023-04-24 12:30:32.000000000","message":"Done","commit_id":"a1e3b0c194d1433601d3d31168cc2060e8b818e2"}]}