)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0933a283872a5c07b4d8aaea620fd41c339aec2d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c902a43b_2ab13d78","updated":"2024-10-23 05:45:07.000000000","message":"A few suggestions inline. Also this is a new feature so we need a release note.","commit_id":"585651ec77589487156137cf648c15c62dd9d885"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"47953ca55187aa288762e77d032f7bd2cbaa9030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"045fa875_19c0bb6f","updated":"2023-05-26 08:50:05.000000000","message":"recheck","commit_id":"585651ec77589487156137cf648c15c62dd9d885"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"4954d1c44f7b4c981149f85ea82a44122dfa552b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"053586a8_71ab5516","updated":"2024-10-04 08:53:30.000000000","message":"recheck","commit_id":"585651ec77589487156137cf648c15c62dd9d885"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"e6c95d68b59a1f95a055a4766bfa0141f482301d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59d42c85_11232651","updated":"2023-08-07 08:26:21.000000000","message":"recheck","commit_id":"585651ec77589487156137cf648c15c62dd9d885"}],"ceilometer/publisher/messaging.py":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"9ebf5eb58341b752e31fdb887e89689a0e05a1a5","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _send(self, event_type, data):"},{"line_number":258,"context_line":"        try:"},{"line_number":259,"context_line":"            with eventlet.timeout.Timeout(self.notifier_timeoutt):"},{"line_number":260,"context_line":"                self.notifier.sample({}, event_type\u003devent_type,"},{"line_number":261,"context_line":"                                     payload\u003ddata)"},{"line_number":262,"context_line":"        except oslo_messaging.MessageDeliveryFailure as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"198ca3c5_e61849f0","line":259,"range":{"start_line":259,"start_character":47,"end_line":259,"end_character":64},"updated":"2023-05-19 10:19:36.000000000","message":"looks like a typo - timeoutt","commit_id":"a2d13b7848815408968ec61d95739b703352774c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0933a283872a5c07b4d8aaea620fd41c339aec2d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"import operator"},{"line_number":21,"context_line":"import threading"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import eventlet"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":"import oslo_messaging"}],"source_content_type":"text/x-python","patch_set":4,"id":"77f8249a_ff91d942","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":15},"updated":"2024-10-23 05:45:07.000000000","message":"eventlet is not actually used in ceilometer and we are trying to get rid of it so please DO NOT use it.","commit_id":"585651ec77589487156137cf648c15c62dd9d885"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0933a283872a5c07b4d8aaea620fd41c339aec2d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"               \u0027notifications.\u0027,"},{"line_number":56,"context_line":"               deprecated_name\u003d\u0027metering_driver\u0027,"},{"line_number":57,"context_line":"               ),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027notifier_timeout\u0027,"},{"line_number":59,"context_line":"               default\u003d5,"},{"line_number":60,"context_line":"               help\u003d\u0027Timeout in seconds when publishing events.\u0027,"},{"line_number":61,"context_line":"               )"}],"source_content_type":"text/x-python","patch_set":4,"id":"fd670a29_6a63b9af","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":32},"updated":"2024-10-23 05:45:07.000000000","message":"Can we load timeout from options in pipeline definitions rather than ceilometer.conf ? I see http publisher already have that approach and I believe that is much simple.","commit_id":"585651ec77589487156137cf648c15c62dd9d885"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0933a283872a5c07b4d8aaea620fd41c339aec2d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"               deprecated_name\u003d\u0027metering_driver\u0027,"},{"line_number":57,"context_line":"               ),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027notifier_timeout\u0027,"},{"line_number":59,"context_line":"               default\u003d5,"},{"line_number":60,"context_line":"               help\u003d\u0027Timeout in seconds when publishing events.\u0027,"},{"line_number":61,"context_line":"               )"},{"line_number":62,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"498b6fcb_7a85ee31","line":59,"range":{"start_line":59,"start_character":23,"end_line":59,"end_character":24},"updated":"2024-10-23 05:45:07.000000000","message":"This enables 5 seconds timeout in any deployment, and it may cause problems with large deployment. I\u0027d suggest using a bigger value like 60s or even 120s or even disable timeout by default unless requested.","commit_id":"585651ec77589487156137cf648c15c62dd9d885"}]}