)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9adb21e80eeb892030b525fdf83169c82dc970b1","unresolved":true,"context_lines":[{"line_number":18,"context_line":"file is logged during info mode which is unnecessary . This config"},{"line_number":19,"context_line":"file must be logged only when debug is enabled."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Resolves: rhbz#2167428"},{"line_number":22,"context_line":"Change-Id: Ia223b6518948765a74bb920829b6f76c354a3919"},{"line_number":23,"context_line":"(cherry picked from commit 838a32681ce3b6aa9bd251b849183dd26216bb78)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"706bccc0_8f9e426d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":22},"updated":"2023-08-17 11:58:29.000000000","message":"Launchpad bug would be great for backports to align with stable branch policy.","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"2e26bd1acd79b7e11032af7978b9c11c4ce76ce1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"file is logged during info mode which is unnecessary . This config"},{"line_number":19,"context_line":"file must be logged only when debug is enabled."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Resolves: rhbz#2167428"},{"line_number":22,"context_line":"Change-Id: Ia223b6518948765a74bb920829b6f76c354a3919"},{"line_number":23,"context_line":"(cherry picked from commit 838a32681ce3b6aa9bd251b849183dd26216bb78)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"40555fb6_f33896f7","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":22},"in_reply_to":"706bccc0_8f9e426d","updated":"2023-08-25 10:04:36.000000000","message":"Done","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"35c3fb9683ec65a5504f87b8c7b0f7aae62c6304","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00dc190f_82c31181","updated":"2023-08-07 08:51:25.000000000","message":"recheck","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"9615fcdb56094995952e0e4557aa07ee676523f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1274954d_813fb1aa","updated":"2023-06-20 11:08:24.000000000","message":"recheck","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"baf5e887b139a7fb450a0f6894911c4713017aa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fad0a13_823fd63a","updated":"2023-07-19 12:48:31.000000000","message":"recheck","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"1e19e373afe3098fffbd8cc0b47bfd36eac73ef1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"788618d0_a038319b","updated":"2023-08-07 07:06:28.000000000","message":"recheck","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"3dfab809a43fb829add80c2317e581ba13abe623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7235e265_82a6cd5b","updated":"2023-09-14 14:34:11.000000000","message":"As this is backport, extension of that timer should happen in follow up patch.\n\nThanks for your explanation.","commit_id":"95245dc753e5f3c6af0260567590dabd6f4373b6"}],"ceilometer/declarative.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9adb21e80eeb892030b525fdf83169c82dc970b1","unresolved":true,"context_lines":[{"line_number":199,"context_line":"                  \"Using default config.\")"},{"line_number":200,"context_line":"        definition_cfg \u003d defaults"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    LOG.debug(\"Definitions: %s\", definition_cfg)"},{"line_number":203,"context_line":"    return definition_cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"96c7e43f_1749f024","line":202,"updated":"2023-08-17 11:58:29.000000000","message":"While being very miniscular change, this is totally unrelated to the rest of the work in this PS and should be split to it\u0027s own.","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"2e26bd1acd79b7e11032af7978b9c11c4ce76ce1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                  \"Using default config.\")"},{"line_number":200,"context_line":"        definition_cfg \u003d defaults"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    LOG.debug(\"Definitions: %s\", definition_cfg)"},{"line_number":203,"context_line":"    return definition_cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"974a94c4_7e4b2a05","line":202,"in_reply_to":"96c7e43f_1749f024","updated":"2023-08-25 10:04:36.000000000","message":"Ack","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"}],"ceilometer/publisher/gnocchi.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9adb21e80eeb892030b525fdf83169c82dc970b1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        try:"},{"line_number":218,"context_line":"            self._gnocchi \u003d self._get_gnocchi_client(conf, timeout)"},{"line_number":219,"context_line":"        except tenacity.RetryError as e:"},{"line_number":220,"context_line":"            raise e.last_attempt._exception from None"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        self._already_logged_event_types \u003d set()"},{"line_number":223,"context_line":"        self._already_logged_metric_names \u003d set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"94652b22_f2970a5b","line":220,"range":{"start_line":220,"start_character":43,"end_line":220,"end_character":53},"updated":"2023-08-17 11:58:29.000000000","message":"This is neat, first time I\u0027ve seen it used like this. ++","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9adb21e80eeb892030b525fdf83169c82dc970b1","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"},{"line_number":229,"context_line":"        wait\u003dtenacity.wait_fixed(5),"},{"line_number":230,"context_line":"        retry\u003d("},{"line_number":231,"context_line":"            tenacity.retry_if_exception_type(ka_exceptions.ServiceUnavailable)"},{"line_number":232,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.DiscoveryFailure)"},{"line_number":233,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.ConnectTimeout)"},{"line_number":234,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"01230e92_21a44dd1","line":231,"range":{"start_line":231,"start_character":59,"end_line":231,"end_character":77},"updated":"2023-08-17 11:58:29.000000000","message":"Wondering how reasonable it is to retry every 5 seconds on 503, maybe longer delay and less retries?","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"2e26bd1acd79b7e11032af7978b9c11c4ce76ce1","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"},{"line_number":229,"context_line":"        wait\u003dtenacity.wait_fixed(5),"},{"line_number":230,"context_line":"        retry\u003d("},{"line_number":231,"context_line":"            tenacity.retry_if_exception_type(ka_exceptions.ServiceUnavailable)"},{"line_number":232,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.DiscoveryFailure)"},{"line_number":233,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.ConnectTimeout)"},{"line_number":234,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"46ef9872_f1590e49","line":231,"range":{"start_line":231,"start_character":59,"end_line":231,"end_character":77},"in_reply_to":"01230e92_21a44dd1","updated":"2023-08-25 10:04:36.000000000","message":"Sounds fine, we could retry every 60 secs instead of 5sec and 5 retries. What do you think ?","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"3dfab809a43fb829add80c2317e581ba13abe623","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        stop\u003dtenacity.stop_after_attempt(10),"},{"line_number":229,"context_line":"        wait\u003dtenacity.wait_fixed(5),"},{"line_number":230,"context_line":"        retry\u003d("},{"line_number":231,"context_line":"            tenacity.retry_if_exception_type(ka_exceptions.ServiceUnavailable)"},{"line_number":232,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.DiscoveryFailure)"},{"line_number":233,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.ConnectTimeout)"},{"line_number":234,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ab92b5c_f78a218b","line":231,"range":{"start_line":231,"start_character":59,"end_line":231,"end_character":77},"in_reply_to":"46ef9872_f1590e49","updated":"2023-09-14 14:34:11.000000000","message":"30s or 60s with 5 retries sounds good to me. I think that would be reasonable interval for your explanation below too.","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9adb21e80eeb892030b525fdf83169c82dc970b1","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        wait\u003dtenacity.wait_fixed(5),"},{"line_number":230,"context_line":"        retry\u003d("},{"line_number":231,"context_line":"            tenacity.retry_if_exception_type(ka_exceptions.ServiceUnavailable)"},{"line_number":232,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.DiscoveryFailure)"},{"line_number":233,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.ConnectTimeout)"},{"line_number":234,"context_line":"        ),"},{"line_number":235,"context_line":"        reraise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd70e1f0_7f0b98cd","line":232,"range":{"start_line":232,"start_character":61,"end_line":232,"end_character":77},"updated":"2023-08-17 11:58:29.000000000","message":"This seems to be indicating that there is no acceptable keystoneauth version available, do we thing retrying that 10 times solves something?","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"2e26bd1acd79b7e11032af7978b9c11c4ce76ce1","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        wait\u003dtenacity.wait_fixed(5),"},{"line_number":230,"context_line":"        retry\u003d("},{"line_number":231,"context_line":"            tenacity.retry_if_exception_type(ka_exceptions.ServiceUnavailable)"},{"line_number":232,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.DiscoveryFailure)"},{"line_number":233,"context_line":"            | tenacity.retry_if_exception_type(ka_exceptions.ConnectTimeout)"},{"line_number":234,"context_line":"        ),"},{"line_number":235,"context_line":"        reraise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7ac57e_3552548a","line":232,"range":{"start_line":232,"start_character":61,"end_line":232,"end_character":77},"in_reply_to":"fd70e1f0_7f0b98cd","updated":"2023-08-25 10:04:36.000000000","message":"This issue is intermittent and happens mostly right after a new deployment. When it occurs keystone doesn\u0027t report any sort of errors. Restarting ceilometer agent-notification fixes this. Retrying in such a way will try to establish connection will keystone when fetching gnocchi endpoint. We can definitely put more thoughts into finding ideal retry values.","commit_id":"b974998fdec41487801efba70574c7ac0fe83895"}]}