)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"80576d0a2635de8476f9f7dedfa91d8c6c2c5666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db1a954d_451b00d0","updated":"2023-07-25 10:25:25.000000000","message":"recheck","commit_id":"5a2e25e099bfe26dcb5d2d36394f076f997136e0"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"2d17abf2c6c606b3cfa4243075ebaea6852cdf4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e399d892_13083a52","updated":"2023-08-25 05:06:24.000000000","message":"Shouldn\u0027t be merged until a few config options are rectified in puppet-ceilometer","commit_id":"f11c1a7039dc64c02c9970fb1f50a8d6836d6830"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"0f6ad9f67142da71778a8dd037b65f86fb7f0d74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3c0cdd85_8cd3f5c5","updated":"2023-08-25 12:15:23.000000000","message":"recheck","commit_id":"f11c1a7039dc64c02c9970fb1f50a8d6836d6830"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"7f3af06d753851c94f87f83bd832eb07fa68ff1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"481c3ba2_74b5741e","updated":"2023-08-25 08:41:38.000000000","message":"recheck","commit_id":"f11c1a7039dc64c02c9970fb1f50a8d6836d6830"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1cdf5af9df4f29464fdd5b5b86fda43f4d093bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"467bc1c3_b0c8a5f8","updated":"2023-10-13 11:53:29.000000000","message":"I don\u0027t see the name resolution being tested anywhere since the removal of them in the test_notifications.py","commit_id":"c9195cd5ad9053cdc89a3aaff8b902a128836c65"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1750e3f7c32f60bac389f5db613ddc16e7c4b401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82421c58_f81a71fe","updated":"2023-10-16 11:42:35.000000000","message":"Thanks Yadnesh, now just wait for gnocchi to be resolved again.","commit_id":"cc9f44385f617e97c9e7fe514549f95f7a8ff1d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"481247a1b9fc749b947b286b97a8b2756021967c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"689670f2_0716be49","updated":"2023-11-06 05:41:44.000000000","message":"I do not intend to block this if this is an agreed approach, but I\u0027m not quite sure the proposed behavior is correct, because it ignores [cache] enabled \u003d False.\n\nIMO users are responsible to configure the appropriate cache options, and the proposed new default behavior is just confusing.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"1cf6cd17dfc08a34b39d0cdf787746b40646de07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8e2d0818_a3a4ee69","updated":"2023-11-13 07:27:40.000000000","message":"Is there an intent to move forward with this here?","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"68c0f411e7b1df75ced1c68d6e12457113c95626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"460d2794_0afda9ec","updated":"2023-11-04 16:06:41.000000000","message":"recheck gnocchi fixed","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b821776cf5ee172d704003e19f768fe56c1f9b49","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d5fe0abf_924f4768","in_reply_to":"3c8dd41c_6bc227a8","updated":"2023-11-13 14:53:24.000000000","message":"Thank you Takashi. The other reasoning here is: you can use like a small local cache, that would prevent a much heavier performance hit, once someone would enable the translation from project uuids to also names.\nThe amount of data to be cached/stored is small, it is mostly meant to prevent someone shooting themselves into the foot.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"4748eca4a08db9fcf30da1f6a8bf365c57d630a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e96e979e_300f1723","in_reply_to":"689670f2_0716be49","updated":"2023-11-13 07:53:05.000000000","message":"The idea was to use oslo dictionary if no caching backend is configured. If it\u0027s that confusing I can change this behaviour to do nothing in that case.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"73d9201c5b2febb8e71a624f1ba4d4dcd4a39c23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3c8dd41c_6bc227a8","in_reply_to":"c4baecc8_2f9ab7f0","updated":"2023-11-13 13:57:16.000000000","message":"Hmm. I relooked at nova code and noticed they do this kind of fallback so probably this is the right approach. Sorry for the confusion.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"40fa35c6cd1b326a7f2ede3a0e95e9c8fa6523ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6f342f08_b16dbc57","in_reply_to":"d5fe0abf_924f4768","updated":"2023-11-13 15:16:47.000000000","message":"\u003e once someone would enable the translation from project uuids to also names.\n\nThe point is that the translation is disabled by default. If users wants to enable it then he/she should be careful about the configurations needed for that feature. I may agree with you if no cache affects the default set up.\n\nHowever as I said, at least nova already does this \"hidden\" cache enablement so this is not something really new.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e651fec4164f94768cf87bc464eac7149cee7c27","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4baecc8_2f9ab7f0","in_reply_to":"e96e979e_300f1723","updated":"2023-11-13 13:55:48.000000000","message":"\u003e The idea was to use oslo dictionary if no caching backend is configured. If it\u0027s that confusing I can change this behaviour to do nothing in that case.\n\nIMO disabling caching completely when cache is not enabled is consistent with the other services (eg. nova, heat) and is preferred.","commit_id":"7925cf9fcc730062efdfc21250b46447e9134228"}],"ceilometer/tests/unit/meter/test_notifications.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1cdf5af9df4f29464fdd5b5b86fda43f4d093bf6","unresolved":true,"context_lines":[{"line_number":654,"context_line":"            self.assertEqual(msg[idx][\u0027project_id\u0027], s1[\u0027project_id\u0027])"},{"line_number":655,"context_line":"            self.assertEqual(msg[idx][\u0027user_id\u0027], s1[\u0027user_id\u0027])"},{"line_number":656,"context_line":"            self.assertEqual(fake_user_name, s1[\u0027user_name\u0027])"},{"line_number":657,"context_line":"            self.assertEqual(fake_project_name, s1[\u0027project_name\u0027])"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    @mock.patch(\u0027ceilometer.meter.notifications.LOG\u0027)"},{"line_number":660,"context_line":"    def test_multi_meter_payload_invalid_missing(self, LOG):"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1a5e717_9dfdcf2e","side":"PARENT","line":657,"updated":"2023-10-13 11:53:29.000000000","message":"This seems like a regression to me.","commit_id":"eb407792aa29666765c6814fe282fea585eef55c"}]}