)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"dd75268b4d5e2477f9d1fab87502e799e939b626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23a50356_76e4d40c","updated":"2023-09-08 12:54:35.000000000","message":"I went through the code, I discussed some of it directly with Erno, I left a note about a comment in the tests, but otherwise this LGTM.","commit_id":"4eb1d40cd5a7f6dd1d91dc620e328371b7751a25"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0144c1ce8ed2f57ee2c0acde8f5a35452bb7d6b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee176c6b_8752f591","updated":"2023-09-09 00:48:51.000000000","message":"recheck unrelated install issue on 39","commit_id":"e62d6d9ed5bbe704e7e7b4edce435b863cd98207"}],"ceilometer/publisher/tcp.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2728db108e5f792ff318218f362e435dd155860b","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                    continue"},{"line_number":82,"context_line":"                except OSError:"},{"line_number":83,"context_line":"                    pass"},{"line_number":84,"context_line":"            LOG.error(_(\"Unable to reconnect and resend sample over TCP\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def publish_events(self, events):"},{"line_number":87,"context_line":"        \"\"\"Send an event message for publishing"}],"source_content_type":"text/x-python","patch_set":3,"id":"a5b7568f_e3ff28f3","line":84,"updated":"2023-09-08 12:34:01.000000000","message":"(Discussing with Jaromir about this.)\nWe could add \u0027break\u0027 after this log call to avoid spamming the reconnects after initial failure.","commit_id":"8e94be1ca2491330657a7e8590c80f5b74787028"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"6ecda3e251e7b21150913426a0e2e9ee00f74ea6","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                    continue"},{"line_number":82,"context_line":"                except OSError:"},{"line_number":83,"context_line":"                    pass"},{"line_number":84,"context_line":"            LOG.error(_(\"Unable to reconnect and resend sample over TCP\"))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def publish_events(self, events):"},{"line_number":87,"context_line":"        \"\"\"Send an event message for publishing"}],"source_content_type":"text/x-python","patch_set":3,"id":"d76e6a4d_5730a553","line":84,"in_reply_to":"a5b7568f_e3ff28f3","updated":"2023-09-08 12:40:15.000000000","message":"My thinking there is, that we hope for the publisher to be able to eventually reconnect. The reasons for it getting disconnected can vary, it can be caused by networking issues or because the listening end isn\u0027t started yet. I don\u0027t think, there is a chance for the issue to disappear between loop iterations, so it might be better to just end the loop and try to reconnect again when the publish_samples() is called again.","commit_id":"8e94be1ca2491330657a7e8590c80f5b74787028"}],"ceilometer/tests/unit/publisher/test_tcp.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"dd75268b4d5e2477f9d1fab87502e799e939b626","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        return _fake_socket_create_connection"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_reconnect(self):"},{"line_number":162,"context_line":"        self.data_sent \u003d []"},{"line_number":163,"context_line":"        self.connections \u003d False"},{"line_number":164,"context_line":"        with mock.patch(\u0027ceilometer.publisher.tcp.socket.create_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5458f490_d0e0ccfd","line":161,"updated":"2023-09-08 12:54:35.000000000","message":"I feel like I should note, that originally this test was meant to test, that the publisher tries to reconnect after each send failure. So the _make_disconnecting_socket would return a socket, that would alternate between being disconnected and connected. So for each sample from this test, the first attempt to send the sample would be unsuccessful, the second attempt would be successful. With the second sample it would again be unsuccessful and successful on retry...\n\nNow, if I understand the code correctly, it changed to do the above only with the first sample. The other 4 samples will be sent successfully on first try I think. I\u0027m OK with the change, since the behavior gets tested at least with the first sample, but I think, that with this change, the comment a few lines above could also be deleted. The comment was trying to describe the behavior I described at the beginning of this comment and the behavior isn\u0027t here anymore.","commit_id":"8e94be1ca2491330657a7e8590c80f5b74787028"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"59b9522d603c94720124ef879d8ff7317b80197f","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        return _fake_socket_create_connection"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_reconnect(self):"},{"line_number":162,"context_line":"        self.data_sent \u003d []"},{"line_number":163,"context_line":"        self.connections \u003d False"},{"line_number":164,"context_line":"        with mock.patch(\u0027ceilometer.publisher.tcp.socket.create_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c20fb11_3366fc0e","line":161,"in_reply_to":"5458f490_d0e0ccfd","updated":"2023-09-08 13:36:35.000000000","message":"True indeed, I was looking at that comment and forgot to remove it.","commit_id":"8e94be1ca2491330657a7e8590c80f5b74787028"}]}