)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d697c9b2df06b52c7f494ace979094837469be2a","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                try:"},{"line_number":243,"context_line":"                    converted_value \u003d ast.literal_eval(self.value)"},{"line_number":244,"context_line":"                except (ValueError, SyntaxError):"},{"line_number":245,"context_line":"                    msg \u003d _(\u0027Unable to convert the metadata value %s\u0027"},{"line_number":246,"context_line":"                            \u0027 automatically\u0027) % (self.value)"},{"line_number":247,"context_line":"                    LOG.debug(msg)"},{"line_number":248,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FH6E%3D","line":245,"updated":"2014-04-23 20:39:17.000000000","message":"i\u0027m wondering if it\u0027s just safer to not log anything. if it\u0027s useful then i\u0027m ok with this although i get the feeling people will still think it\u0027s an error.","commit_id":"b3128862ebd5f3a0f4a8b4a2a8b0864e4b104a27"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"d3bcfab5efb90172cef3bb474bef2255ca1b5000","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                try:"},{"line_number":243,"context_line":"                    converted_value \u003d ast.literal_eval(self.value)"},{"line_number":244,"context_line":"                except (ValueError, SyntaxError):"},{"line_number":245,"context_line":"                    msg \u003d _(\u0027Unable to convert the metadata value %s\u0027"},{"line_number":246,"context_line":"                            \u0027 automatically\u0027) % (self.value)"},{"line_number":247,"context_line":"                    LOG.debug(msg)"},{"line_number":248,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FHwA%3D","line":245,"in_reply_to":"AAAAXH%2F%2FH6E%3D","updated":"2014-04-23 21:14:49.000000000","message":"I think its probably useful to log this so user knows the conversion dint work. Since its a log debug I feel its ok to continue logging this. Do you think we should reword it differently than just changing to Unable then?","commit_id":"b3128862ebd5f3a0f4a8b4a2a8b0864e4b104a27"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"54da1e7ccc1304c3844584aaca73ef32766bd8c8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                try:"},{"line_number":243,"context_line":"                    converted_value \u003d ast.literal_eval(self.value)"},{"line_number":244,"context_line":"                except (ValueError, SyntaxError):"},{"line_number":245,"context_line":"                    msg \u003d _(\u0027Unable to convert the metadata value %s\u0027"},{"line_number":246,"context_line":"                            \u0027 automatically\u0027) % (self.value)"},{"line_number":247,"context_line":"                    LOG.debug(msg)"},{"line_number":248,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F1yE%3D","line":245,"in_reply_to":"AAAAXH%2F%2FHwA%3D","updated":"2014-04-25 21:03:21.000000000","message":"hmm... the more i think about this, the more i think we should drop log... the user doesn\u0027t at any point specify they want to convert the metadata value in this path... seeing any log message relating to an action they didn\u0027t ask for might look suspicious.\n\nthoughts?","commit_id":"b3128862ebd5f3a0f4a8b4a2a8b0864e4b104a27"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d697c9b2df06b52c7f494ace979094837469be2a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                    raise TypeError()"},{"line_number":255,"context_line":"                converted_value \u003d self._type_converters[type](self.value)"},{"line_number":256,"context_line":"        except ValueError:"},{"line_number":257,"context_line":"            msg \u003d _(\u0027Unable to convert the value %(value)s\u0027"},{"line_number":258,"context_line":"                    \u0027 to the expected data type %(type)s.\u0027) % \\"},{"line_number":259,"context_line":"                {\u0027value\u0027: self.value, \u0027type\u0027: type}"},{"line_number":260,"context_line":"            raise ClientSideError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FH6Y%3D","line":257,"updated":"2014-04-23 20:39:17.000000000","message":"this one actually does throw an error. i\u0027m ok with either text.","commit_id":"b3128862ebd5f3a0f4a8b4a2a8b0864e4b104a27"}]}