)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"72262ac4d5f0e030fd40f7c1b911a5ac2294cb04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75f25b1e_05cbff69","updated":"2023-10-12 08:08:13.000000000","message":"This patch adds support for an upcoming sg-core devstack plugin. I\u0027m currently in the process of creating and testing the plugin here: https://github.com/infrawatch/sg-core/tree/jwysogla-devstack Once I see everything is working I\u0027ll create sg-core PR and once that is merged, I\u0027ll remove the WIP label here.","commit_id":"b0fff2d904fa1bccca0f4b334b60c5e659fab09a"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"5aa635eb19f3eb7a410a50f8b61847468ec1872b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5bc1f8c2_0b52619f","updated":"2023-10-18 07:15:52.000000000","message":"Thank you Jaromir!\n\nWhen enabling sg-core and not enabling gnocchi, we also would want to make sure not to clone gnocchi (in order to avoid pulling in gnocchi dependencies, which may create conflicts)","commit_id":"ee40578bab327aa62d2c7b26e8a9c87ba6b6f3fb"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"202a9576e42ec355000f99afc2569fd4e3752aff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2c623d6e_1e02825e","in_reply_to":"5bc1f8c2_0b52619f","updated":"2023-10-19 12:30:35.000000000","message":"Hi, I checked the plugin to find where gnocchi is being installed. I think it shouldn\u0027t get installed if gnocchi isn\u0027t in the \"CEILOMETER_BACKENDS\" (see my other comments).\n\nI found a mistake in how I handled the CEILOMETER_BACKEND and CEILOMETER_BACKENDS defaults though and because of that gnocchi was always added to the CEILOMETER_BACKENDS variable. I fixed the variable and I\u0027m redeploying without gnocchi. Once that is done I\u0027ll check if gnocchi is installed and either confirm this comment or follow up with additional changes to prevent it from installing.","commit_id":"ee40578bab327aa62d2c7b26e8a9c87ba6b6f3fb"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"adfb94f44738cc769223fc04ce7b26af2b048517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"98f6bd5d_845e9da5","updated":"2023-10-19 13:39:56.000000000","message":"I don\u0027t see gnocchi installed when setting CEILOMETER_BACKEND\u003dsg-core\n\nhttps://paste.opendev.org/show/bU3poDEfQkeYFlW349Bl/","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f96b568ca16fca8c5ecbea2c8c59d231ac5d8e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d4508dcf_3afaf133","updated":"2023-11-07 16:08:25.000000000","message":"I think it all makes sense and doesn\u0027t seem to break anything.","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"f542b0081302a9d73728114b86642c05c9405eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e1bbdb86_77eb2c28","updated":"2023-11-07 15:31:22.000000000","message":"I think it would be nice if somebody could WF +1. This will be useful for other patches which will add sg-core to the CI.","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"c03655ced83c31af505cebcb8aabced73a8e7773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e194f99d_e9bdb770","updated":"2023-11-08 06:31:58.000000000","message":"I think it\u0027s one of the monasca tests, that\u0027s actually failing. And I saw that same fail in at least 2 ceilometer changes now. I guess I\u0027ll need to get to cleaning monasca integration as soon as possible.\n\n{6} ceilometer.tests.unit.publisher.test_monasca_publisher.TestMonascaPublisher.test_publisher_batch_retry [60.020899s] ... FAILED","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"9ccf73a3833aa9cc3bb16174c1ccea8b3d663325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"692e7799_69977c8c","updated":"2023-11-08 15:04:25.000000000","message":"recheck - monasca is now dropped from ceilometer","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"61226d46f5ab2ff2198737ca599eccfebe5cf4ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fb61d17d_568e9b09","updated":"2023-11-03 17:18:37.000000000","message":"recheck - the gate should be unblocked now","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"68736c70a526c6ecd96c146e1841a7ba579c56c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"86eda3ce_ace34881","updated":"2023-11-07 19:50:14.000000000","message":"something like https://review.opendev.org/c/openstack/python-aodhclient/+/900166/2/tox.ini may be needed for ceilometer too","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4212cdbf2d6c2a6240103bb70c3b8d5578780eb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4a2a9a79_b6e98156","in_reply_to":"42ad2ec5_122007eb","updated":"2023-11-08 07:13:08.000000000","message":"Thank you for looking into this. Monasca is a dead project at this point. I am not sure if it would make sense to fix the monasca tests or to just rip it out from ceilometer.","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ffbcf1478d694f6f962157a21b928bab563870f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"42ad2ec5_122007eb","in_reply_to":"4cd12410_5e99f1d1","updated":"2023-11-08 07:02:01.000000000","message":"I see a lot of monasca related output in the zuul output you sent and in the zuul output for this change. In the end almost all of the tests ended as ok. The test I pointed out earlier though fails here, but is ok in your link and I don\u0027t think I see any related output to it. Briefly looking at the code it\u0027s trying to count calls made by the monasca publisher. It\u0027s expecting 4 calls, but it makes less (I saw 1 and 3, so it\u0027s not consisnent).","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ac5daf3f87c538e018e3ed5b9231bb924f4a0a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4cd12410_5e99f1d1","in_reply_to":"e194f99d_e9bdb770","updated":"2023-11-08 06:48:43.000000000","message":"The monasca tests failed for a long time already; I wonder what changed here, since the issues showing up failed before, such as here: https://zuul.opendev.org/t/openstack/build/0c770664964146a8ac99b1daeadb2539/log/job-output.txt , coming from the logs in https://review.opendev.org/c/openstack/ceilometer/+/898215","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"}],"devstack/plugin.sh":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"202a9576e42ec355000f99afc2569fd4e3752aff","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        git_clone ${GNOCCHI_REPO} ${GNOCCHI_DIR} ${GNOCCHI_BRANCH}"},{"line_number":145,"context_line":"        pip_install -e ${GNOCCHI_DIR}[redis,${DATABASE_TYPE},keystone] uwsgi"},{"line_number":146,"context_line":"    else"},{"line_number":147,"context_line":"        pip_install gnocchi[redis,${DATABASE_TYPE},keystone] uwsgi"},{"line_number":148,"context_line":"    fi"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"0386725d_d8a049e9","line":147,"updated":"2023-10-19 12:30:35.000000000","message":"I think this is the only place where gnocchi is actually installed and where it pulls dependencies.","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"202a9576e42ec355000f99afc2569fd4e3752aff","unresolved":true,"context_lines":[{"line_number":316,"context_line":"        _ceilometer_prepare_coordination"},{"line_number":317,"context_line":"    fi"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    ! [[ $DEVSTACK_PLUGINS \u003d~ \u0027gnocchi\u0027 ]] \u0026\u0026 [[ \"$CEILOMETER_BACKENDS\" \u003d~ \u0027gnocchi\u0027 ]] \u0026\u0026 install_gnocchi"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    if is_service_enabled ceilometer-acompute ; then"},{"line_number":322,"context_line":"        _ceilometer_prepare_virt_drivers"}],"source_content_type":"text/x-sh","patch_set":6,"id":"119e2582_7c9e4e51","line":319,"updated":"2023-10-19 12:30:35.000000000","message":"This is the only line, where install_gnocchi is called. install_gnocchi is called only when gnocchi is set as one of the backends.","commit_id":"ef237e3c0b946de7e60c97f4434a74d686092e68"}]}