)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"05dbafb62311ac371040fb450fbfa74022b6affe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6979454a_15c79cd6","updated":"2024-01-24 14:17:35.000000000","message":"Thank you!","commit_id":"afbf0a1acf4db4f9180ef71d31074fba8c99732a"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"1ad9f20061438045124ff1d81b167879ddaaf20b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f8274703_c142fd46","updated":"2024-08-07 07:48:12.000000000","message":"This changes makes the help more legible.","commit_id":"afbf0a1acf4db4f9180ef71d31074fba8c99732a"}],"ceilometer/compute/discovery.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"369b71311a1d8f9fe8cba280e9fe945ab17fcd4f","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                        (\u0027libvirt_metadata\u0027,"},{"line_number":43,"context_line":"                         \u0027get instances from libvirt metadata but without \u0027"},{"line_number":44,"context_line":"                         \u0027instance metadata \u0027"},{"line_number":45,"context_line":"                         \u0027(recommended for Gnocchi backend)\u0027)],"},{"line_number":46,"context_line":"               help\u003d\"Ceilometer offers many methods to discover the instance \""},{"line_number":47,"context_line":"                    \"running on a compute node\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3e82ad9_20fc4cfa","line":45,"updated":"2024-01-24 12:35:56.000000000","message":"Actually, this is the preferred method, since it does not put such a heavy load on the nova API, it has nothing to do with the storage backend though.","commit_id":"837e6015cae4f79a3cafc486551ca79484d865a9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"09da6db018a9de82dff15ec7b4a5cfc2c88ce3c9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                        (\u0027libvirt_metadata\u0027,"},{"line_number":43,"context_line":"                         \u0027get instances from libvirt metadata but without \u0027"},{"line_number":44,"context_line":"                         \u0027instance metadata \u0027"},{"line_number":45,"context_line":"                         \u0027(recommended for Gnocchi backend)\u0027)],"},{"line_number":46,"context_line":"               help\u003d\"Ceilometer offers many methods to discover the instance \""},{"line_number":47,"context_line":"                    \"running on a compute node\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3596c8bf_523dbee4","line":45,"in_reply_to":"e8cadbc7_76e542ae","updated":"2024-01-24 12:47:15.000000000","message":"Done","commit_id":"837e6015cae4f79a3cafc486551ca79484d865a9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9ed6c42873719d8689a7600566585e2139a55d11","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                        (\u0027libvirt_metadata\u0027,"},{"line_number":43,"context_line":"                         \u0027get instances from libvirt metadata but without \u0027"},{"line_number":44,"context_line":"                         \u0027instance metadata \u0027"},{"line_number":45,"context_line":"                         \u0027(recommended for Gnocchi backend)\u0027)],"},{"line_number":46,"context_line":"               help\u003d\"Ceilometer offers many methods to discover the instance \""},{"line_number":47,"context_line":"                    \"running on a compute node\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8cadbc7_76e542ae","line":45,"in_reply_to":"f3e82ad9_20fc4cfa","updated":"2024-01-24 12:45:35.000000000","message":"Actually I found this odd when I created this version but left it. But I agree we should probably update this (and even deprecate the other options later).\n\nFor now I\u0027ve updated the desciption to recommend this regardless of the backends.","commit_id":"837e6015cae4f79a3cafc486551ca79484d865a9"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"a02ae7dd5456f4f7d2a961318578866a29e7d8c5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                    \"* workload_partitioning: poll nova to get instances of \""},{"line_number":44,"context_line":"                    \"the compute\\n\""},{"line_number":45,"context_line":"                    \"* libvirt_metadata: get instances from libvirt metadata \""},{"line_number":46,"context_line":"                    \"  but without instance metadata (recommended for Gnocchi \""},{"line_number":47,"context_line":"                    \"  backend\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c1c22d31_ac633e42","side":"PARENT","line":47,"range":{"start_line":46,"start_character":65,"end_line":47,"end_character":30},"updated":"2024-08-05 07:46:26.000000000","message":"Can we include this too ?","commit_id":"079e5eda9fea4bc362a6f158e442b5708093ab3d"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"9fb4473f1376fa1ae3673e2a8ca4b24ef511d7fa","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                    \"* workload_partitioning: poll nova to get instances of \""},{"line_number":44,"context_line":"                    \"the compute\\n\""},{"line_number":45,"context_line":"                    \"* libvirt_metadata: get instances from libvirt metadata \""},{"line_number":46,"context_line":"                    \"  but without instance metadata (recommended for Gnocchi \""},{"line_number":47,"context_line":"                    \"  backend\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"956260d9_d9ea93a6","side":"PARENT","line":47,"range":{"start_line":46,"start_character":65,"end_line":47,"end_character":30},"in_reply_to":"4316e6dd_a54594a3","updated":"2024-08-16 10:11:23.000000000","message":"To add some context (I think I know why the gnocchi recommendation is there): libvirt_metadata won\u0027t retrieve the instance metadata. So for example if you create a server with `--property metering.something\u003dvalue` . When polling nova, you\u0027ll get \"something\u003dvalue\" in the metric data, this is absent when polling libvirt. Gnocchi is actually able to retrieve this data on its own, so if ceilometer polls libvirt and sends the metrics to Gnocchi without the metadata, gnocchi polls nova and retrieves it, so the metadata aren\u0027t missing. This is why I think there is the recommendation.","commit_id":"079e5eda9fea4bc362a6f158e442b5708093ab3d"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"e0a4aeec608d79cedd5bb5ce50a2f4fc278edbdb","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                    \"* workload_partitioning: poll nova to get instances of \""},{"line_number":44,"context_line":"                    \"the compute\\n\""},{"line_number":45,"context_line":"                    \"* libvirt_metadata: get instances from libvirt metadata \""},{"line_number":46,"context_line":"                    \"  but without instance metadata (recommended for Gnocchi \""},{"line_number":47,"context_line":"                    \"  backend\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1fe5ad_bad0c51f","side":"PARENT","line":47,"range":{"start_line":46,"start_character":65,"end_line":47,"end_character":30},"in_reply_to":"956260d9_d9ea93a6","updated":"2024-08-16 13:24:12.000000000","message":"I am quite certain that gnocchi does not make any connection to nova.","commit_id":"079e5eda9fea4bc362a6f158e442b5708093ab3d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"58d88a8e310181547d4c2982898e00118ec44c72","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                    \"* workload_partitioning: poll nova to get instances of \""},{"line_number":44,"context_line":"                    \"the compute\\n\""},{"line_number":45,"context_line":"                    \"* libvirt_metadata: get instances from libvirt metadata \""},{"line_number":46,"context_line":"                    \"  but without instance metadata (recommended for Gnocchi \""},{"line_number":47,"context_line":"                    \"  backend\"),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027resource_update_interval\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4316e6dd_a54594a3","side":"PARENT","line":47,"range":{"start_line":46,"start_character":65,"end_line":47,"end_character":30},"in_reply_to":"c1c22d31_ac633e42","updated":"2024-08-05 07:51:23.000000000","message":"I intentionally removed based on the discussion with Matthias here. https://review.opendev.org/c/openstack/ceilometer/+/906172/comment/f3e82ad9_20fc4cfa/ . The preference is not really specific to Gnocchi.","commit_id":"079e5eda9fea4bc362a6f158e442b5708093ab3d"}]}