)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"60e550579547160651b86ccbce31dc699718d75c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0357c35_9c11e753","updated":"2024-03-25 20:31:09.000000000","message":"Hi Rafael, I have only a nit suggestion about the group_id for Local Node Discovery.","commit_id":"cc10788389b974f31694c1747b29ef7e99c39626"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c4aed4fefeb37d4edd0b3746472efccfdc7746d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c605a1fe_c43ced37","updated":"2024-09-23 12:41:08.000000000","message":".","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"7674c760d2f8ade0c41c45fd77a61a9f524de4fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e844463_6c80b83f","updated":"2024-09-23 12:40:46.000000000","message":"Hello guys, \nAre we missing something here?","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c4aed4fefeb37d4edd0b3746472efccfdc7746d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c277b406_6d4541c2","updated":"2024-09-23 12:41:08.000000000","message":"Hello guys, \nAre we missing something here?","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"551fb36e2906dd19ce44a45cec0f24c2c22221a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"641d48c7_e2c818ba","updated":"2025-03-27 20:34:25.000000000","message":"Hello guys, \nAre we missing something on this one?\n\nIt seems that everything was fine to be merged.","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"64d9460c12275cdfbaf8d285a22818a397721799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c51896b3_878c6a8f","updated":"2024-06-06 20:53:11.000000000","message":"Hello guys, \nwhat about this one? Can we merge it?","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"63a209c7e8a4ec51eb3d66b742dd26b55e1ab164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"190e4c7f_4146f7c2","in_reply_to":"c51896b3_878c6a8f","updated":"2024-06-07 08:04:40.000000000","message":"Hi Rafael,\n\nI\u0027ve been catching up a lots of reviews and took a first pass on this yesterday. Just need get a good look on it before casting my vote as there is quite a bit going on. Trying to get back to this again today.","commit_id":"4f0bec177f84c8ef1da2ab247ec176b7aca819b2"}],"ceilometer/polling/discovery/localnode.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"60e550579547160651b86ccbce31dc699718d75c","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @ property"},{"line_number":24,"context_line":"    def group_id(self):"},{"line_number":25,"context_line":"        return \"LocalNone-%s\" % self.conf.host"}],"source_content_type":"text/x-python","patch_set":1,"id":"74a63e38_9c6f3550","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":25},"updated":"2024-03-25 20:31:09.000000000","message":"LocalNone or LocalNode?","commit_id":"cc10788389b974f31694c1747b29ef7e99c39626"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"01476a8113b87c05f30e5d139243bbeb0e06d79d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @ property"},{"line_number":24,"context_line":"    def group_id(self):"},{"line_number":25,"context_line":"        return \"LocalNone-%s\" % self.conf.host"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9773a61_08f1db08","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":25},"in_reply_to":"74a63e38_9c6f3550","updated":"2024-03-25 20:37:26.000000000","message":"It was a typo. I fixed it now.","commit_id":"cc10788389b974f31694c1747b29ef7e99c39626"}],"ceilometer/polling/manager.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"60e550579547160651b86ccbce31dc699718d75c","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                                  coordination_group_name)"},{"line_number":224,"context_line":"                        group_coordination \u003d self.manager.hashrings["},{"line_number":225,"context_line":"                            coordination_group_name].belongs_to_self("},{"line_number":226,"context_line":"                            str(pollster.name))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"                        LOG.debug(\"Pollster [%s] is configured with \""},{"line_number":229,"context_line":"                                  \"coordination [%s] under name [%s].\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dd55c1ce_3f6a4af4","line":226,"range":{"start_line":226,"start_character":28,"end_line":226,"end_character":46},"updated":"2024-03-25 20:31:09.000000000","message":"isnt the pollster.name string already? or is it to convert None to \u0027None\u0027?","commit_id":"cc10788389b974f31694c1747b29ef7e99c39626"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"01476a8113b87c05f30e5d139243bbeb0e06d79d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                  coordination_group_name)"},{"line_number":224,"context_line":"                        group_coordination \u003d self.manager.hashrings["},{"line_number":225,"context_line":"                            coordination_group_name].belongs_to_self("},{"line_number":226,"context_line":"                            str(pollster.name))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"                        LOG.debug(\"Pollster [%s] is configured with \""},{"line_number":229,"context_line":"                                  \"coordination [%s] under name [%s].\","}],"source_content_type":"text/x-python","patch_set":1,"id":"96cf388b_3328f22e","line":226,"range":{"start_line":226,"start_character":28,"end_line":226,"end_character":46},"in_reply_to":"dd55c1ce_3f6a4af4","updated":"2024-03-25 20:37:26.000000000","message":"I am converting just in case. For the Dynamic pollster the \"name\" is required. However, the hard coded ones, I have seem some of them without a name there (at least that is what it seems). In this case, this code would force all of them to be executed in the same node, and not spread them over all of the ceilometer-central nodes.","commit_id":"cc10788389b974f31694c1747b29ef7e99c39626"}]}