)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"654a2543ea5c3f4f031f1ed03f30e6657b2d2e23","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the timestamp in query fields is not unified."},{"line_number":10,"context_line":"start_timestamp/end_timestamp and start/end shouldn\u0027t be supported in some"},{"line_number":11,"context_line":"APIs, this patch improve the query_to_kwargs method to forbid these in"},{"line_number":12,"context_line":"query field."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I37c7fb4bfa26b22e6591140f974c85b23b77b060"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_c4cb791c","line":11,"updated":"2014-05-05 12:23:48.000000000","message":"Please, change improve to improves.","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9219d12db83ff076ad566b199effff2c39b33498","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the timestamp in query fields is not unified."},{"line_number":10,"context_line":"start_timestamp/end_timestamp and start/end shouldn\u0027t be supported in some"},{"line_number":11,"context_line":"APIs, this patch improve the query_to_kwargs method to forbid these in"},{"line_number":12,"context_line":"query field."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I37c7fb4bfa26b22e6591140f974c85b23b77b060"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_21e71242","line":11,"in_reply_to":"9ad9bd40_c4cb791c","updated":"2014-05-08 04:13:10.000000000","message":"Done","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"576f5483535448bd58900daf51cd66149ad3c5d7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"query fields."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I37c7fb4bfa26b22e6591140f974c85b23b77b060"},{"line_number":15,"context_line":"Closes-bug: #1291171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_a4a931e1","line":15,"updated":"2014-06-02 13:54:36.000000000","message":"change this to Partial-Bug: since the next patch fixes the bug completely.","commit_id":"cc387c7f14e757051deed6740c5fb47d43b9d43e"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ea88b248c4d301a255feca4382bb5bab1f416cb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"query fields."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I37c7fb4bfa26b22e6591140f974c85b23b77b060"},{"line_number":15,"context_line":"Closes-bug: #1291171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_2a46b67c","line":15,"in_reply_to":"1ae5cdf2_a4a931e1","updated":"2014-06-03 02:49:51.000000000","message":"Done","commit_id":"cc387c7f14e757051deed6740c5fb47d43b9d43e"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"654a2543ea5c3f4f031f1ed03f30e6657b2d2e23","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    if valid_keys \u0026 timestamp_fields:"},{"line_number":366,"context_line":"        valid_keys \u003d valid_keys - timestamp_fields"},{"line_number":367,"context_line":"        valid_keys.add(\u0027timestamp\u0027)"},{"line_number":368,"context_line":"        valid_keys.add(\u0027search_offset\u0027)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    internal_keys.append(\u0027self\u0027)"},{"line_number":371,"context_line":"    valid_keys \u003d valid_keys - set(internal_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_a72d9748","line":368,"updated":"2014-05-05 12:23:48.000000000","message":"Strs \u0027timestamp\u0027 and \u0027search_offset\u0027 are not used in valid_keys, because code skips field  \u0027timestamp\u0027 or \u0027search_offset\u0027 at L#395.","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9219d12db83ff076ad566b199effff2c39b33498","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    if valid_keys \u0026 timestamp_fields:"},{"line_number":366,"context_line":"        valid_keys \u003d valid_keys - timestamp_fields"},{"line_number":367,"context_line":"        valid_keys.add(\u0027timestamp\u0027)"},{"line_number":368,"context_line":"        valid_keys.add(\u0027search_offset\u0027)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    internal_keys.append(\u0027self\u0027)"},{"line_number":371,"context_line":"    valid_keys \u003d valid_keys - set(internal_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_2190f294","line":368,"in_reply_to":"9ad9bd40_a72d9748","updated":"2014-05-08 04:13:10.000000000","message":"the valid_keys is mainly used to presented to user if user specified a invalid key in query field (at L#410).","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"654a2543ea5c3f4f031f1ed03f30e6657b2d2e23","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":410,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":411,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":412,"context_line":"    return valid_keys"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_a4bd956a","line":412,"updated":"2014-05-05 12:23:48.000000000","message":"May you correct \u0027returns\u0027 point in doc string if this return is needed?","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9219d12db83ff076ad566b199effff2c39b33498","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":410,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":411,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":412,"context_line":"    return valid_keys"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_a4b73e39","line":412,"in_reply_to":"9ad9bd40_a4bd956a","updated":"2014-05-08 04:13:10.000000000","message":"Done","commit_id":"d253e66246a15b21c07f1e108ff59af332668279"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"012ba505862f299e116a7d2d0b0666d46fd01380","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":411,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":412,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":413,"context_line":"    return valid_keys"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_6ff7f5f5","line":413,"updated":"2014-05-23 13:35:57.000000000","message":"this value doesn\u0027t seem to be used anywhere","commit_id":"41497138c3a65a74199871e8ae012bb32ebe989a"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"2745d8c387dd93c7ba89bf5211e8a5f4a43284f7","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":411,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":412,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":413,"context_line":"    return valid_keys"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5adbc538_7a31d0a1","line":413,"in_reply_to":"7adec928_6ff7f5f5","updated":"2014-05-26 01:36:28.000000000","message":"Hi gordon, the return value used in https://review.openstack.org/#/c/92788 which depends on this patch","commit_id":"41497138c3a65a74199871e8ae012bb32ebe989a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"28cfcb231a7a13260879d80dc4d69e84966c0acf","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":412,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":413,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":414,"context_line":"    return valid_keys"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_2451a1d8","line":414,"updated":"2014-06-02 13:57:06.000000000","message":"if we want to return keys it should be it\u0027s own function... this return value really has nothing to do with purpose of function","commit_id":"cc387c7f14e757051deed6740c5fb47d43b9d43e"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ea88b248c4d301a255feca4382bb5bab1f416cb","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":412,"context_line":"                       \"valid keys: %s\") % (query, valid_keys)"},{"line_number":413,"context_line":"                raise wsme.exc.UnknownArgument(key, msg)"},{"line_number":414,"context_line":"    return valid_keys"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def _validate_timestamp_fields(query, field_name, operator_list,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_c57d45b3","line":414,"in_reply_to":"1ae5cdf2_2451a1d8","updated":"2014-06-03 02:49:51.000000000","message":"but if we don\u0027t return the valid_keys, we should get the valid _keys again in _query_to_kwargs() of https://review.openstack.org/#/c/92788/3, I want to reduce the repeating action.","commit_id":"cc387c7f14e757051deed6740c5fb47d43b9d43e"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"27b2871fab9a40b0158bf23c8e78e6aad0da6f22","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    timestamp_fields \u003d set("},{"line_number":365,"context_line":"        [\u0027end\u0027, \u0027start\u0027, \u0027start_time\u0027, \u0027end_time\u0027, \u0027end_timestamp\u0027,"},{"line_number":366,"context_line":"         \u0027start_timestamp\u0027])"},{"line_number":367,"context_line":"    if valid_keys \u0026 timestamp_fields:"},{"line_number":368,"context_line":"        valid_keys \u003d valid_keys - timestamp_fields"},{"line_number":369,"context_line":"        valid_keys.add(\u0027timestamp\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_ab182120","line":366,"updated":"2014-07-31 07:58:20.000000000","message":"instead of having this timestamp_fields contain all the possible values of db_func, how about we change all those db_funcs\u0027 param name the same, i.e. start_timestamp \u0026 end_timestamp?\n\nThis would also simplify the logic in _query_to_kwargs() a lot.","commit_id":"82e1c90a082f6cb7f4b29e918e1f8ba251a38426"}]}