)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ff86c75f867fb741333b8631608018221e08a9eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Koert van der Veer \u003ckoert@cloudvps.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-06 18:18:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implemented metering for cinder\u0027s snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder already publishes the required notifications, but ceilometer"},{"line_number":10,"context_line":"wasn\u0027t recording them. This patch fixes that."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad9bd40_ca90b2ef","line":7,"updated":"2014-05-06 20:29:30.000000000","message":"Probably cinder-\u003eCinder","commit_id":"3523edd459aab09c6baa502c2fd885a58e9467d9"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"05351f1af2ce39e1c12b6d605279d357cfc0efc1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implemented metering for cinder\u0027s snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder already publishes the required notifications, but ceilometer"},{"line_number":10,"context_line":"wasn\u0027t recording them. This patch fixes that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1316483"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_ab0af11e","line":9,"updated":"2014-05-09 21:52:07.000000000","message":"Ceilometer will be better here too...","commit_id":"3523edd459aab09c6baa502c2fd885a58e9467d9"}],"ceilometer/tests/volume/test_notifications.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"15fb8ce4afd1c387c02f006eaea4285835f34f08","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                         s.volume)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _verify_common_sample_snapshot(self, s, name, notification):"},{"line_number":202,"context_line":"        self.assertIsNotNone(s)"},{"line_number":203,"context_line":"        self.assertEqual(s.name, name)"},{"line_number":204,"context_line":"        self.assertEqual(notification[\u0027payload\u0027][\u0027snapshot_id\u0027], s.resource_id)"},{"line_number":205,"context_line":"        self.assertEqual(notification[\u0027timestamp\u0027], s.timestamp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_f633b2a8","line":202,"updated":"2014-05-16 09:45:07.000000000","message":"Could you please change an order in assertEqual? The first arg is \u0027expected\u0027, the second is actual. So the next line should be self.assertEqual(name, s.name). As far as I see it\u0027s the only place where args are misplaced.","commit_id":"89c515c9cb7c45322bb88d56ff8b2ca56a72eb20"},{"author":{"_account_id":5619,"name":"Koert van der Veer","email":"koert@cloudvps.com","username":"kvdveer"},"change_message_id":"c0d24f6a1aba5d3990b619559a07c3d8b5d8d4cd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                         s.volume)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _verify_common_sample_snapshot(self, s, name, notification):"},{"line_number":202,"context_line":"        self.assertIsNotNone(s)"},{"line_number":203,"context_line":"        self.assertEqual(s.name, name)"},{"line_number":204,"context_line":"        self.assertEqual(notification[\u0027payload\u0027][\u0027snapshot_id\u0027], s.resource_id)"},{"line_number":205,"context_line":"        self.assertEqual(notification[\u0027timestamp\u0027], s.timestamp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_5c456415","line":202,"in_reply_to":"7adec928_f633b2a8","updated":"2014-05-16 14:55:40.000000000","message":"Done","commit_id":"89c515c9cb7c45322bb88d56ff8b2ca56a72eb20"}],"ceilometer/volume/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0537bb5f3ecc7e33ecbc1a5e77536c3cb468d198","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class _SnapshotBase(plugin.NotificationBase):"},{"line_number":86,"context_line":"    \"\"\"Convert snapshto notifications into Counters.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    event_types \u003d ["},{"line_number":89,"context_line":"        \u0027snapshot.exists\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_6fc6e29b","line":86,"updated":"2014-05-06 14:07:51.000000000","message":"s/snapshto notifications into Counters/snapshot notifications into Samples/","commit_id":"f6e78cd46f763c15a0f2d02dcfdee1b95b6ae704"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0537bb5f3ecc7e33ecbc1a5e77536c3cb468d198","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    ]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @staticmethod"},{"line_number":96,"context_line":"    def get_exchange_topics(conf):"},{"line_number":97,"context_line":"        \"\"\"Return a sequence of ExchangeTopics defining the exchange and"},{"line_number":98,"context_line":"        topics to be connected for this plugin."},{"line_number":99,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_6f742268","line":96,"updated":"2014-05-06 14:07:51.000000000","message":"which should probably make a common base between volume and snapshot so we don\u0027t need to repeat this.","commit_id":"f6e78cd46f763c15a0f2d02dcfdee1b95b6ae704"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"42dca9a121833703284de7a400ca734cde9b97a8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            message\u003dmessage)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class _SnapshotBase(plugin.NotificationBase):"},{"line_number":90,"context_line":"    \"\"\"Convert snapshot notifications into Counters.\"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    event_types \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7adec928_6a63871a","line":89,"updated":"2014-05-22 14:20:34.000000000","message":"I assume this one should inherit from _Base here, but correct me, if I\u0027m wrong.","commit_id":"aa87b4389c2911feb40a196b2259ea0ab98772aa"},{"author":{"_account_id":5619,"name":"Koert van der Veer","email":"koert@cloudvps.com","username":"kvdveer"},"change_message_id":"1d35adbb18cd9783503e583a4123ebf65ffff6f5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            message\u003dmessage)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class _SnapshotBase(plugin.NotificationBase):"},{"line_number":90,"context_line":"    \"\"\"Convert snapshot notifications into Counters.\"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    event_types \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7adec928_115eb345","line":89,"in_reply_to":"7adec928_6a63871a","updated":"2014-05-22 18:02:46.000000000","message":"Thank you so much. I just kept missing this.","commit_id":"aa87b4389c2911feb40a196b2259ea0ab98772aa"}],"doc/source/measurements.rst":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ee1908a5ae6db9e53d553d174e821527276547e6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":"volume                    Gauge       volume   vol ID    notification  Existence of volume"},{"line_number":183,"context_line":"volume.size               Gauge       GB       vol ID    notification  Size of volume"},{"line_number":184,"context_line":"snapshot                  Gauge       snapshot snap ID   notification  Existence of snapshot"},{"line_number":185,"context_line":"snapshot.size             Gauge       GB       snap ID   notification  Size of snap\u0027s backing volume"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7adec928_c24f3b91","line":184,"updated":"2014-05-08 20:13:54.000000000","message":"There are some unwritten formatting rules for these .rst files. One of these is that the header and footer lines of \u0027\u003d\u0027, which defines the width of a column, has to be as long as the longest word in each column. It is an unfortunate situation that the docs gate job does not fail in this situation, when this requirement is not fulfilled, I will write a bug report for this. The result of this misformatting of the table is that the build fails for this table and therefore it is not included in the doc. You can check it by opening the link that belongs to the gate job in the Jenkins results list. When you open the Measurements page, you can see that Cinder table is missing. You can try to build the doc before uploading the fix or you can check the doc after Jenkins has finished the verification.","commit_id":"3523edd459aab09c6baa502c2fd885a58e9467d9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"42b98832e7982f7ed45172c41c453feb04f09e4b","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":"Name                      Type        Unit     Resource  Origin        Note"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":"volume                    Gauge       volume   vol ID    notification  Existence of volume"},{"line_number":183,"context_line":"volume.size               Gauge       GB       vol ID    notification  Size of volume"},{"line_number":184,"context_line":"snapshot                  Gauge       snapshot snap ID   notification  Existence of snapshot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_bb7827c5","line":181,"updated":"2014-05-17 13:06:07.000000000","message":"The lines from \u0027\u003d\u0027 in the \u0027Unit\u0027 column should be at least 8 long, because \u0027snapshot\u0027 consists of 8 letters. The table is still missing from the doc, because the header and footer lines are shorter, than the content in the column, you can check it by opening the docs gate link in the Jenkins results.","commit_id":"311a713f463673e9e8299df0c45373492b1a88d3"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"aa73b8832cbc4a3a47f8026b2b95234cdbac60cd","unresolved":false,"context_lines":[{"line_number":182,"context_line":"volume                    Gauge       volume    vol ID    notification  Existence of volume"},{"line_number":183,"context_line":"volume.size               Gauge       GB        vol ID    notification  Size of volume"},{"line_number":184,"context_line":"snapshot                  Gauge       snapshot  snap ID   notification  Existence of snapshot"},{"line_number":185,"context_line":"snapshot.size             Gauge       GB        snap ID   notification  Size of snap\u0027s backing volume"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Make sure Cinder is properly configured first: see :ref:`installing_manually`."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7adec928_3170810a","line":185,"updated":"2014-05-19 11:11:55.000000000","message":"The Note of the \u0027snapshot.size\u0027 is not 100% clear to me, isn\u0027t something like \u0027Size of snapshot volume\u0027 is enough?","commit_id":"68e567c6486b71e1bac1caab9dd9f1549d42bcbc"},{"author":{"_account_id":5619,"name":"Koert van der Veer","email":"koert@cloudvps.com","username":"kvdveer"},"change_message_id":"f27274f77d21d955c68b3b5755c8b29f58fd4958","unresolved":false,"context_lines":[{"line_number":182,"context_line":"volume                    Gauge       volume    vol ID    notification  Existence of volume"},{"line_number":183,"context_line":"volume.size               Gauge       GB        vol ID    notification  Size of volume"},{"line_number":184,"context_line":"snapshot                  Gauge       snapshot  snap ID   notification  Existence of snapshot"},{"line_number":185,"context_line":"snapshot.size             Gauge       GB        snap ID   notification  Size of snap\u0027s backing volume"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Make sure Cinder is properly configured first: see :ref:`installing_manually`."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7adec928_fb47c1b9","line":185,"in_reply_to":"7adec928_3170810a","updated":"2014-05-20 05:15:27.000000000","message":"The concept of a snapshot\u0027s size is a bit funky. Obviously some sort of size is necessary for billing/accounting, but Cinder doesn\u0027t keep a size record. The only available datum is the size of the snapshot\u0027s volume.\nI\u0027ve gone with your suggestion.","commit_id":"68e567c6486b71e1bac1caab9dd9f1549d42bcbc"}]}