)]}'
{"ceilometer/polling/prom_exporter.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ddffeef479185fb4c6eae03fae18cb85c834fac6","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    labels[\u0027keys\u0027].append(\"type\")"},{"line_number":76,"context_line":"    labels[\u0027values\u0027].append(ctype)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    index \u003d 3"},{"line_number":79,"context_line":"    if (sample.get(\u0027counter_name\u0027, \u0027\u0027) !\u003d \u0027\u0027 and"},{"line_number":80,"context_line":"            sample.get(\u0027counter_name\u0027) is not None):"},{"line_number":81,"context_line":"        labels[\u0027keys\u0027].append(\"counter\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f4d14d0_8793e684","side":"PARENT","line":78,"updated":"2024-10-16 07:05:11.000000000","message":"nice catch!","commit_id":"f573c901257ea8dcb0a58c09f60293270deaced8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f1c4db9903100190f56a11ec1d437e2bccadced","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":123,"context_line":"            labels[\u0027values\u0027].append(resource_metadata[\u0027display_name\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if (resource_metadata.get(\u0027name\u0027, \u0027\u0027) !\u003d \u0027\u0027):"},{"line_number":126,"context_line":"            if labels[\u0027keys\u0027][-1] !\u003d \u0027resource_name\u0027:"},{"line_number":127,"context_line":"                labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":128,"context_line":"            if len(labels[\u0027keys\u0027]) \u003d\u003d len(labels[\u0027values\u0027]):"},{"line_number":129,"context_line":"                labels[\u0027values\u0027][-1] \u003d (labels[\u0027values\u0027][-1] + \":\" +"},{"line_number":130,"context_line":"                                        resource_metadata[\u0027name\u0027])"},{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                labels[\u0027values\u0027].append(resource_metadata[\u0027name\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # NOTE(jwysogla): The prometheus_client library doesn\u0027t support"},{"line_number":135,"context_line":"        # variable count of labels for the same metric. That\u0027s why the"}],"source_content_type":"text/x-python","patch_set":2,"id":"e15e0d9b_43630366","line":132,"range":{"start_line":125,"start_character":53,"end_line":132,"end_character":66},"updated":"2024-10-22 13:33:42.000000000","message":"Can\u0027t we simplify this like;\n\n```\n            if labels[\u0027keys\u0027][-1] !\u003d \u0027resource_name\u0027:\n                labels[\u0027keys\u0027].append(\"resource_name\")\n                labels[\u0027values\u0027].append(resource_metadata[\u0027name\u0027])\n            else:\n                labels[\u0027values\u0027][-1] \u003d (labels[\u0027values\u0027][-1] + \":\" +\n                                        resource_metadata[\u0027name\u0027])\n```","commit_id":"1d56f8e072af76e13761674301a1018fea521f7a"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"5ba566ee16e074f660171efbb16d8f613c09887c","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":123,"context_line":"            labels[\u0027values\u0027].append(resource_metadata[\u0027display_name\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if (resource_metadata.get(\u0027name\u0027, \u0027\u0027) !\u003d \u0027\u0027):"},{"line_number":126,"context_line":"            if labels[\u0027keys\u0027][-1] !\u003d \u0027resource_name\u0027:"},{"line_number":127,"context_line":"                labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":128,"context_line":"            if len(labels[\u0027keys\u0027]) \u003d\u003d len(labels[\u0027values\u0027]):"},{"line_number":129,"context_line":"                labels[\u0027values\u0027][-1] \u003d (labels[\u0027values\u0027][-1] + \":\" +"},{"line_number":130,"context_line":"                                        resource_metadata[\u0027name\u0027])"},{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                labels[\u0027values\u0027].append(resource_metadata[\u0027name\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # NOTE(jwysogla): The prometheus_client library doesn\u0027t support"},{"line_number":135,"context_line":"        # variable count of labels for the same metric. That\u0027s why the"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a904bc5_930644e2","line":132,"range":{"start_line":125,"start_character":53,"end_line":132,"end_character":66},"in_reply_to":"280904a6_6710667a","updated":"2024-10-22 18:22:02.000000000","message":"Your patch looks good to me.","commit_id":"1d56f8e072af76e13761674301a1018fea521f7a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ddfd292dba5e6fe109411259be61e45f1f45263","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":123,"context_line":"            labels[\u0027values\u0027].append(resource_metadata[\u0027display_name\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if (resource_metadata.get(\u0027name\u0027, \u0027\u0027) !\u003d \u0027\u0027):"},{"line_number":126,"context_line":"            if labels[\u0027keys\u0027][-1] !\u003d \u0027resource_name\u0027:"},{"line_number":127,"context_line":"                labels[\u0027keys\u0027].append(\"resource_name\")"},{"line_number":128,"context_line":"            if len(labels[\u0027keys\u0027]) \u003d\u003d len(labels[\u0027values\u0027]):"},{"line_number":129,"context_line":"                labels[\u0027values\u0027][-1] \u003d (labels[\u0027values\u0027][-1] + \":\" +"},{"line_number":130,"context_line":"                                        resource_metadata[\u0027name\u0027])"},{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                labels[\u0027values\u0027].append(resource_metadata[\u0027name\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # NOTE(jwysogla): The prometheus_client library doesn\u0027t support"},{"line_number":135,"context_line":"        # variable count of labels for the same metric. That\u0027s why the"}],"source_content_type":"text/x-python","patch_set":2,"id":"280904a6_6710667a","line":132,"range":{"start_line":125,"start_character":53,"end_line":132,"end_character":66},"in_reply_to":"e15e0d9b_43630366","updated":"2024-10-22 13:57:52.000000000","message":"See https://review.opendev.org/c/openstack/ceilometer/+/933013 which does further refactoring. If that refactoring looks good then I\u0027m ok to merge this now and merge that follow-up immediately.","commit_id":"1d56f8e072af76e13761674301a1018fea521f7a"}]}