)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5232b0ffddd96e4219ca7212ee02d73b6785d03","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm.status metric retrieves the numeric libvirt status"},{"line_number":10,"context_line":"from the domain info and exposes it as a metric, very"},{"line_number":11,"context_line":"useful to detect i.e. VMs in error state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icde2ec6e2b4b15d27864f2e0dd1ea89da89584de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"00842855_1f7860ba","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":41},"updated":"2024-11-14 14:57:14.000000000","message":"If you expect status field returned by nova then you are looking at the wrong field. What you are actually trying to add corresponds to power_state.","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6369b9a3c0d623ba2d271aaff9bb88e4f267ed4c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm.status metric retrieves the numeric libvirt status"},{"line_number":10,"context_line":"from the domain info and exposes it as a metric, very"},{"line_number":11,"context_line":"useful to detect i.e. VMs in error state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icde2ec6e2b4b15d27864f2e0dd1ea89da89584de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8cb7e670_ddc40268","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":41},"in_reply_to":"00842855_1f7860ba","updated":"2024-11-18 09:45:54.000000000","message":"I don\u0027t quite understand this. I might be wrong, but the only \"power_state\" reported by libvirt is \"virDomainState\", which is the one retrieved by this change.\n\nI have been looking at Nova\u0027s documentation regarding \"power_state\" (https://wiki.openstack.org/wiki/VMState) and the example states that appear in the documentation (such SHUTOFF or BLOCKED) correspond verbatim with the possible \"virDomainState\" values.\n\nWhen I say retrieving this could be useful to detect \"VMs in error state\", I was looking (and alarming)at the BLOCKED or CRASHED states, so I believe this I am retrieving the field I need here.\n\nCould you please point me in the direction of what field are you referring to regarding \"power_state\"?","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"611aa09fea1a7e739183a07019d2c245dcfde84a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm.status metric retrieves the numeric libvirt status"},{"line_number":10,"context_line":"from the domain info and exposes it as a metric, very"},{"line_number":11,"context_line":"useful to detect i.e. VMs in error state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icde2ec6e2b4b15d27864f2e0dd1ea89da89584de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"109b96c0_ff6699e4","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":41},"in_reply_to":"4dde8236_a8feb986","updated":"2024-11-18 15:40:40.000000000","message":"Ah, now I get it, thank you for the explanation.\n\nYes, I only want to get the libvirt state without Nova intervention.","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6262f09bc5d40f013f11ded7ad6ef2fdcb21114e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm.status metric retrieves the numeric libvirt status"},{"line_number":10,"context_line":"from the domain info and exposes it as a metric, very"},{"line_number":11,"context_line":"useful to detect i.e. VMs in error state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icde2ec6e2b4b15d27864f2e0dd1ea89da89584de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4dde8236_a8feb986","line":11,"range":{"start_line":11,"start_character":22,"end_line":11,"end_character":41},"in_reply_to":"8cb7e670_ddc40268","updated":"2024-11-18 15:38:23.000000000","message":"I understand you are adding the domain state in libvirt, which is equivalent to nova\u0027s power_state.\nI asked this because there are two layers where errors are defined, libvirt and nova. and the \"error state\" usually indicates the status defined in nova layer.\n\nThis is just for confirmation and if you really care about only actual domain status then it\u0027s ok.","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5232b0ffddd96e4219ca7212ee02d73b6785d03","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3baf8024_e1c56fd4","updated":"2024-11-14 14:57:14.000000000","message":"I agree with the idea but we may need some discussions about the naming.\n\nAlso please add a release note and update doc/source/admin/telemetry-measurements.rst .","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"95da3167135b9d8d8219460b0a46c01d357fbf5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d0a1943_d71f8831","updated":"2024-11-14 12:45:15.000000000","message":"Please ignore my previous comment, I thought that this was proposed direct to downstream","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"158e88733ac0f194a157f4f414014b6202a6daaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e69257b_ae2d70b8","updated":"2024-11-14 12:44:02.000000000","message":"Thank you. Where has this been reviewed upstream?","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"7d14b0d25c46e363ad578298f769991f1d1958bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"544e107c_73c3c984","updated":"2024-11-15 09:57:24.000000000","message":"would domain_info be a better name to use?","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6369b9a3c0d623ba2d271aaff9bb88e4f267ed4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2003df43_3a4f1b1a","in_reply_to":"3baf8024_e1c56fd4","updated":"2024-11-18 09:45:54.000000000","message":"Acknowledged","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ce0c1742615790f4d271c3d766488b3c5082c910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67a59961_dd801cd8","in_reply_to":"544e107c_73c3c984","updated":"2024-11-15 16:14:13.000000000","message":"DomainInfo in libvirt includes not only status but also a few other items such as max memory.\n\nhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainInfo\n\nSo domain_state might be the one which corresponds to libvirt\u0027s terminology but \"domain\" is not in the terminologies visible to users, as nova hides its hypervisor backend.\n\nOn the other hand, nova exposes domain\u0027s status as power_state in server APIs, which is why I suggested power_state.","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"f083b29b67aa5e9017b6e0c1515235b01abe2e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58d8b439_8481179b","in_reply_to":"9d0a1943_d71f8831","updated":"2024-11-14 13:19:46.000000000","message":"😊","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"610ae80876c8fa424926286459b943f206fc28e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d42216ce_d33959ea","updated":"2024-11-26 12:17:37.000000000","message":"One more note is that you have to add the new metric to /etc/ceilometer/polling.yaml so that it is captured.","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e2b62d76820dae509ca0aea25b43b943100c06f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86a206b1_cab5224f","updated":"2024-11-26 12:17:25.000000000","message":"The implementation looks good, but a few points need to be addressed before merge.\n\n1. Please update ceilometer/publisher/data/gnocchi_resources.yaml\n\n2. Could you add a release note to explain the new metric ? (see https://docs.openstack.org/reno/latest/user/usage.html )","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"de70f8a48b8c382fef986c7c6717c7b31fcee2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9860dbcb_759b98aa","in_reply_to":"86a206b1_cab5224f","updated":"2024-11-26 12:37:23.000000000","message":"Acknowledged","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"de70f8a48b8c382fef986c7c6717c7b31fcee2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fe717ce_7ede16fe","in_reply_to":"d42216ce_d33959ea","updated":"2024-11-26 12:37:23.000000000","message":"Ack","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"c66e1d55df1c772f437e2f3efbdced8d4ce21287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec02e798_9378879d","updated":"2024-11-26 14:51:43.000000000","message":"This is a nice value addition!","commit_id":"dab9630588e5bf334449a3794844c686e3acb734"}],"ceilometer/compute/pollsters/instance_stats.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e2b62d76820dae509ca0aea25b43b943100c06f3","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PowerStatePollster(InstanceStatsPollster):"},{"line_number":26,"context_line":"    sample_name \u003d \u0027power.state\u0027"},{"line_number":27,"context_line":"    sample_stats_key \u003d \u0027power_state\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4e763c92_7d97c537","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":30},"updated":"2024-11-26 12:17:25.000000000","message":"We can name this power_state because we don\u0027t expect adding more metrics to the \"power\" namespace but I think the current naming is also ok.","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"de70f8a48b8c382fef986c7c6717c7b31fcee2ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class PowerStatePollster(InstanceStatsPollster):"},{"line_number":26,"context_line":"    sample_name \u003d \u0027power.state\u0027"},{"line_number":27,"context_line":"    sample_stats_key \u003d \u0027power_state\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"38e57626_745ea603","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":30},"in_reply_to":"4e763c92_7d97c537","updated":"2024-11-26 12:37:23.000000000","message":"I prefer to go with the current naming because you never know about that in the future.","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"}],"ceilometer/compute/virt/inspector.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5232b0ffddd96e4219ca7212ee02d73b6785d03","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class InstanceStats(object):"},{"line_number":40,"context_line":"    fields \u003d ["},{"line_number":41,"context_line":"        \u0027vm_status\u0027,               # status of the vm"},{"line_number":42,"context_line":"        \u0027cpu_number\u0027,              # number: number of CPUs"},{"line_number":43,"context_line":"        \u0027cpu_time\u0027,                # time: cumulative CPU time"},{"line_number":44,"context_line":"        \u0027cpu_util\u0027,                # util: CPU utilization in percentage"}],"source_content_type":"text/x-python","patch_set":1,"id":"951447fd_4cf20047","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":18},"updated":"2024-11-14 14:57:14.000000000","message":"\"vm\" is not a terminology used in interfaces. Also this field is already part of the \"InstanceStats\" so having vm_ prefix sounds redundant.\n\nI wonder if \"power_state\" can be a better naming","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6369b9a3c0d623ba2d271aaff9bb88e4f267ed4c","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class InstanceStats(object):"},{"line_number":40,"context_line":"    fields \u003d ["},{"line_number":41,"context_line":"        \u0027vm_status\u0027,               # status of the vm"},{"line_number":42,"context_line":"        \u0027cpu_number\u0027,              # number: number of CPUs"},{"line_number":43,"context_line":"        \u0027cpu_time\u0027,                # time: cumulative CPU time"},{"line_number":44,"context_line":"        \u0027cpu_util\u0027,                # util: CPU utilization in percentage"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0ffc7e5_4f59bc70","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":18},"in_reply_to":"951447fd_4cf20047","updated":"2024-11-18 09:45:54.000000000","message":"Yes, it is a better name. I have a change incoming changing vm_status with power_state.","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"99b7548794051539463c269c52e864f7a2958c30","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class InstanceStats(object):"},{"line_number":40,"context_line":"    fields \u003d ["},{"line_number":41,"context_line":"        \u0027vm_status\u0027,               # status of the vm"},{"line_number":42,"context_line":"        \u0027cpu_number\u0027,              # number: number of CPUs"},{"line_number":43,"context_line":"        \u0027cpu_time\u0027,                # time: cumulative CPU time"},{"line_number":44,"context_line":"        \u0027cpu_util\u0027,                # util: CPU utilization in percentage"}],"source_content_type":"text/x-python","patch_set":1,"id":"25448068_50c49239","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":18},"in_reply_to":"b0ffc7e5_4f59bc70","updated":"2024-11-18 10:02:07.000000000","message":"Acknowledged","commit_id":"cdb34594a609e8a35673048714d2e0a31ed3f977"}],"doc/source/admin/telemetry-measurements.rst":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e2b62d76820dae509ca0aea25b43b943100c06f3","unresolved":true,"context_lines":[{"line_number":235,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":236,"context_line":"| **Meters added in the Epoxy release**                                       |"},{"line_number":237,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":238,"context_line":"| power.sta\\| Gauge | state| Instance | Pollster | Libvirt | virDomainState   |"},{"line_number":239,"context_line":"| te        |       |      | ID       |          |         | of the VM        |"},{"line_number":240,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5cfde60f_1f6e106f","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":30},"updated":"2024-11-26 12:17:25.000000000","message":"s/Instance/instance/","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"de70f8a48b8c382fef986c7c6717c7b31fcee2ac","unresolved":false,"context_lines":[{"line_number":235,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":236,"context_line":"| **Meters added in the Epoxy release**                                       |"},{"line_number":237,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":238,"context_line":"| power.sta\\| Gauge | state| Instance | Pollster | Libvirt | virDomainState   |"},{"line_number":239,"context_line":"| te        |       |      | ID       |          |         | of the VM        |"},{"line_number":240,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7308dd_2d0abe02","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":30},"in_reply_to":"5cfde60f_1f6e106f","updated":"2024-11-26 12:37:23.000000000","message":"Acknowledged","commit_id":"9ba26a57c61bba09d5ec95375120cd568c98dc28"}]}