)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"aa14cfa4c912a0dd6f487b75286ee386d13bb676","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be602851_997ba627","updated":"2025-01-20 13:10:38.000000000","message":"Thanks!","commit_id":"1b4c2cabfdfcc8e20567c38dbfd1c3c33ecc3c66"}],"ceilometer/tests/unit/compute/pollsters/test_diskio.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"163b41a00c1f3bcc64d3362084ea0b595cd0efc8","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        mgr \u003d manager.AgentManager(0, self.CONF)"},{"line_number":52,"context_line":"        cache \u003d {}"},{"line_number":53,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":54,"context_line":"        self.assertGreater(len(samples), 0)"},{"line_number":55,"context_line":"        cache_key \u003d pollster.inspector_method"},{"line_number":56,"context_line":"        self.assertIn(cache_key, cache)"},{"line_number":57,"context_line":"        for instance in self.instance:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4672821_5d8f7b28","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":43},"updated":"2024-12-03 15:32:38.000000000","message":"As we know from L53 that samples is definitely a list and not for example None, I think assertNotEqual(samples, []) would be more readable. Either of these are much better than assertTrue(samples) \u0027though!","commit_id":"c601c7a07d2a77cf5799330715c8938c8dbf5666"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"71a7b8dd34ef51b716969efe7ca03307bee12acc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        mgr \u003d manager.AgentManager(0, self.CONF)"},{"line_number":52,"context_line":"        cache \u003d {}"},{"line_number":53,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":54,"context_line":"        self.assertGreater(len(samples), 0)"},{"line_number":55,"context_line":"        cache_key \u003d pollster.inspector_method"},{"line_number":56,"context_line":"        self.assertIn(cache_key, cache)"},{"line_number":57,"context_line":"        for instance in self.instance:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dca4992c_3c79ec0e","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":43},"in_reply_to":"d4672821_5d8f7b28","updated":"2024-12-11 05:07:03.000000000","message":"Done.","commit_id":"c601c7a07d2a77cf5799330715c8938c8dbf5666"}]}