)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"29c3f8df41c841391ffd6382ac2201da321b65e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07e899a7_1aa802aa","updated":"2024-12-05 10:18:38.000000000","message":"Indeed the v2 API was removed from Cinder in Xena https://docs.openstack.org/api-ref/block-storage/v2/","commit_id":"bbc5436b5e5b787a155c8c999cfe4b192ac0edd7"}],"ceilometer/volume/discovery.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"29c3f8df41c841391ffd6382ac2201da321b65e5","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from ceilometer import keystone_client"},{"line_number":18,"context_line":"from ceilometer.polling import plugin_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"SERVICE_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027cinder\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027volumev3\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Cinder service type.\u0027),"},{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class _BaseDiscovery(plugin_base.DiscoveryBase):"},{"line_number":28,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"be8f8145_0b4daafe","line":25,"range":{"start_line":20,"start_character":0,"end_line":25,"end_character":1},"updated":"2024-12-05 10:18:38.000000000","message":"Is there any other service type for Cinder? Even the client version is hardcoded below on L36. With quick search I cannot find any reference to this config option either. We should just remove it?","commit_id":"bbc5436b5e5b787a155c8c999cfe4b192ac0edd7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7b699360026b4815d6dec6c0a6b0d4335a237d2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from ceilometer import keystone_client"},{"line_number":18,"context_line":"from ceilometer.polling import plugin_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"SERVICE_OPTS \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027cinder\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027volumev3\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Cinder service type.\u0027),"},{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class _BaseDiscovery(plugin_base.DiscoveryBase):"},{"line_number":28,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"62cf4864_440045d8","line":25,"range":{"start_line":20,"start_character":0,"end_line":25,"end_character":1},"in_reply_to":"be8f8145_0b4daafe","updated":"2024-12-06 05:07:24.000000000","message":"According to the official service type definition it can be also block-storage or block-store so I think we should keep the option for now.","commit_id":"bbc5436b5e5b787a155c8c999cfe4b192ac0edd7"}]}