)]}'
{"tox.ini":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c6ee9e2d1a7f005d7ed1696025373b06f595baac","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"deps \u003d"},{"line_number":33,"context_line":"commands \u003d"},{"line_number":34,"context_line":"    bash tools/config/generate_sample.sh -b . -p ceilometer -o etc/ceilometer"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7adec928_ad5390e0","line":32,"updated":"2014-05-16 17:13:46.000000000","message":"Some options needs to be read from oslo.messaging and keystoneclient.middleware.auth_token, so we cannot removing dependencies.","commit_id":"66f6fee6d25efcad89cd91ed41fe07006d0186f1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b5922db0a2173c2130f727cb39148f226d144379","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"deps \u003d"},{"line_number":33,"context_line":"commands \u003d"},{"line_number":34,"context_line":"    bash tools/config/generate_sample.sh -b . -p ceilometer -o etc/ceilometer"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7adec928_b5229db6","line":32,"in_reply_to":"7adec928_48a91ade","updated":"2014-05-20 13:12:36.000000000","message":"ok that make sense","commit_id":"66f6fee6d25efcad89cd91ed41fe07006d0186f1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"75619cf0c2a642119919e10b1ead97cd241d8817","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"deps \u003d"},{"line_number":33,"context_line":"commands \u003d"},{"line_number":34,"context_line":"    bash tools/config/generate_sample.sh -b . -p ceilometer -o etc/ceilometer"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7adec928_48a91ade","line":32,"in_reply_to":"7adec928_ad5390e0","updated":"2014-05-16 18:12:51.000000000","message":"tox will do a develop-install, it has same effect as specify deps \u003d -r{toxinidir}/requirements.txt, which means specify explicitly can be redundant","commit_id":"66f6fee6d25efcad89cd91ed41fe07006d0186f1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ca6c92b4b47138019148ce7b3b816f3c57773b24","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":33,"context_line":"commands \u003d"},{"line_number":34,"context_line":"    bash tools/config/generate_sample.sh -b . -p ceilometer -o etc/ceilometer"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"3ae8d1ca_2dffe468","line":32,"updated":"2014-05-28 12:26:09.000000000","message":"I really don\u0027t want to change the deps for sample generation. \n\nFor example, in the future, someone, in the mongo db driver, registers a new oslo.config option, but test-requirements is not used  (also pymongo not installed), the impl_mongo.py will be unloadable, and some option will miss in the config file.\n\nSo because test-requirement.txt can have some \u0027optional\u0027 dependencies, we must include it in the config file generation to ensure all configurations options will be generated.","commit_id":"95afb078897a28a244d594d706b64628e1bc37c1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"9615b4c81fa60a77a2ae7386554c883d495b3769","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:genconfig]"},{"line_number":32,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":33,"context_line":"commands \u003d"},{"line_number":34,"context_line":"    bash tools/config/generate_sample.sh -b . -p ceilometer -o etc/ceilometer"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"3ae8d1ca_900aaf1f","line":32,"in_reply_to":"3ae8d1ca_2dffe468","updated":"2014-05-29 03:12:57.000000000","message":"I think may be I understand what you worry about, because I\u0027ve already found that nova has a single option defined in test code which presents in nova.conf. However, I think that is not an ideal solution, because IIUC the nova.conf will be used in production, and a test only option may be some kind of pollution (personally I\u0027m ok with it)\n\nThe use case you mentioned will happen, but it should not let us pay for it right now, which means, if a developer register an option which will cause code cannot run just because it depends on some package defined in test-requirements.txt, he/she should move it to requirements.txt, that all. Even if he/she has same scenario with nova case I mentioned above, he should add the test-requirements.txt to genconfig env, or simply add that single package to deps. This is what I mean we should not pay for things not happen yet\n\nConsidering my main purpose is to ignore the conf.sample file which is bothering me, I think I\u0027d better remove this \u0027improvement\u0027 (just want it a bit faster like pep8), and simply fall back to the original problem.\n\nThanks","commit_id":"95afb078897a28a244d594d706b64628e1bc37c1"}]}