)]}'
{"ceilometer/cmd/sample.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"f9ef9757eae34f321ffafde47cd69f8e017e66db","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                   short\u003d\u0027y\u0027,"},{"line_number":39,"context_line":"                   help\u003d\u0027Meter type.\u0027,"},{"line_number":40,"context_line":"                   default\u003dsample.TYPE_GAUGE,"},{"line_number":41,"context_line":"                   choices\u003dsample.TYPES),"},{"line_number":42,"context_line":"        cfg.StrOpt(\u0027sample-unit\u0027,"},{"line_number":43,"context_line":"                   short\u003d\u0027U\u0027,"},{"line_number":44,"context_line":"                   help\u003d\u0027Meter unit.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"221fc231_db4dc298","line":41,"updated":"2025-03-31 11:23:12.000000000","message":"The choices parameter makes it required? I dont get why you are removing the required\u003dTrue from here.","commit_id":"27e1532420e95cab651fc8a1dde6d20ca7f5b8c3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c631f983f142794af277fa5ccc14458102fb890e","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                   short\u003d\u0027y\u0027,"},{"line_number":39,"context_line":"                   help\u003d\u0027Meter type.\u0027,"},{"line_number":40,"context_line":"                   default\u003dsample.TYPE_GAUGE,"},{"line_number":41,"context_line":"                   choices\u003dsample.TYPES),"},{"line_number":42,"context_line":"        cfg.StrOpt(\u0027sample-unit\u0027,"},{"line_number":43,"context_line":"                   short\u003d\u0027U\u0027,"},{"line_number":44,"context_line":"                   help\u003d\u0027Meter unit.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3114863_76435d73","line":41,"in_reply_to":"221fc231_db4dc298","updated":"2025-03-31 12:31:00.000000000","message":"required\u003dTrue has no effect if the default is set. It works only when the default value is None.","commit_id":"27e1532420e95cab651fc8a1dde6d20ca7f5b8c3"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"8b675f7860fa5ff6c8b5cb7aa580507b086605d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                   short\u003d\u0027y\u0027,"},{"line_number":39,"context_line":"                   help\u003d\u0027Meter type.\u0027,"},{"line_number":40,"context_line":"                   default\u003dsample.TYPE_GAUGE,"},{"line_number":41,"context_line":"                   choices\u003dsample.TYPES),"},{"line_number":42,"context_line":"        cfg.StrOpt(\u0027sample-unit\u0027,"},{"line_number":43,"context_line":"                   short\u003d\u0027U\u0027,"},{"line_number":44,"context_line":"                   help\u003d\u0027Meter unit.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f114adc_00a7b9fa","line":41,"in_reply_to":"9e565021_b8adea2f","updated":"2025-03-31 13:36:06.000000000","message":"Acknowledged","commit_id":"27e1532420e95cab651fc8a1dde6d20ca7f5b8c3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e11ef435eecb38b88aa253084237a24d34c79a83","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                   short\u003d\u0027y\u0027,"},{"line_number":39,"context_line":"                   help\u003d\u0027Meter type.\u0027,"},{"line_number":40,"context_line":"                   default\u003dsample.TYPE_GAUGE,"},{"line_number":41,"context_line":"                   choices\u003dsample.TYPES),"},{"line_number":42,"context_line":"        cfg.StrOpt(\u0027sample-unit\u0027,"},{"line_number":43,"context_line":"                   short\u003d\u0027U\u0027,"},{"line_number":44,"context_line":"                   help\u003d\u0027Meter unit.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e565021_b8adea2f","line":41,"in_reply_to":"a3114863_76435d73","updated":"2025-03-31 12:31:49.000000000","message":"(I mentioned the same in https://review.opendev.org/c/openstack/ceilometer/+/938877/2//COMMIT_MSG#12 , jfyi","commit_id":"27e1532420e95cab651fc8a1dde6d20ca7f5b8c3"}]}