)]}'
{"id":"openstack%2Fceilometer~940420","triplet_id":"openstack%2Fceilometer~master~I367d299df85676472c7e1a922d08971810f2ba9f","project":"openstack/ceilometer","branch":"master","topic":"dynamic-pollster-urljoin","attention_set":{},"removed_from_attention_set":{"36393":{"account":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"last_update":"2025-02-13 10:16:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I367d299df85676472c7e1a922d08971810f2ba9f","subject":"Dynamic pollsters: Append relative url_path to URLs","status":"MERGED","created":"2025-01-30 03:06:02.000000000","updated":"2025-02-13 10:17:54.000000000","submitted":"2025-02-13 10:16:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"940420-dynamic-pollster-urljoin","meta_rev_id":"b242116ba6ecf6a1acb2ea1b5c6eec16f686041e","_number":940420,"virtual_id_number":940420,"owner":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-13 10:16:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"recommended":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"all":[{"value":1,"date":"2025-01-30 08:26:32.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},{"value":2,"date":"2025-01-31 11:41:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2025-02-13 09:07:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"all":[{"value":0,"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":1,"date":"2025-02-13 09:07:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-30 04:20:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-30 08:26:32.000000000","updated_by":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"reviewer":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"state":"REVIEWER"},{"updated":"2025-01-31 11:41:36.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2025-02-13 09:07:01.000000000","updated_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"reviewer":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"state":"REVIEWER"}],"messages":[{"id":"c00c833588c0265da6592d73846ce51833c83eb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"date":"2025-01-30 03:06:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da1cc571af6974ee7590567b067064765eb323cf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-30 04:20:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3f399bdaa712470b8639fe086ecc8ef2\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e2c13c38f61a477194a4780deb0c54b0 : SUCCESS in 6m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b6085ce0eb8940668f996f8537086f4b : SUCCESS in 3m 22s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b0c21c976e0b4c6390f0d2cee52b354e : SUCCESS in 5m 05s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/356ac0e3b95641889c80c5ef2d96fc0b : SUCCESS in 5m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01b94226cde34d609121a042a2e50c4d : SUCCESS in 6m 55s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9ca5d4cd7a724adeb501edc070f3de3b : SUCCESS in 4m 42s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/7a55b2a4e7ed42259250bcac98f62c18 : FAILURE in 24m 13s (non-voting)\n- telemetry-dsvm-integration-centos-9s https://zuul.opendev.org/t/openstack/build/cb7c6880cf6c45baa84f65d26c450243 : FAILURE in 59m 43s (non-voting)\n- telemetry-dsvm-integration-centos-9s-fips https://zuul.opendev.org/t/openstack/build/c2167ccdf7594719a5c8408fe855408a : FAILURE in 1h 04m 16s (non-voting)\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/5b7234ec65dd48cc8a2db79e0512ba28 : SUCCESS in 34m 37s","accounts_in_message":[],"_revision_number":1},{"id":"a02d062cce506bdbff80e05c106b41c5ce9ef43d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"date":"2025-01-30 06:04:33.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"1017c8eb97c62a240cf0b94e7dea26608b5a1556","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"date":"2025-01-30 06:05:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"471739c05448791aecb928a137475789f4a082d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"date":"2025-01-30 06:53:15.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"b0b0a8396232ed34987231c5d343c5c54b322724","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-30 07:43:25.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3adafd0793cd4c4694c35735bb9eb342\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6f9cf95303b04591a12302655fabc7c5 : SUCCESS in 4m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/13cfff5515814fd4a06f8362daf80796 : SUCCESS in 3m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/af5a6f6708c84e3c9f2dc01ce91a9d24 : SUCCESS in 4m 22s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4c10c627c1884e62af8077f2d7a1f1a8 : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/815359c170354d119cc6b2446d87e90d : SUCCESS in 5m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9002be0baaf44772a3348fc3195b02aa : SUCCESS in 5m 21s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/3e7089a6063344d39b19150acde6d688 : FAILURE in 12m 35s (non-voting)\n- telemetry-dsvm-integration-centos-9s https://zuul.opendev.org/t/openstack/build/eea48e4f61934109ba165be14e078506 : FAILURE in 49m 02s (non-voting)\n- telemetry-dsvm-integration-centos-9s-fips https://zuul.opendev.org/t/openstack/build/ba883427ac0d4e72940a04124d61b72c : FAILURE in 40m 47s (non-voting)\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/5b4a6673156d4d3fb8371452b1141644 : SUCCESS in 34m 22s","accounts_in_message":[],"_revision_number":4},{"id":"806108e61cb50757429fb3ddca5a97b89d544970","author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"date":"2025-01-30 08:26:32.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"0ad624068e52821235d8263eefe218bc85a0a8ad","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2025-01-31 11:41:36.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"db8139d357a930f750d919298bf3d0d2982088c6","author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"date":"2025-02-13 09:07:01.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"34be05da6493a21312a49369f3914fbfef3f5176","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-13 09:07:39.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"72cfa673f881358310b55bb700de220fe227e51b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-13 10:16:48.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/589efd14c7fe4d8fa76c932550f9e14d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/61a037516a424289811639dcec8643c8 : SUCCESS in 4m 27s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a202978914b9469cbfb11aae7e55c399 : SUCCESS in 4m 29s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/9c6e85f67a7f4ed6bab87f3d4b3ab068 : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa7b8116e00c470fa62765ed8bd115e8 : SUCCESS in 6m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bb44131ab9aa4cc4b666439b8d370199 : SUCCESS in 6m 31s\n- grenade-ceilometer https://zuul.opendev.org/t/openstack/build/dead6734673b4d57be89f422fb4689e7 : FAILURE in 13m 27s (non-voting)\n- telemetry-dsvm-integration-centos-9s https://zuul.opendev.org/t/openstack/build/e951d35c37f74dd6a480a999f2fa2cd5 : SUCCESS in 53m 35s (non-voting)\n- telemetry-dsvm-integration-centos-9s-fips https://zuul.opendev.org/t/openstack/build/c8e42a379cfd4ffca19767030367e330 : SUCCESS in 1h 03m 45s (non-voting)\n- telemetry-dsvm-integration https://zuul.opendev.org/t/openstack/build/df2cb1266a95473489c34048bb07c6f4 : SUCCESS in 45m 00s","accounts_in_message":[],"_revision_number":4},{"id":"96644af2a45a4138b083fb3963c205ebc018dae0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-13 10:16:49.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4},{"id":"b242116ba6ecf6a1acb2ea1b5c6eec16f686041e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-13 10:17:54.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/852ae28b3198433b9013c5642dfdc599\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3f61dabdb88f4759948b064fcebbb01e : SUCCESS in 45s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/842cd8ee162d4d4a886f61dec647fc95 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0468126182e176e922db1c637e64a04c56fc4040","revisions":{"f6ea6758ec39ab65e3eb1371871e200577203fe3":{"kind":"REWORK","_number":1,"created":"2025-01-30 03:06:02.000000000","uploader":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"ref":"refs/changes/20/940420/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/20/940420/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/1"}}},"commit":{"parents":[{"commit":"9bb2891586987162e56229f6290da5e742fb13a1","subject":"Merge \"Fix outdated supported database backends\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9bb2891586987162e56229f6290da5e742fb13a1"}]}],"author":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 03:05:11.000000000","tz":780},"committer":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 03:05:59.000000000","tz":780},"subject":"Dynamic pollsters: Append relative url_path to URLs","message":"Dynamic pollsters: Append relative url_path to URLs\n\nWhen generating OpenStack API query URLs for dynamic pollsters,\nCeilometer uses urllib.parse.urljoin to append url_path to the\nendpoint URL.\n\nIf an API endpoint URL returned by Keystone does not have a\ntrailing slash and the specified url_path value is a relative\npath (e.g. does not start with /), urljoin will replace the\nfinal segment of the base URL instead of appending url_path to it.\n\nThis breaks generating links in dynamic pollsters for OpenStack services\nif the endpoint URL in the Keystone service catalog does not have a trailing\nslash. This is particularly relevant for OpenStack services that incorporate\nthe project ID into the API endpoint URL, such as Trove as shown below.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/mgmt/instances\u0027\n\nIf there is a trailing slash on the end of the base URL,\nurl_path will be appended to the end of the URL as expected.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678/\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/12345678/mgmt/instances\u0027\n\nThis commit changes the behaviour of the dynamic pollster URL joins\nby making sure there is a trailing slash on the endpoint URLs when\nappending the defined url_path to them.\n\nThis may break existing dynamic pollster configurations that rely\non this behaviour, but given that most OpenStack services probably\nwouldn\u0027t, there shouldn\u0027t be too many changes that would be required.\n\nChange-Id: I367d299df85676472c7e1a922d08971810f2ba9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/f6ea6758ec39ab65e3eb1371871e200577203fe3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/f6ea6758ec39ab65e3eb1371871e200577203fe3"}]},"branch":"refs/heads/master"},"fcf35a7abf5abd4591b4d680aa0a96775d5ec734":{"kind":"REWORK","_number":2,"created":"2025-01-30 06:04:33.000000000","uploader":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"ref":"refs/changes/20/940420/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/20/940420/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/2"}}},"commit":{"parents":[{"commit":"9bb2891586987162e56229f6290da5e742fb13a1","subject":"Merge \"Fix outdated supported database backends\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9bb2891586987162e56229f6290da5e742fb13a1"}]}],"author":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 03:05:11.000000000","tz":780},"committer":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 06:04:19.000000000","tz":780},"subject":"Dynamic pollsters: Append relative url_path to URLs","message":"Dynamic pollsters: Append relative url_path to URLs\n\nWhen generating OpenStack API query URLs for dynamic pollsters,\nCeilometer uses urllib.parse.urljoin to append url_path to the\nendpoint URL.\n\nIf an API endpoint URL returned by Keystone does not have a\ntrailing slash and the specified url_path value is a relative\npath (e.g. does not start with /), urljoin will replace the\nfinal segment of the base URL instead of appending url_path to it.\n\nThis breaks generating links in dynamic pollsters for OpenStack services\nif the endpoint URL in the Keystone service catalog does not have a trailing\nslash. This is particularly relevant for OpenStack services that incorporate\nthe project ID into the API endpoint URL, such as Trove as shown below.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/mgmt/instances\u0027\n\nIf there is a trailing slash on the end of the base URL,\nurl_path will be appended to the end of the URL as expected.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678/\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/12345678/mgmt/instances\u0027\n\nThis commit changes the behaviour of the dynamic pollster URL joins\nby making sure there is a trailing slash on the endpoint URLs when\nappending the defined url_path to them.\n\nThis may break existing dynamic pollster configurations that rely\non this behaviour, but given that most OpenStack services probably\nwouldn\u0027t, there shouldn\u0027t be too many changes that would be required.\n\nChange-Id: I367d299df85676472c7e1a922d08971810f2ba9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/fcf35a7abf5abd4591b4d680aa0a96775d5ec734"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/fcf35a7abf5abd4591b4d680aa0a96775d5ec734"}]},"branch":"refs/heads/master"},"3fb0a32de113da88ce1d32d5a6b120580ec5839e":{"kind":"REWORK","_number":3,"created":"2025-01-30 06:05:45.000000000","uploader":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"ref":"refs/changes/20/940420/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/20/940420/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/3"}}},"commit":{"parents":[{"commit":"9bb2891586987162e56229f6290da5e742fb13a1","subject":"Merge \"Fix outdated supported database backends\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9bb2891586987162e56229f6290da5e742fb13a1"}]}],"author":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 03:05:11.000000000","tz":780},"committer":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 06:05:32.000000000","tz":780},"subject":"Dynamic pollsters: Append relative url_path to URLs","message":"Dynamic pollsters: Append relative url_path to URLs\n\nWhen generating OpenStack API query URLs for dynamic pollsters,\nCeilometer uses urllib.parse.urljoin to append url_path to the\nendpoint URL.\n\nIf an API endpoint URL returned by Keystone does not have a\ntrailing slash and the specified url_path value is a relative\npath (e.g. does not start with /), urljoin will replace the\nfinal segment of the base URL instead of appending url_path to it.\n\nThis breaks generating links in dynamic pollsters for OpenStack services\nif the endpoint URL in the Keystone service catalog does not have a trailing\nslash. This is particularly relevant for OpenStack services that incorporate\nthe project ID into the API endpoint URL, such as Trove as shown below.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/mgmt/instances\u0027\n\nIf there is a trailing slash on the end of the base URL,\nurl_path will be appended to the end of the URL as expected.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678/\", \"mgmt/instances\")\n\u0027http://example.com:1234/v1.0/12345678/mgmt/instances\u0027\n\nThis commit changes the behaviour of the dynamic pollster URL joins\nby making sure there is a trailing slash on the endpoint URLs when\nappending the defined url_path to them.\n\nThis may break existing dynamic pollster configurations that rely\non this behaviour, but given that most OpenStack services probably\nwouldn\u0027t, there shouldn\u0027t be too many changes that would be required.\n\nChange-Id: I367d299df85676472c7e1a922d08971810f2ba9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/3fb0a32de113da88ce1d32d5a6b120580ec5839e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/3fb0a32de113da88ce1d32d5a6b120580ec5839e"}]},"branch":"refs/heads/master"},"0468126182e176e922db1c637e64a04c56fc4040":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-01-30 06:53:15.000000000","uploader":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"ref":"refs/changes/20/940420/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/20/940420/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/20/940420/4"}}},"commit":{"parents":[{"commit":"9bb2891586987162e56229f6290da5e742fb13a1","subject":"Merge \"Fix outdated supported database backends\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/9bb2891586987162e56229f6290da5e742fb13a1"}]}],"author":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 03:05:11.000000000","tz":780},"committer":{"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","date":"2025-01-30 06:52:45.000000000","tz":780},"subject":"Dynamic pollsters: Append relative url_path to URLs","message":"Dynamic pollsters: Append relative url_path to URLs\n\nWhen generating OpenStack API query URLs for dynamic pollsters,\nCeilometer uses urllib.parse.urljoin to append url_path to the\nendpoint URL.\n\nIf an API endpoint URL returned by Keystone does not have a\ntrailing slash and the specified url_path value is a relative\npath (e.g. does not start with /), urljoin will replace the\nfinal segment of the base URL instead of appending url_path to it.\n\nThis breaks generating links in dynamic pollsters for OpenStack services\nif the endpoint URL in the Keystone service catalog does not have a trailing\nslash. This is particularly relevant for OpenStack services that incorporate\nthe project ID into the API endpoint URL, such as Trove as shown below.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678\", \"mgmt/instances\")\n\u0027http://example.com:8779/v1.0/mgmt/instances\u0027\n\nIf there is a trailing slash on the end of the base URL,\nurl_path will be appended to the end of the URL as expected.\n\n\u003e\u003e\u003e urljoin(\"http://example.com:8779/v1.0/12345678/\", \"mgmt/instances\")\n\u0027http://example.com:8779/v1.0/12345678/mgmt/instances\u0027\n\nThis commit changes the behaviour of the dynamic pollster URL joins\nby making sure there is a trailing slash on the endpoint URLs when\nappending the defined url_path to them.\n\nThis may break existing dynamic pollster configurations that rely\non this behaviour, but given that most OpenStack services probably\nwouldn\u0027t, there shouldn\u0027t be too many changes that would be required.\n\nChange-Id: I367d299df85676472c7e1a922d08971810f2ba9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0468126182e176e922db1c637e64a04c56fc4040"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0468126182e176e922db1c637e64a04c56fc4040"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}