)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5c9e0a102be94eda746d309d19c0dcb4c3618a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b63f4191_244a1b78","updated":"2025-02-05 09:02:27.000000000","message":"I agree that this change is nice, but have a suggestion about the strategy to merge this feature which partially requires cinder change.","commit_id":"f39156be9e0ceeac42cf34350bf43067c3a9cb29"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"0e640cb7e2abd999ce9faeb689ab3053690cccd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d26ebdc_35af637b","updated":"2025-02-05 08:39:44.000000000","message":"I believe this is a big QoL improvement for Cinder volume metrics, and I am glad that we see Ceilometer updates following Services metrics improvements.","commit_id":"f39156be9e0ceeac42cf34350bf43067c3a9cb29"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"c9e6864359084c9f80f5aeaf1bf13dbf43a68cf0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef989dcc_bbbeb5b7","in_reply_to":"b63f4191_244a1b78","updated":"2025-02-05 20:16:41.000000000","message":"Thanks for the suggestion, when you think about it these really are two separate changes, so it makes sense to split them out.","commit_id":"f39156be9e0ceeac42cf34350bf43067c3a9cb29"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"2c0b9674dcb8209368b282bde7a400974473265e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09a89c99_0cd39f13","updated":"2025-09-09 07:24:51.000000000","message":"Callum, do you intend to rebase the Cinder patch and solve the merge conflicts there?","commit_id":"ab04317a4e91d9eb2e0ad516904f6f4a337a15d5"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"8ce4f699cf74a64372b464e78d972155e1f30b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb7cc4ca_75ba4617","updated":"2025-03-17 16:51:59.000000000","message":"I thought the Cinder change was already merged. That needs to go first.","commit_id":"ab04317a4e91d9eb2e0ad516904f6f4a337a15d5"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"943af760f77fcddeac28b6394c8e3f44dfbd2893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7af7cac_fe65a8fe","updated":"2025-03-17 18:33:35.000000000","message":"Yep, unfortunately I proposed the change fairly late in the cycle which means that nobody was able to look at until after feature freeze for 2025.1.\n\nI\u0027ll ask someone upstream to have another look now that the 2025.1 stable branch has been cut.","commit_id":"ab04317a4e91d9eb2e0ad516904f6f4a337a15d5"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"d1103766ac99c48ced1ec56c67f2d1f65b7d61ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"90c1571b_faed1335","in_reply_to":"09a89c99_0cd39f13","updated":"2025-09-09 07:27:25.000000000","message":"I do, but I think feature freeze has passed for the Cinder change so I was planning on picking this up for 2026.1.","commit_id":"ab04317a4e91d9eb2e0ad516904f6f4a337a15d5"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ed7868aeb37408c011359d98e288bedb78cfe899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1d242f4_0fc249dc","in_reply_to":"90c1571b_faed1335","updated":"2025-09-09 07:28:19.000000000","message":"ack","commit_id":"ab04317a4e91d9eb2e0ad516904f6f4a337a15d5"}],"releasenotes/notes/fix-volume_type-value-inconsistency-fb50d4fefe1c9605.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5c9e0a102be94eda746d309d19c0dcb4c3618a1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  - |"},{"line_number":23,"context_line":"    ``gnocchi_resources.yaml`` has been updated with changes to the"},{"line_number":24,"context_line":"    ``volume`` resource type. If you override this file in your deployment,"},{"line_number":25,"context_line":"    it needs to be updated."},{"line_number":26,"context_line":"fixes:"},{"line_number":27,"context_line":"  - |"},{"line_number":28,"context_line":"    In ``volume.size`` notification samples, the value of ``volume_type``"},{"line_number":29,"context_line":"    was a volume type ID, not the name of the volume type as returned"},{"line_number":30,"context_line":"    by the pollster meter. This has been fixed by using new additions to"},{"line_number":31,"context_line":"    the Cinder notification metadata schema to set ``volume_type`` to"},{"line_number":32,"context_line":"    the volume type\u0027s name instead of the ID. This makes the ``volume_type``"},{"line_number":33,"context_line":"    attribute consistent across both notification and pollster samples."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e61ed8c8_219c38e0","line":33,"range":{"start_line":25,"start_character":27,"end_line":33,"end_character":71},"updated":"2025-02-05 09:02:27.000000000","message":"So this part depends on the proposed change in cinder so can\u0027t be stated now until that one is merged.\nI think the way forward is to (1) split the change to two parts, the one to add volume_type_id and the other is to use volume_type_name attribute in notification samples if available, and (2) make the second change depend on the cinder change (using Depends-on:)","commit_id":"f39156be9e0ceeac42cf34350bf43067c3a9cb29"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"c9e6864359084c9f80f5aeaf1bf13dbf43a68cf0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  - |"},{"line_number":23,"context_line":"    ``gnocchi_resources.yaml`` has been updated with changes to the"},{"line_number":24,"context_line":"    ``volume`` resource type. If you override this file in your deployment,"},{"line_number":25,"context_line":"    it needs to be updated."},{"line_number":26,"context_line":"fixes:"},{"line_number":27,"context_line":"  - |"},{"line_number":28,"context_line":"    In ``volume.size`` notification samples, the value of ``volume_type``"},{"line_number":29,"context_line":"    was a volume type ID, not the name of the volume type as returned"},{"line_number":30,"context_line":"    by the pollster meter. This has been fixed by using new additions to"},{"line_number":31,"context_line":"    the Cinder notification metadata schema to set ``volume_type`` to"},{"line_number":32,"context_line":"    the volume type\u0027s name instead of the ID. This makes the ``volume_type``"},{"line_number":33,"context_line":"    attribute consistent across both notification and pollster samples."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"85ad6263_7709ea03","line":33,"range":{"start_line":25,"start_character":27,"end_line":33,"end_character":71},"in_reply_to":"e61ed8c8_219c38e0","updated":"2025-02-05 20:16:41.000000000","message":"1. Split the volume_type_id change into: https://review.opendev.org/c/openstack/ceilometer/+/940834\n2. Added Depends-On to the commit message.","commit_id":"f39156be9e0ceeac42cf34350bf43067c3a9cb29"}]}