)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1e5eb2bd88c2bc167548993be36cc18cd4a91d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e17b917_b4a6d3dd","updated":"2025-02-13 10:01:03.000000000","message":"I agree with the overall direction but have some suggestions inline.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"c82ba673136df8f1801e3acf803f3a7596cbb3d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe75a09b_39bd214b","updated":"2025-02-13 09:03:04.000000000","message":"Nice, thank you!","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"2541474fab584708eb09668bd5f01246db8e9811","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"97a5a02f_29236269","updated":"2025-02-13 11:05:25.000000000","message":"Apologies for the stream of commits. I\u0027ve now addressed the comments.","commit_id":"1cf93922a3ae285aeeeaa3ac84aaf5a194a3f3d4"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"008af8d1b3045a5f3870a980959dbed33dacfebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c78df029_03a348cc","updated":"2025-02-26 06:12:03.000000000","message":"Thank you!","commit_id":"36b40ed7deec6fcf81f8a9bfeead03bdb48362a8"}],"ceilometer/compute/pollsters/__init__.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1e5eb2bd88c2bc167548993be36cc18cd4a91d1","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        return getattr(stats, self.sample_stats_key)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _inspect_cached(self, cache, instance, duration):"},{"line_number":96,"context_line":"        cache.setdefault(self.inspector_method, {})"},{"line_number":97,"context_line":"        if instance.id not in cache[self.inspector_method]:"},{"line_number":98,"context_line":"            if self.inspector_method:"},{"line_number":99,"context_line":"                result \u003d getattr(self.inspector, self.inspector_method)("}],"source_content_type":"text/x-python","patch_set":2,"id":"9df73529_489594a1","line":96,"updated":"2025-02-13 10:01:03.000000000","message":"Can we just insert \n```\nif not self.inspector_method:\n    return (now(), [None])\n```\nhere ? IIUC it is not really benefitial to add a cache data with key None.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"aef5d778878bfd82563be5afe231bf98f327247c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        return getattr(stats, self.sample_stats_key)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _inspect_cached(self, cache, instance, duration):"},{"line_number":96,"context_line":"        cache.setdefault(self.inspector_method, {})"},{"line_number":97,"context_line":"        if instance.id not in cache[self.inspector_method]:"},{"line_number":98,"context_line":"            if self.inspector_method:"},{"line_number":99,"context_line":"                result \u003d getattr(self.inspector, self.inspector_method)("}],"source_content_type":"text/x-python","patch_set":2,"id":"e739c0a0_4268125e","line":96,"in_reply_to":"88a95b06_c4e7d1ce","updated":"2025-02-13 10:57:33.000000000","message":"The pollsters now use a different base class, so this is now no longer an issue.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"b047e4530f6d82dec12d364cf6a3cc752ad5d776","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        return getattr(stats, self.sample_stats_key)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _inspect_cached(self, cache, instance, duration):"},{"line_number":96,"context_line":"        cache.setdefault(self.inspector_method, {})"},{"line_number":97,"context_line":"        if instance.id not in cache[self.inspector_method]:"},{"line_number":98,"context_line":"            if self.inspector_method:"},{"line_number":99,"context_line":"                result \u003d getattr(self.inspector, self.inspector_method)("}],"source_content_type":"text/x-python","patch_set":2,"id":"88a95b06_c4e7d1ce","line":96,"in_reply_to":"9df73529_489594a1","updated":"2025-02-13 10:31:09.000000000","message":"I was conflicted on whether or not to do this. You\u0027re right, it\u0027s probably not beneficial. I\u0027ll just change it so that it returns that value without caching.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1e5eb2bd88c2bc167548993be36cc18cd4a91d1","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            monotonic_time\u003dpolled_time,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":142,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"},{"line_number":143,"context_line":"        for instance in resources:"},{"line_number":144,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a8f6798_faabd2c2","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":19},"updated":"2025-02-13 10:01:03.000000000","message":"I wonder if it is more simple if we override the whole get_samples function, instead of reusing the interface which is optimized to the pollsters dependent on stats exposed by libvirt.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"b047e4530f6d82dec12d364cf6a3cc752ad5d776","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            monotonic_time\u003dpolled_time,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":142,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"},{"line_number":143,"context_line":"        for instance in resources:"},{"line_number":144,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f03cb004_768fbc20","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":19},"in_reply_to":"1a8f6798_faabd2c2","updated":"2025-02-13 10:31:09.000000000","message":"Looking at the implementation of get_samples, I agree. This will probably work if I change it to something like this:\n\n```python\ndef get_samples(self, manager, cache, resources):\n    for instance in instances:\n        yield util.make_sample_from_instance(\n            self.conf,\n            instance,\n            name\u003dself.sample_name,\n            unit\u003dself.sample_unit,\n            type\u003dself.sample_type,\n            resource_id\u003dinstance.id,\n            volume\u003dvolume,\n            additional_metadata\u003dself.get_additional_metadata(\n                instance, stats),\n            monotonic_time\u003dpolled_time,\n        )\n```\n\nAt that point this would become pretty much just a generic pollster with `local_instances` as its discovery though. Given that you\u0027ve suggested that `disk.ephemeral.size` could also be made a pollster with this, I might split the pollsters out to a new file and make a minimal generic class that that.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"}],"doc/source/admin/telemetry-measurements.rst":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1e5eb2bd88c2bc167548993be36cc18cd4a91d1","unresolved":true,"context_lines":[{"line_number":126,"context_line":"| disk.root\\| Gauge | GB   | instance | Notific\\ | Libvirt | Size of root disk|"},{"line_number":127,"context_line":"| .size     |       |      | ID       | ation, \\ |         |                  |"},{"line_number":128,"context_line":"|           |       |      |          | Pollster |         |                  |"},{"line_number":129,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":130,"context_line":"| disk.ephe\\| Gauge | GB   | instance | Notific\\ | Libvirt | Size of ephemeral|"},{"line_number":131,"context_line":"| meral.size|       |      | ID       | ation    |         | disk             |"},{"line_number":132,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":133,"context_line":"| disk.dev\\ | Gauge | B    | disk ID  | Pollster | Libvirt | The amount of d\\ |"},{"line_number":134,"context_line":"| ice.capa\\ |       |      |          |          |         | isk per device   |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f95e3644_6bdc23f4","line":131,"range":{"start_line":129,"start_character":79,"end_line":131,"end_character":79},"updated":"2025-02-13 10:01:03.000000000","message":"I wonder if we can also add pollster support for ephemeral size ? I think the required information for it is also available.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"},{"author":{"_account_id":36393,"name":"Callum Dickinson","email":"callum.dickinson@catalystcloud.nz","username":"Callum027","status":"Catalyst Cloud"},"change_message_id":"b047e4530f6d82dec12d364cf6a3cc752ad5d776","unresolved":true,"context_lines":[{"line_number":126,"context_line":"| disk.root\\| Gauge | GB   | instance | Notific\\ | Libvirt | Size of root disk|"},{"line_number":127,"context_line":"| .size     |       |      | ID       | ation, \\ |         |                  |"},{"line_number":128,"context_line":"|           |       |      |          | Pollster |         |                  |"},{"line_number":129,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":130,"context_line":"| disk.ephe\\| Gauge | GB   | instance | Notific\\ | Libvirt | Size of ephemeral|"},{"line_number":131,"context_line":"| meral.size|       |      | ID       | ation    |         | disk             |"},{"line_number":132,"context_line":"+-----------+-------+------+----------+----------+---------+------------------+"},{"line_number":133,"context_line":"| disk.dev\\ | Gauge | B    | disk ID  | Pollster | Libvirt | The amount of d\\ |"},{"line_number":134,"context_line":"| ice.capa\\ |       |      |          |          |         | isk per device   |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"01c2b4a4_a91630f8","line":131,"range":{"start_line":129,"start_character":79,"end_line":131,"end_character":79},"in_reply_to":"f95e3644_6bdc23f4","updated":"2025-02-13 10:31:09.000000000","message":"Yes, it looks like it would be possible. I\u0027ll add it to the change if you like.","commit_id":"1452a72e101275564454e106fab8a403d178e1be"}]}