)]}'
{"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e5573802ea5b7d9f6c7e759620bcd9fb7d3d1155","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    :param query: Query instance"},{"line_number":118,"context_line":"    :param metaquery: dict with metadata to match on."},{"line_number":119,"context_line":"    \"\"\""},{"line_number":120,"context_line":"    # assert False"},{"line_number":121,"context_line":"    for k, value in metaquery.iteritems():"},{"line_number":122,"context_line":"        key \u003d k[9:]  # strip out \u0027metadata.\u0027 prefix"},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_ed045f19","line":120,"updated":"2014-05-20 10:52:27.000000000","message":"nit: needs to be removed.","commit_id":"0717a6dedb58826cbd9af77b9851010a12604726"},{"author":{"_account_id":5619,"name":"Koert van der Veer","email":"koert@cloudvps.com","username":"kvdveer"},"change_message_id":"e8e7b9dd1a35483bdcac9fd6ffc07859b09a3f4e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    :param query: Query instance"},{"line_number":118,"context_line":"    :param metaquery: dict with metadata to match on."},{"line_number":119,"context_line":"    \"\"\""},{"line_number":120,"context_line":"    # assert False"},{"line_number":121,"context_line":"    for k, value in metaquery.iteritems():"},{"line_number":122,"context_line":"        key \u003d k[9:]  # strip out \u0027metadata.\u0027 prefix"},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_bf48be2d","line":120,"in_reply_to":"7adec928_ed045f19","updated":"2014-05-20 11:03:46.000000000","message":"Oops, Done","commit_id":"0717a6dedb58826cbd9af77b9851010a12604726"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7af6a5653f2a1dd118dc8116ab9e71afceb7346a","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            group_attributes \u003d [getattr(models.Sample, g) for g in groupby]"},{"line_number":642,"context_line":"            select.extend(group_attributes)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        query \u003d session.query(*select).join(models.Sample)\\"},{"line_number":645,"context_line":"            .group_by(models.Meter.unit)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        if groupby:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_55b5d97b","line":644,"updated":"2014-05-20 13:06:15.000000000","message":"what is this change for? iiuc, session.query(*select) already resolves to:\n\n    select \u003ccolumns\u003e from meter, sample;\n\nexcept it resolves to a cross join (rather than inner) for some sql backends... which is why the filter was added.","commit_id":"b9246425e8c212dbbd8144f852cba4546e0426a5"},{"author":{"_account_id":5619,"name":"Koert van der Veer","email":"koert@cloudvps.com","username":"kvdveer"},"change_message_id":"283fcb53258ba48707acff7d1deb1c8b1ef0a8e4","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            group_attributes \u003d [getattr(models.Sample, g) for g in groupby]"},{"line_number":642,"context_line":"            select.extend(group_attributes)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        query \u003d session.query(*select).join(models.Sample)\\"},{"line_number":645,"context_line":"            .group_by(models.Meter.unit)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        if groupby:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_38c0444f","line":644,"in_reply_to":"7adec928_55b5d97b","updated":"2014-05-20 13:44:40.000000000","message":"In our setup, we saw queries fail due to missing the Sample table. I figured I caused although I didn\u0027t really base that assumption on anything. We couldn\u0027t really reproduce the issue properly, mostly due to an acute case of the hurries.\n\nI\u0027ll remove it.","commit_id":"b9246425e8c212dbbd8144f852cba4546e0426a5"}]}